Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(target): support electron preload async chunk loading #9188

Merged
merged 1 commit into from May 27, 2019

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented May 25, 2019

What kind of change does this PR introduce?

This is proposal feature PR to extend current webpack's target support for Electron (http://electron.atom.io/), named electron-preload. Please find below the description for what it's for with latest Electron changes.

What is preload script?

As name stands for, it is a script that will be loaded before other scripts run in the page. This script will always have access to node APIs no matter whether node integration is turned on or off (https://electronjs.org/docs/api/browser-window).

This script will be evaluated & executed before any web page load occurs when it's specified in option.

What changes in this PR?

Technically preload script shares majority in common with electron-renderer target. Only notable difference is it is not available to use JSONPTemplate to load async chunks: preload script doesn't have entry HTML, neither have known-lifetime document existence to attach jsonp functions into. In result, using await import() in preload script with electron-renderer won't work.

In contrast, preload script must have node.js api access all time, which means it can use NodeTemplate instead for async chunk loading. This PR makes new target inherits electron-renderer, swaps out JSONP to NodeTemplate.

Other targets like async-node or electron-main can't be used then?

Both target allows NodeTemplate but effectively defeats all specific configuration required for electron's renderer processes like Electron renderer external config and vice versa.

Why do you think this is important to be included in core?

Though this is trivial enough change, I think given recent Electron's design change makes this worthwhile.

From Electron@5, renderer process's nodeIntegration is being turned off by default (electron/electron#16235). This means in plain renderer process context, application code cannot access node / electron api directly. With this option turned off, recommended way is setup preload script to expose native functionality and let main renderer process only access those exposed api instead.

This means,

  1. preload script now becomes near de-facto initialization logic for most electron application
  2. loading time of preload script will be matter, cause time to load preload script will block main page loading
  3. especially 2 will be important as now preload script have to load most nodejs side function logic for main pages

and supporting async chunk loading will provide the amount of performance improvement over. Having webpack core expose specified target for preload and encouraging to use async chunk loading for preload can help easier optimization of preload script based application design pattern for electron applications.

Webpack's target config itself allows to specify function to override custom target, but so far I couldn't find way to inherit existing config to override few options only. Still, there is a possibility I may not fully aware around webpack config so it can be achieved trivially without expanding target list. Opened PR since change's trivial enough, can be closed easily in that case.

Did you add tests for your changes?
Not yet. I believe there are high chance this will not be accepted in core and would like to discuss feasiblity before shape PR further.

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
Webpack documentation around options.target needs to include new target.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff).

A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).

@kwonoj Please check if this is appliable to your PR and if you can add more test cases.

Read the test readme for details how to write test cases.

@sokra sokra merged commit 671cb18 into webpack:master May 27, 2019
@sokra
Copy link
Member

sokra commented May 27, 2019

Thanks

@kwonoj kwonoj deleted the electron-preload-target branch May 27, 2019 06:39
jtbaker added a commit to jtbaker/DefinitelyTyped that referenced this pull request Mar 12, 2020
* [@types/node] Add KeyObject and CipherKey to crypto's createHm… (#42604)

Update the createHmac function definition to accept KeyObject in addition to BinaryLike for the 'key' argument.
Update the createDecipheriv function definition to accept CipherKey instead of BinaryLike for the 'key' argument.

* [mixpanel-browser] Fix typo in property name (#42591)

* add new types for loadable/server 5.12 (#42590)

* add types for loadable/server 5.12

* add types for loadable/server 5.12

* fix: change definition according to cr

* fix: add test definitions

* Update `webpack-dev-middleware` to 3.7 (#42573)

* feat(webpack-dev-middleware): update to v3.7

- v2 created
- update configuration options to v3.7

https://github.com/webpack/webpack-dev-middleware/tree/v3.7.2#options

Thanks!

* fix(webpack-serve): fix v1 tests errors

- `The types of 'dev.logLevel' are incompatible between these types`
- `Types of property 'dev' are incompatible`

Required to pass test for `webpack-dev-middleware` changes

* Fix js-cookie types (#42483)

* Update js-cookie types

Calls to set return a string or undefined, not void, as seen here:
https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L7
https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L47

* Update js-cookie tests

* feat: types for @rdfjs/dataset (#42607)

* feat(karma-browserify): type definitions for v7.0 (#42599)

- definition file
- tests to cover options for Browserify and Watchify

https://github.com/nikku/karma-browserify#readme

Thanks!

* Add parse-prefer-header definition (#42615)

* add new type definition

* add information comments

* properly generate the files

* address feedback

* correct the package name

* css-selector-tokenizer: add types and tests (#42561)

* css-selector-tokenizer: add types and tests

* correct lint errors
apparently, the IDE's tslint extension does not report dtslint's output. my bad.

* Correct typo in tests

* Add types for simple-icons (#42541)

* Create types for [simple-icons]

* Add missing final newline

* Update CODEOWNERS

* Revert a53398139f1a05eba5acbc2c085ad8b5fce705f4

* Use `export =` instead of `export default`

as suggested by @PranavSenthilnathan

* fix lint errors

* [Faker] Remove non-existent methods (#42506)

* Update index.d.ts

* fix tests

* remove creditCardCVV method

* add missing space

* Update for evernote v2.0.5 (#42291)

* Update for evernote v2.0.5

* Better types for evernote

* Fix nodemailer tests on TS 3.4 and below (#42626)

The tests use Array.include, which is not available in Typescript before
3.5. I rewrote them to use Array.indexOf instead.

* Fixed bug (#42435)

* add @types/stopword (#42588)

* Add stopword type definitions

Project: https://github.com/fergiemcdowall/stopword

* add @types/stopword

* Fix blank after '{'

* Add type comments and fix rule's code

* Fix lint's rule

* Fix return value of removeStopword's function

* Update index.d.ts

* Update index.d.ts

* Update index.d.ts

* Update index.d.ts

* [reactstrap]: Export Util.setGlobalCssModule (#42489)

* [reactstrap]: Export Util.setGlobalCssModule

* [reactstrap]: Rename utils file

* Change return value type of grecaptcha.execute from Promise to PromiseLike (#42635)

* workbox-sw/v3: increase minimum version of TS to 3.0 (#42628)

Dependencies of workbox-sw v3 use types that are only defined in TS 3.0
and above.

* Add Slider component to types and test (#42409)

* Add Slider component to types and test

* Use correct syntax for adding definition authors

* react-flatpickr add underlying flatpickr instance property (#42620)

* feat(svgo): added missing plugins definition (#42533)

- `prefixIds` corrected
- `sortDefsChildren` added
- `convertEllipseToCircle` added
- tests updated with plugins tests

https://github.com/svg/svgo/releases/tag/v1.3.0

Thanks!

* [amqp-connection-manager] add waitForConnect (#42639)

* add waitForConnect

* remove trailing whitespace

* fix(rsocket-flowable): makes Single.error() generic (#42584)

* fix(rsocket-flowable): makes Single.error() generic

* use never instead

* .

* .

* [react-native-app-intro-slider] - Use type ViewStyle for prope… (#42641)

* Changes type of buttonStyle and paginationStyle to ViewStyle

* Remove obsolete type import

* Update definitions by section

* feat(simpl-schema): Export additional interfaces (#42536)

So that we can reuse them when declaring SimpleSchema arguments...

* feat(@blazor/javascript-interop): type definition for Blazor i… (#42392)

- type definition based on @microsoft/dotnet-js-interop
- tests

See: dotnet/aspnetcore#18902
/cc @ryanelian @mkArtakMSFT

Thanks!

* parse-prefer-header: More specific typings (#42642)

* parse-prefer-header: Allow null or undefined input

* parse-prefer-header: More explicit return value typing

* parse-prefer-header: amend contributor list

* parse-prefer-header: Support ReadonlyArray argument

* parse-prefer-header: Add separate tests for Array and ReadonlyArray

* [node-notifier]: add `timeout: false` option (#42303)

* [newrelic] adds waitForIdle option to #shutdown (#42643)

* [newrelic] adds waitForIdle option to #shutdown

* add contributor note

* [bull] fix: add missing low level methods (#42647)

* fix: add multi and toKey methods

* fix: return pipeline without promise

* test: add test

* style: fix lint

* [office-js] [office-js-preview] Add documentation for Coercion… (#42658)

* Pendo.io - make visitor.id optional in initialize() (#42653)

* Added missing $filter overload

Added missing $filter overload that allows multiple strings to translate and returns an object

* Make visitor.id optional

* Update tests

* Doc typo

* feat: add @commitlint/load (#42616)

* feat: add @commitlint/load

* fix: remove trailing comma in json

* fix: allow optional const enum

This const enum is not required for the definition to be useful.

* carbone-1.2 typings (#42645)

* feat(vue-feather-icons): Add vue-feather-icons type definition (#42644)

* Add combinations definition (#42655)

* [office-js] [office-js-preview] (Outlook) Mailbox.restUrl should incl... (#42661)

* [office-js] [office-js-preview] (Outlook) Mailbox.restUrl should include link to SharedProperties.targetRestUrl for shared folders scenario

* Update based on feedback

* atom: improve support for v1.40 (#42660)

* feat(find-cache-dir): update to v3.2 (#42550)

- v2 for backward compatibility
- migrate return type from `null` to `undefined`

https://github.com/avajs/find-cache-dir#readme

Thanks!

* Added method definition for new method in SDK (#42476)

* Added method definition for new method in SDK

The method can be found in the official documentation under "Removing a Discount": https://shopify.github.io/js-buy-sdk/

* Removed "WIP" from header

As requested here https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42476#pullrequestreview-362867622 by @PranavSenthilnathan

* Enabled dt-header as requested in PR

* Corrected version number to comply

1.11.0 to 1.11

* Removed empty space to fix: ERROR: no-trailing-whitespace

* Enable strictNullChecks 2/3 (#42650)

* feat(xo): type definition for v0.26 (#42542)

* feat(xo): type definition for v0.26

- definition file
- tests

https://github.com/xojs/xo/#config

Thanks!

* Correct export details as per PR comment

/cc @sheetalkamat

* Add missing `getFormatter` function as per PR comment

- implementation
- tests

/cc @sheetalkamat

* cache-manager: add store to Cache (#42554)

* Add @types for ntlm-client (#42081)

* Add @types/ntlm-client

* Remove namespace

* Replace import for reference types

* Make cache-manager tests strictNullChecks safe (#42686)

The new code in cache-manager wasn't strictNullChecks safe, which caused
problems because a community member enabled strictNullChecks in most
packages during the review period for that code.

This change just fixes the tests, although the optional methods on Store
are a bit suspicious. From skimming cache-manager's documentation, I
couldn't figure out if having the methods be optional was accurate.

* feat(react): exclude number from keyof JSX.IntrinsicElements (#42282)

It's required to exclude `number` type from `keyof JSX.IntrinsicElements` because of the case when `JSX.IntrinsicElements` has some additional declarations with indexer type, for example

```
declare namespace JSX {
    interface IntrinsicElements extends JSX.IntrinsicElements {
        [name: string]: SomeJSXElementType;
    }
}
```

* Improved meteor/universe:i18n typings. (#42664)

* Improved meteor/universe:i18n typings.

* Added meteor/universe:i18n tests.

* Added meteor/universe:i18n author.

* Ran prettier on meteor/universe:i18n.

* Changed var to let in meteor/universe:i18n.

* [yeoman-environment] Correct type for registerStub (#42636)

The code takes a constructor of type `Generator`, rather than an instance:

https://github.com/yeoman/environment/blob/36eb1a56a9205f6b524d8c554800de4d6d8d34fd/lib/environment.js#L343-L344

* feat(gremlin): Add `hasNext` and `[Symbol.asyncIterator]` to `… (#42672)

* Declare `hasNext` on `Traversal`

* Define `AsyncIterableIterator` for `Traversal`

Enables `for-await-of` use for query result iteration.

* [react-onsenui] Added AlertDialogButton (#42663)

https://onsen.io/v2/api/react/AlertDialogButton.html

* [amqp-connection-manager] Fix waitForConnect (#42677)

* webpack: add electron-preload to valid config targets (#42671)

Added in 4.33.0 (https://github.com/webpack/webpack/releases/tag/v4.33.0).

See also:
* https://github.com/webpack/webpack/pull/9188
* https://v4.webpack.js.org/configuration/target/#target

* Enable strictNullChecks 3/3 (#42667)

* [@types/recharts]: Added segment property to ReferenceLine com… (#42676)

* @types/recharts: Added segment property to ReferenceLine

* @types/recharts: SegmentItem Interface added, segment type changed to ReadonlyArray <SegmentItem>

* @types/recharts: segment type changed to Readonly<[SegmentItem, SegmentItem]>

* postman-collection: fixed types to reflect current SDK (#42582)

* postman-collection: RequestDefinition fixes

* postman-collection: CollectionDefinition fixes

* postman-collection: Collection fix

* postman-collection: Added missing field to Cookie

* postman-collection: Improved RequestAuthDefinition

* postman-collection: Adjusted tests

* postman-collection: prettified

* postman-collection: version bump

* postman-collection: updated version to reflect current SDK

* postman-collection: fixed version

* feat(express-session): correct `unset` option and bump to 1.17 (#42560)

- correct type of `unset` option as per documentation
- test update

Thanks!

* [serverless] Add awsProvider.request method (#42681)

* [serverless] Add awsProvider.request method

* [serverless] add some tests for request method

* [mongoose] propagate QueryHelpers through operations (#42477)

* mongoose: propagate QueryHelpers though operations

* chore: add test for helper

* [cesium] CesiumJS Model and ModelGraphics types (#42670)

* Model type updates

* add logarithmicDepthBuffer

* ModelGraphics updates

* reviert Entity orientation change

* fix build errors

* CR comments

* [ouibounce] add type definitions (#42680)

* Add subscribeToTopic to react-native-push-notification (#42563)

* Enable strictFunctionTypes (#42687)

* feat(jquery-migrate): definitions for jquery-migrate plugin (#42689)

- definition file
- tests

https://github.com/jquery/jquery-migrate#migrate-plugin-api

Thanks!

* Update ramda to use ts-toolbelt 6.3.3 or later (#42694)

* [codemirror] Add addon display/autorefresh (#42669)

* [codemirror] Add addon display/autorefresh

* [codemirror] Fix library name in comment

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42669#discussion_r385291863

* Create a new package: Matrix JS SDK (matrix-js-sdk) (#42673)

* init matrix-js-sdk

* make linter happy

* pass the tsc testing

* add create client

* make linter happy

* linting

* linting

* Added types for "react-final-form-listeners" (#42577)

* Added types for react-final-form-listeners

* feedback fixes

* New typings: japan-postal-code (#42700)

* clear to tests

* Clear to tests

* Failing tests fix

* fix failing tests

* fix failing tests

* fix failing tests

* [teslajs] add type definitions (#42699)

* Update types for gulp-imagemin (v7.0) (#42698)

* clear to tests

* Clear to tests

* feat(morgan): update morgan to v 1.9 (#42695)

This is minor update:
- version bump
- `TokenCallbackFn` return type redefinition to allow returning
`undefined`:
https://github.com/expressjs/morgan/commit/03765069ec594f60cdaadac0fafb3473fe72074e
- deprecate `buffer` option:
https://github.com/expressjs/morgan/commit/dafb4cd0682f95ab069c7a266303709054a1f40d
- reformat code

Thanks!

* add base_url property (#42665)

* add base_url property

add base_url property for interface Settings;
https://www.tiny.cloud/docs/configure/integration-and-setup/#base_url

* Update index.d.ts

* add base_url property

add base_url property for interface Settings;
https://www.tiny.cloud/docs/configure/integration-and-setup/#base_url

* fix: [@types/aws-lambda] add missing prop clientMetadata to Co… (#42707)

* [@types/chrome] Added 'silent' option to the chrome package (c… (#42708)

* node/tty - as of v10, readStream.setRawMode(mode) returns 'thi… (#41194)

* node/tty - as of v10, readStream.setRawMode(mode) returns 'this' instead of 'void'

* node/tty revert v11 changes

* node/tty updated v12 for setRawMode

* [@types/node] Fix subprocess.kill return type (#42709)

* 🤖 CODEOWNERS has changed (#42720)

* Made ComponentOverride generic (#42603)

Fixes type issues such as https://stackoverflow.com/questions/60382399/why-is-type-sfcanchorprops-not-assignable-to-type-sfc.

* feat: add types for @rollup/plugin-virtual (#42688)

* feat: add types for @rollup/plugin-virtual

* chore: rm 'node' from 'types'

* chore: set typescript version to 2.9

* chore: set typescript version to 3.7

* chore: fix lint issues

* added declarations for 'ip-subnet-calculator' (#42712)

* added declarations for 'ip-subnet-calculator'

* fixed lint for ip-subnet-calculator

* removed string type from decoded, as it's only an object (#42718)

* Add maintainer (#42722)

I'd like to propose adding gargroh to the list of maintainers for the
react-table types.  He's been active, and and more importantly, useful,
on both the react-table repo as well as this one and has offered to help
with maintaining the react-table types.

* [Simplebar] Add typing for v5 (#42654)

* move old typings in v2

* add new typings

* fix linter errors

* move tests under v2

* add more classes

* revert original comments in v2

* Create a new package: Matrix AppService Bridge (matrix-appservice-bridge) (#42702)

* reinit

* fix fixmes

* make linter happy

* [teslajs] fix wrong Vehicle interface (#42724)

* [teslajs] fix wrong Vehicle interface

* [teslajs] Fix async functions parameters

* Fix MemoryCache `get` function type to correctly reflect nulla… (#42726)

Returns null if no object present for given key; return type should reflect this.

* chai: Tighten argument types of assert.throw methods. (#42719)

* Refine argument types of assert.thorw methods.

* Add author.

* feat(mongodb): add connection TLS options (#42723)

- TLS options
- minor update to document to correct @default
- version bump to 3.5

http://mongodb.github.io/node-mongodb-native/3.5/api/MongoClient.html

Thanks!

* weixin-app: add missing members (#42731)

* add types jsreport-chrome-pdf

* jsreport-chrome-pdf: add options

* [jsreport-chrome-pdf]: add missing prop

* wexin-app: add missing interface members

* include version

* jsdoc

* add enum

* [Slonik] Added UUID type to TypeNameIdentifierType (#42632)

* Add types for @types/chart.js (tooltip model) (#42740)

* Add new tooltip model types

* Fix mistyping

* Remove thislooksfun from list of selenium-webdriver maintainers (#42747)

* Remove thislooksfun from list of Bluebird maintainers (#42746)

* feat(watchify): update to version 3.11 (#42600)

- refine `poll` configuration option type
- add `close` method
- add event supports
- update configuration to recommended one
- apply DT code format

https://github.com/browserify/watchify#methods

Thanks!

* add missing option `transformKey` in `flat` (#42613)

* transformKey + fix tests

* update version

* Fix libxmljs Document.find overloads (#42729)

* Add Document.find overloads

* Bump libxmljs version comment

* Add libxmljs tests of Document.find

* Revert "Bump libxmljs version comment"

This reverts commit 252f14107c1d33f7a1000bb08d32ea81cfbb36c2.

* matter-js: add render.options.wireframeBackground (#42754)

* Enrich sqs event with x ray trace header (#42762)

* [aws-lambda] New API Gateway Authorizer types, deprecating old… (#42420)

* [aws-lambda] Deprecate CustomAuthorizer*, new APIGateway*Authorizer*

Noticed this testing #42419.

When integrating a custom authorizer, you actually have two options,
creating a token or a request authorizer, which changes what payload
you will get. You nearly certainly know which you will be called with!

Just deprecating the old version as it's kinda broken in a way thats
hard to fix without breaking someone, but we want to guide devs to the
new version.

It is possible to fix the existing type by adding a bunch of
`foo?: never` fields to each alternative so existing accesses don't,
error but this makes things more complex, and confusing for the common
case.

Other ideas welcome!

* [aws-lambda] Add api-gateway authorizer parameters.

Fixes #34069, #42418

Ended up a bit messy, might be a bit much.

* [aws-lambda] Bump minimum typescript to 3.0

Required to fix failing $ExpectError in tests.
Surely nobody is still using pre-3.0?

* [aws-lambda] Enforcea API Gateway authorizer context narrowing

And implement the changes that API gateway does on the proxy request context for it.

Also rename TAuthorizer to TAuthorizerContext to be more clear that they should be the same type across both authorizer and proxy.

Some cleanups and fixes for names.

* feat: @rdfjs/fetch (#42763)

* feat: @rdfjs/fetch

* linted

* fix: dataset() and quadStream() are async

* add options.externalKey in koa-session (#42646)

* [d3-brush] Added keymodifiers definition (#42649)

* add types for @hapi/catbox-memcached (#42728)

* urijs: Correct UMD typings, remove implicit global declaration (#42543)

* urijs: Correct UMD typings, remove implicit global.

* urijs: add case for testing implicit global var in a script

* urijs: Add test to test UMD global in an ES module

* urijs: Undo unnecessary reformatting

* feat(karma-json-preprocessor): new type definition (#42738)

- type definitions
- tests

https://github.com/mjeanroy/karma-json-preprocessor#configuration

Thanks!

* feat(karma-json-to-file-reporter): add type definition (#42735)

- type definitions
- tests

https://www.npmjs.com/package/karma-json-to-file-reporter#config

Thanks!

* update(tar-stream): bump to v2 (#42734)

- v1 for backward compatibility
- change Pack.entry to be overloaded definition
- amend tests to reflect changes and add new tests

https://github.com/mafintosh/tar-stream/compare/v1.6.2...v2.1.0

Thanks!

* feat(parameterize): add parameterize typings (#42721)

* feat(parameterize): add parameterize typings

* with declare module

* Update parameterize-tests.ts

* Update index.d.ts

* Update parameterize-tests.ts

* Update index.d.ts

* Update parameterize-tests.ts

* Update index.d.ts

* Added type definitions for scrollbooster (#42745)

* Added type definitions for scrollbooster

* Added new lines for better readability

* Added more info on the project

* Extending the correct linter

* Add declarations for 'cron-converter'. (#42744)

* fix return type (#42770)

* Add @types/human-date (#42736)

* Add @types/human-date

* Change tests filename

* Delete human-date.ts

* Update human-date-tests.ts

* Update index.d.ts

* Update index.d.ts

* Add files via upload

* Add files via upload

* Add files via upload

* feat(filing-cabinet): type definitions for v2.5 (#42753)

- type definitions
- tests

https://github.com/dependents/node-filing-cabinet#usage

Thanks!

* feat(style-search): new type definition v0.1 (#42758)

- type definition
- tests

https://github.com/davidtheclark/style-search#options
https://github.com/davidtheclark/style-search#reporting-matches

Thanks!

* feat(file-entry-cache): type definition v5.0 (#42760)

- new type definitions
- tests coverage

https://github.com/royriojas/file-entry-cache#usage

Thanks!

* fix public property opts (#42769)

* fix public property opts

* remove implicit publish

* fix(lodash): No `strict` override (#42773)

* Add type definitions for "scrambo" (#42776)

* Add types for scrambo

* Satisfy linter

* Enable esModuleInterop

* Get rid of esModuleInterop

* newrelic adds distributed tracing Transaction handle method insertDistributedTraceHeaders (#42775)

* NewRelic: Adds insertDistributedTraceHeaders

* NewRelic: Adds insertDistributedTraceHeaders

* NewRelic: Adds insertDistributedTraceHeaders

* [office-js, office-js-preview, office-runtime] Changing codeowners (#42772)

* Removing prompt verbage from selection binding options

* Changing codeowners

* react-table: add maintainer (#42774)

Jason Clark <https://github.com/riceboyler> has offered to help maintain
this package and offered a good PR overlapping with the current open PR
which he then closed.  But it showed a good approach to the solution and
demonstrated an understanding of the problem space.

* [styled-system] Add missing margin and padding properties (#42766)

* feat(decomment): type definition for v0.9 (#42779)

- type definitions
- tests

https://github.com/vitaly-t/decomment#api

Thanks!

* feat(is-relative-path): type definition for v2 (#42780)

- type definitions
- tests

https://github.com/mrjoelkemp/is-relative-path#usage

Thanks!

* @mdx-js/react exports mdx (alias for React.createElement) (#42657)

* [@types/cesium] Add PropertyBag (#42782)

* property Bag

* add entity definition

* [@types/parse] Added AuthProvider and user function definitions (#42651)

* Added AuthProvider, user._isLinked, user._unlinkFrom, User.logInWith, User._registerAuthenticationProvider. Changed signature of user.linkWith to match the one in the Parse.User documentation

* Added tests for changed and added types

* Added changes to TS 3.7 as well

* Removed deprecated _linkWith from TS 3.7 definitions

* Fix typo (#42796)

* [stripe-v3] fix: add missing subtype 'validation_error' to ErrorType (#42789)

https://stripe.com/docs/api/errors

* matter-js: add mouse events (#42794)

* react-leaflet: fix GeoJSON data prop type + add test (#42800)

* [Express] [Type Update] Use generics for Response (#42662)

* use-generics-for-express-response-type: Use generics for Response in express

* use-generics-for-express-response-type: fixing ghost-storage-base-tests

* add color as mocha option (#42685)

* add @mocha package declaration for mocha.loadFilesAsync() (#42684)

* add declaration for Mocha.loadFilesAsync()

* add test for mocha.loadFilesAsync()

* [@types/rtp-parser] New Definition (#42784)

* add type definitions for https://www.npmjs.com/package/rtp-parser

* added test for payloadTypesHash

* make a generic version of the parseRtpPayloadType

* fixed some typos

* add test for generic number payload types

* feat(standard-engine): new type definition v12 (#42752)

* feat(standard-engine): new type definition v12

- type definitions
- tests coverage for day-to-day usage scenarios

https://github.com/standard/standard-engine#readme
https://github.com/standard/standard-engine#usage

Thanks!

* Prevent Linter class export as per PR comment

Should be used only as export `linter` alias.

/cc @gabritto

* Update default export of Diva.js (#42805)

* feat(gestalt): updated gestalt to newest types v1.10.0 (#42765)

* refactor(gestalt): updated gestlat to newest types

gestalt updated to now version v1.10.0

BREAKING CHANGE: Box, Mask, Touchable

* added tests

* removed licence

* array error

* Array<> error

* array<> error fixed

* void type error after test fixed

* error on masonry fixed

* [serverless] Add getAccountId method (#42692)

* Enable noImplicitAny (#42693)

* Update flatten typing under StyleSheet namespace. React-Native (#42790)

* Update flatten typing under StyleSheet namespace.

* Add test for stylesheet.flatten()

* Fxjs (#42797)

* add fxjs type

* add fxjs type

* add test

* add project

* add fxjs

* add file

* add

* add map, filter, find, flat, flatMap, every, delay, log

* add test

* tsconfig modify

* add fxjs-tests

* Fix typings of express-mysql-session (#42668)

* add corrected export and dependencie

* Update express-mysql-session-tests.ts

rewrite test for new version

* rename class

* fix linting

* feat(git-branch-is): new type definition for v3.1 (#42811)

- definition files
- test coverage

https://github.com/kevinoid/git-branch-is#api-usage

Thanks!

* [react-table]: V7 upgrade to support rc-16 (#42411)

* [react-table]: V7 upgrade to support rc-16

Support the changes in
https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md

Most of this in internal, by far the biggest user facing ripple is
flatColumns -> allColumns.

* add selectSubRows option

* remove column.show - no longer supported

* add className to TableCommonProps

* fix missing import, doh

* remove afters from ensurePluginOrder, it's effectively removed

* Update Hook definitions as well as address review comments

I've made a good effort to fix the types for the hooks, they look right,
but right now I have no code that uses them so they are at best
theoretical based on how they appear to be used in the code.

* [react-native] Specify more detailed type of `hardwareBackPress` handler (#42828)

* react-native: handleBackPress

* react-native: remove void from hardwareBackPress

* Added types for jest-sinon package (#42819)

* Add types for markdown-table (#42824)

* update to 15.3 (#42822)

* fix bugs with types

* fixed type errors

* more type errors fixed

* fixed errors and added missing type definitions

* fix all typos and added all missing ones

* change inappropriate names

* Updated names to be more accurate.

* adds EnumDWT_ConvertMode to make compatible with the old enum

* update to 14.2

* add v13

* delete v13 for test not pass

* remove base64

* fixed conflict

* add back GetLicenseInfo

* change header version to 14.2

* Added definitions for new APIs as well as APIs whose definitions were missing before. Also adding APIs for addons

* remove unused file

* adding types for barcode reader and changing the copyright year

* comment change, TS to 3.2.2

* adds more definitions to dwt barcode reader

* rollback

* update

* update index.d.ts

* Update Dynamsoft.d.ts

It's ok

* Update index.d.ts

1. update 2017 -> 2019
2. update parameters

* Update index.d.ts

rollback

* Update index.d.ts

rollback

* Update addon.pdf.ts

rollback

* Update index.d.ts

rollback

* Update index.d.ts

rollback

* Update index.d.ts

rollback

* Update index.d.ts

rollback

* Update index.d.ts

no changes but whites

* Update index.d.ts

TypeScript Version can be 3.2
2017 => 2019

* Update index.d.ts

rollback

* update

* Update index.d.ts

start new request

* Update index.d.ts

delete this file

* Update

delete this file

* a

a

* rollback

* update

* remove package.json

* add current version to v13

* 1) update to version 14.3.1
2) change index.d.ts declare Dynamsoft

* update comments

* remove WebTWAIN.d.ts

* change v13 tsconfig.json

* change to v14.3.1

* change to v14.3.1

* change to version 14.3

* change to version 14.3

* update

* update

* Update index.d.ts

* Update index.d.ts

* Update tsconfig.json

* Update tsconfig.json

* update

* update

* aa

* a

* a

* update

* remove dwt.d.ts

* remove v12

* update1

* update

* update

* a

* a

* a

* a

* a

* a

* a

* a

* d

* a

* a

* b

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* d

* change to v15

* add enums

* remove enums

* Updating to v15.0.2

* roll back to 1 previous version

* add back v15 APIs

* fix errors

* fix errors attempt 2

* update to 15.1

* upgrade to v15.2
add tag image

* fixed a few bugs

* fix grammar errors

* update a definition

* Fixed bug 'missing whitespace'

* update 15.3

* remove

remove

* remove blank line

remove blank line

Co-authored-by: Tom Kent <Tom-Dynamsoft@users.noreply.github.com>
Co-authored-by: Xiao Ling <lingxiao1002@gmail.com>

* [mongodb] Allow optional fields in $inc and $mul (#42821)

* Add deprecation schedule (#42834)

* Add deprecation schedule

and explain tags a bit more fully

* improved formatting

* [cesium] add constructor and removeProperty to PropertyBag (#42803)

* [cesium] add constructor definition for PropertyBag

* Cesium - add removeProperty to PropertyBag

* Add return type to removeProperty

* Make constructor value optional

* Don't make parameters on callback optional

* Add just-map-values and just-safe-set types (#42739)

* Add some just functions

* Fix some tests

* Fixes for code review

* Fix tests

* fix(jsdoc-to-markdown): correct module definition and update to v5 (#42732)

* fix(jsdoc-to-markdown): correct module definition and update to v5

- update module definition fixing errors like:
```bash
TSError: ⨯ Unable to compile TypeScript:
index.ts:3:10 - error TS2339: Property 'render' does not exist on type
'typeof import("../node_modules/@types/jsdoc-to-markdown/index")'.

3 jsdoc2md.render({ files: 'src/*.js' }).then(...)
```
After this change the module is exported as regular CommonJS module
- update version to v5
- create backward compatible v4
- rewrite tests to match CommonJS module exports

https://github.com/jsdoc2md/jsdoc-to-markdown/blob/master/docs/API.md#jsdoc-to-markdown

Thanks!

* Fix v4 module definition as per PR comment

- module exports correct also for v4
- tests corrected for v4

/cc @amcasey

* [@types/marked] fixed type of `marked.MarkedOptions.highlight` in case of async highlighting (#42579)

* [@types/marked] adjust `marked` function return types and callback being optional

* [@types/marked] update marked.MarkedOptions.highlight to reflect possible callback return types

* [@types/marked] add a test for the fixed edge case

* [@types/marked] add overloads to `marked` type definition to indicate sync/async functionality & return types

* [@marked/marked] update `marked.MarkedOptions.highlight` description to indicate sync/async functionality and intended return types

* [@types/marked] fix failing tests -- combine two overloads of `marked` default export

* [@types/marked] fix failing tests -- don't try to use a `void` return type

* [@types/marked] add description to overload; remove `return` from descriptions for synchronous overloads

* [react-native] update NativeEventEmitter constructor and removeAllListeners method (#42847)

* update NativeEventEmitter constructor and removeAllListeners method

* add NativeEventEmitter test

* Add null to constructor args

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* [plotly.js] - polar layout (#42832)

* [@types/recharts]: LabelListProps: dataKey should be optional if valueAccessor is defined (#42816)

* [@types/recharts]: LabelListProps: dataKey should be optional if valueAccessor is defined

Signed-off-by: Fabien Caylus <fabien.caylus@gmail.com>

* Update types/recharts/index.d.ts

Co-Authored-By: Konstantin Azizov <konstantin.azizov@theagilehub.net>

Co-authored-by: Konstantin Azizov <konstantin.azizov@theagilehub.net>

* Add description field for choices (#42809)

https://github.com/terkelg/prompts#selectmessage-choices-initial-hint-warn

* @testing-library__react: add debug options (#42837)

* @testing-library__react: add debug options

* Create package.json

* iab-vpaid: Correct AdVideoMidPoint to AdVideoMidpoint (lowercase 'p'). (#42792)

* [chance] add option definition for chance.cpf() (#42835)

* chance: add option definition for chance.cpf()

* chance: remove `?` in option definition for chance.cpf()

Co-Authored-By: Colby M. White <colbywhite@users.noreply.github.com>

Co-authored-by: Colby M. White <colbywhite@users.noreply.github.com>

* [@types/frida-gum]: update: make `Java.Wrapper` more generic (#42826)

* [@types/frida-gum]: update: make `Java.Wrapper` more generic

* [@types/frida-gum]: update: bump version

* [@types/frida-gum]: update: improved generic types
1. more generics, like `Java.cast`, `Java.Field`, etc.
2. `this` of `Java.MethodImplementation` is now strictly typed so it's no longer necessary to specify the generic type of implementations explicitly
3. rename `Properties` to `Members`
4. fix JSDoc of `Java.retain` and `Java.ClassFactory.retain`

* Add type IdleState to chrome.idle (#42852)

* Add type IdleState to chrome.idle

The chrome.idle API should use an IdleState type (https://developer.chrome.com/apps/idle) and like it's already used in chrome-apps (types/chrome-apps/index.d.ts).

* Remove trailing whitespace

* pdfmake - update v0.1.65 (#42814)

* add missing types and tests

* lint

* Remove enums from module

* spaces not tabs

* tslint indent rule

* update pdfmake version

* Remove minor version

* plaid-link: Add linkCustomizationName to CreateConfig (#42725)

Plaid Link now accepts a linkCustomizationName, user-defined on their dashboard,
 and passed in the CreateConfig.

* update(mongodb): MongoError `hasErrorLabel` missing from 3.5 (#42844)

This is minor change:
- add missing `hasErrroLabel` method to the MongoError
- mark `create` static method as deprecated
- updates JSDoc for error classes to use 3.5 version

Thanks!

* [jasmine] Support custom async matchers (#42850)

* Add types for custom async matchers

* Add self to owners

* feat(gravatar): missing 1.8 version features (#42843)

- correct DT header and package version
- `profile_url` method
- `cdn` options property
- `forceProtocol` aligned with documented `protocol`
- adding new method resulted in module shape correction (export `url`
and `profile_url` directly from the module
- tests updated
- update tslint config

https://github.com/emerleite/node-gravatar#usage
https://github.com/emerleite/node-gravatar#examples
https://github.com/emerleite/node-gravatar/blob/dd76e570872ffb5cd215874aeb91c3c5eff06ff0/Changelog.md#180

Thanks!

* [@type/react-infinite-calendar] Describe locale.locale in detail (#42703)

* update: locale.locale

* update: test case

* Update locale types in more detail

* added types for metric (#42730)

* added types for metric

* fixed lint

* fix(d3-scale): add missing symlog scale (#42733)

* add null as a valid return type of interceptors (#42842)

* [plotly.js] opacity to PlotData (#42866)

* Update Readme for Russian language (#42881)

* make @wordpress/block-editor types stricter (#42898)

Typescript@next is stricter about type parameters constrained to any;
they are default to unknown instead of any during inference for consistency with other
type parameters.

This means that the easiest workaround is to give a type parameter
constrained to `any` a default of `any` so that they once again
default to `any`.

That's what this PR does; it also has to give the subsequent type
parameter a default as well.

* Update CODEOWNERS (#42957)

Co-authored-by: TypeScript Bot <types@microsoft.com>

* Added 'pi-camera' type definition (#42857)

* Added pi-camera type definition

* Revised test file

* office-js-preview Page-to-Dialog messaging APIs (#42873)

* office-js-preview page to dialog messaging

* review changes

* feat(bearcat-es6) add type definition for bearcat-es6 0.6.1 (#42825)

* feat(bearcat-es6) add type definition for bearcat-es6 0.6.1

* fix(bearcat-es6) fix tslint rules

* fix(bearcat-es6) fix tslint rules

* fix(bearcat-es6) supplement some interface and fix some tslint bug

* fix(bearcat-es6) fix some tslint bug

* fix(bearcat-es6) fix some tslint bug

* fix(bearcat-es6) fix some tslint bug

* fix(bearcat-es6) fix some tslint bug

* fix(bearcat-es6) fix some tslint bug

* fix(bearcat-es6) fix some tslint error, and restore tslint rule to default

* Type definitions for FullCalendar-Vue (#42764)

* Add types for fullcalendar vue

* update dependencies

* added dependency

* update tests

* update tests

* updated type defs

* fix linting errors

* remove type and export interface

Co-authored-by: Nader Al-Shamma <naderal.shamma@mitrefinch.co.uk>

* Using generic types in List Component (#42827)

* Using generic types in List Component

* Added a working example

* Removed the space before type parameters

* [node] move to 13.9 (#42778)

* [node] move to 13.9

Added semver minor changes from 13.8/13.9 except crypto.

* add tests, add getHeapSnapshot

* fix lint

* [clockpicker] Enable noImplicitThis (#42900)

* matter-js: add Grid.bucketWidth, Grid.bucketHeight and update constraint render options (#42885)

* matter-js: add Grid.bucketWidth and Grid.bucketHeight

* matter-js: update constraint render options

* Extend matrix-js-sdk types (#42861)

* Extend matrix-js-sdk types

* Remove ts@next broken reference to node types from dependency

matrix-appservice-bridge doesn't need node types now

* [titanium] update types for Titanium 9.0.0 (#42856)

* update types for Titanium 9.0.0

* fix: re-apply changes from ffMathy

* feat(figma): Type definitions for update 14 (#42749)

* Add getTileUrl() method to TileLayer (#42859)

* [leaflet] Enable noImplicitThis (#42919)

* [jquery-knob] Enable noImplicitThis (#42913)

* [mailcheck] Enable noImplicitThis (#42921)

* [nestdb] Enable noImplicitThis (#42928)

* [classnames] Remove myself as maintainer. (#42897)

* [react-mdl] Enable noImplicitThis (#42938)

* Update README.ko.md (#42958)

* Added deprecation schedule to readme.es.md (#42963)

* [flatbuffers] Enable noImplicitThis (#42908)

* fix(bazinga-translator): correct definition to support UMD (#42629)

- correct module definition
- change test to verify CJ/ES6 and global

/cc @anaelChardan

Closes: #34552

* React countup upgrade definitions up to version 4.3.3 (#42748)

* update react-countup to version 4.3.3

* lint fixes

* update version

Co-authored-by: Ezequiel Surijon <esurijon@medallia.com>

* node-ssh: initial definition (#42964)

* Add wordpress-hash-node (#42959)

* Add node-phpass (#42894)

* Add node-phpass

* Add tests

* Hubot: Adds some missing, new, types to bring up to date for v3 (#42756)

* Hubot: build off existing types to match more closely with API Surface are of v3

* fix base tests

* Fixes some unnecessary generics

* fix some more style items

* fix some generics

* adding more robot tests

* see if this fixes some

* specify version

* Despecify

* move comments up a bit

* up again

* add some brain tests

* Make robot properties readonly to help protect against silliness

* set bug version

* don't want a patch version apparently

* drop the ts version

* drop unnecessary unknowndata interface

* 3.0 for unknown

* Fix(sdp-transform) bandwidth should be array (#42890)

https://github.com/clux/sdp-transform/blob/32da4469b85d1198c0524e3118827dd6085adc97/lib/grammar.js#L39

* [react-infinite-scroller] Enable noImplicitThis (#42936)

* [react-select] Enable noImplicitThis (#42939)

* [office-js] (Outlook) Removed restUrl link to SharedProperties (#42864)

* [office-js] [office-js-preview] (Outlook) Removed restUrl link to SharedProperties

* Keep link to object in preview

* [@types/jest] Improve toContain matcher description. (#42965)

* [ember-testing-helpers] Enable noImplicitThis (#42906)

* [redux-promise] Enable noImplicitThis (#42945)

* [through2] Enable noImplicitThis (#42953)

* [styled-system] Allow null ResponsiveValue (#42961)

* Remove unneeded cast in lyricist tests (#43017)

* new types for package "overload-protection" (#42886)

* types for overload-protection

* prettier formatting

* added parameter type for logging function

Co-authored-by: Daniel Hirth <daniel.hirth@wolterskluwer.com>

* [mongoose] Define lean() result type (#42652)

* [pino] add `levelKey` option, deprecate `changeLevelName` option (#42887)

* [lingui__react]: Add i18nHash to withI18n (#42838)

* Add locale types (#42968)

* [react] Enable noImplicitThis (#42940)

* add cloudevents-sdk/v03 types (#38067)

* add cloudevents-sdk/v03 types

ignore no-single-declare-module because cloudevents-sdk/v03 is the documented way to import the cloudevent builder

add cloudevents-sdk header

module warning ignore

* move CloudEvent interface into module, use named export for event()

* use default export with event() as a prop to fix 'no default export' TS warning

* allowSyntheticImports for cloudevents-sdk

* VS Code 1.43.0 Extension API (#43028)

Co-authored-by: VSCode <vscode@microsoft.com>

* [office-js, office-js-preview] Update with latest from CDN (#42848)

* Removing prompt verbage from selection binding options

* office-js

* office-js-preview

* feat(testing-library/dom): Add name option to byRole (#42892)

* feat(testing-library/dom): Add name option to byRole

* Bump version

* Allow resolveTo/rejectWith with empty parameters (#42967)

* [@types/urijs] Added properties and methods: duplicateQueryParameters, escapeQuerySpace, preventInvalidHostname (#43025)

* added missing properties and methods:
- duplicateQueryParameters
- escapeQuerySpace
- preventInvalidHostname

* added author.

* [naver-whale] Enable noImplicitThis (#42926)

* [react-data-grid] Enable noImplicitThis (#42932)

* [mongoose] Fix _id type of lean() result (#43039)

* [emscripten] Fix addFunction arg type (#42974)

* [wu] Enable noImplicitThis (#42955)

* Update types for Redux-state-sync (#42979)

* update types

* update test case

* add test case

* update version

* update header

Co-authored-by: aohua <aohua@percy.sg>

* fix(cesium): missing objects added (#42960)

* fix(cesium): missing objects added

- `MapboxStyleImageryProvider`
https://cesium.com/docs/cesiumjs-ref-doc/MapboxStyleImageryProvider.html
- `MapboxImageryProvider`
https://cesium.com/docs/cesiumjs-ref-doc/MapboxImageryProvider.html

Fixes: #42880

Thansk!

* Revert version bump as per PR comment

/cc @jrafidi

* Remove ambient module declaration in 'randomColor'. (#43033)

* @types/react-native-video: Add type for onBuffer argument (#42891)

* fix(autoprefixer): correct deprecated properties (#42981)

- added deprecated options that are still in the api, but not documented
as public option anymore
- documentation for `overrideBrowserslist` updated

https://github.com/postcss/autoprefixer/blob/master/lib/autoprefixer.js#L68-L93

Thanks!

* Pg: Adds a boolean value for the parseInputDatesAsUTC ClientConfig option (#42849)

Co-authored-by: Cédric Taschereau <cedric.taschereau@boreal-is.com>

* [ngreact] Enable noImplicitThis (#42929)

* fix username of unindented (#42972)

* [mongoose] Use mongodb.FilterQuery type (#42617)

* react-native: fix broken link for AppRegistry. (#43068)

* [office-js-preview] (Outlook) Body.appendOnSendAsync (#42846)

* [office-js-preview] (Outlook) Body.appendOnSend

* Fix typo

* Updates based on feedback

* Tweaks

* Removed cleanup tweaks based on feedback

* Undo

* Note how to clear call

* Note append on send runs before ItemSend functionality

* Remove unsupported tab control and visiblility flag (#42999)

Co-authored-by: Sudhi <Murthy@sudhipro15.fios-router.home>

* Add types for inline-critical (#43000)

* Test plotly.js package publishing

Remove "minimum TS" line since 2.3 has been deprecated.

* [layui-layer] Add types for layui-layer (#42976)

* layui-layer

* Update index.d.ts

* Jquery cropper (#42973)

* commit jquery-croper type definitions

commit jquery-croper type definitions

* Update index.d.ts

Update index.d.ts, correcting the version of the cropper and remove unnecessary comments.

* update tsconfig

Adding "strictFunctionTypes": true to tsconfig.json file.

* Update index.d.ts & tslint.json

Removing
declare module "jquery-cropper" {
}, and fixing the Project url

* update "interface-name" property

set "interface-name" property to false in tslint.json

* update tslint

* remove the patch version from index.d.ts

* update rules in tslint.json

* completely remove the patch digit

* remove "v" from MAJOR.MINOR

* Update tslint.json

enabled interface-name property

* adjust interface-name rule

adjust interface-name rule to "interface-name": [true, "never-prefix"]

* remove I from interface name

remove I from interface name

* added new line to last line

added new line to last line

* Add missing labelTextStyle - react-native-material-dropdown (#42771)

* Add missing labelTextStyle

* Update index.d.ts

* feat(obsolete-web): new package definition (#42983)

- definition files
- tests for global/CommonJS usage

https://github.com/ElemeFE/obsolete-webpack-plugin/tree/master/packages/obsolete-web

Thanks!

* [office-js] [office-js-preview] (Outlook) AttachmentDetails.contentType Read mode only (#43048)

Co-authored-by: Stuart Kennedy <26479125+rav2040@users.noreply.github.com>
Co-authored-by: Leona Kuse <leona.kuse@gmail.com>
Co-authored-by: Juan Pablo Vargas <jupavar@gmail.com>
Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>
Co-authored-by: Tom B <5631509+track0x1@users.noreply.github.com>
Co-authored-by: Tomasz Pluskiewicz <tpluscode@users.noreply.github.com>
Co-authored-by: Vincenzo Chianese <vincenz.chianese@icloud.com>
Co-authored-by: Avi Vahl <avi.vahl@wix.com>
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
Co-authored-by: Leonardo Testa <leitotesta@gmail.com>
Co-authored-by: Felipe Castillo <1280530+fcastilloec@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Co-authored-by: Donatas Lučiūnas <donatas.luciunas@gmail.com>
Co-authored-by: Rico Sandyca Novenza <ricosandyca.if@gmail.com>
Co-authored-by: Kyle Tsang <6854874+kyletsang@users.noreply.github.com>
Co-authored-by: Veniamin Krol <153412+vkrol@users.noreply.github.com>
Co-authored-by: trumanshuck <59452077+trumanshuck@users.noreply.github.com>
Co-authored-by: Justin Leider <justin@leiders.org>
Co-authored-by: Igor Morozov <morozov.ig.s@gmail.com>
Co-authored-by: David Hearnden <hearnden@canva.com>
Co-authored-by: Oliver Welter <oliver.welter@gmx.net>
Co-authored-by: Baptist BENOIST <2091902+bbenoist@users.noreply.github.com>
Co-authored-by: Marcell Toth <marcell@marcelltoth.net>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Dylan Smith <dylansmith@gmail.com>
Co-authored-by: Julian Hundeloh <jaulz@users.noreply.github.com>
Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>
Co-authored-by: Aaron Beall <contact@abeall.com>
Co-authored-by: Martin McWhorter <martin@mcwhorter.org>
Co-authored-by: Artur Nerkowski <a.apatryda@gmail.com>
Co-authored-by: Takuma HANATANI <mail@potato4d.me>
Co-authored-by: Rafa Mel <rafamel@users.noreply.github.com>
Co-authored-by: Glen M <glencfl@gmail.com>
Co-authored-by: Juan Manuel Incaurgarat <juanofx@gmail.com>
Co-authored-by: Jack Bates <jack@nottheoilrig.com>
Co-authored-by: jwigley <jwigley@gmail.com>
Co-authored-by: Manuel Borrajo <borrajo@hotmail.com.ar>
Co-authored-by: Artur Kenzhaev <kenzhaev.artur@gmail.com>
Co-authored-by: Radosław Miernik <radekmie@gmail.com>
Co-authored-by: Stuart Knightley <stuart@stuartk.com>
Co-authored-by: Keith Kirton <keith1024@users.noreply.github.com>
Co-authored-by: LBLZR_ <avojtus@gmail.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Eric Kuznetsov <kuznetsov.eric@gmail.com>
Co-authored-by: Karol Maciaszek <karol@maciaszek.pl>
Co-authored-by: coyoteecd <47973420+coyoteecd@users.noreply.github.com>
Co-authored-by: Jonathan Burke <jonathan.burke.1311@googlemail.com>
Co-authored-by: morgansierrasnyder <morgan.s.snyder@gmail.com>
Co-authored-by: Krzysztof Gutkowski <krzysio.gutkowski@gmail.com>
Co-authored-by: Miklós András Danka <danka.miklos@gmail.com>
Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
Co-authored-by: mtgto <hogerappa@gmail.com>
Co-authored-by: Huan (李卓桓) <zixia@zixia.net>
Co-authored-by: Yuri Drabik <yurist38@mail.ru>
Co-authored-by: TokugawaT_YD <41653501+TokugawaTakesi@users.noreply.github.com>
Co-authored-by: Mzoro <32166698+MzoroHaHa@users.noreply.github.com>
Co-authored-by: Menno <menno@tammens.net>
Co-authored-by: Sebastiaan Pasma <sebastiaan@enkodo.nl>
Co-authored-by: Chris Bajorin <cdbajorin@users.noreply.github.com>
Co-authored-by: lsnch <20382674+lsnch@users.noreply.github.com>
Co-authored-by: TypeScript Bot <ts_bot@rcavanaugh.com>
Co-authored-by: Sun Knudsen <hello@sunknudsen.com>
Co-authored-by: ed eustace <ed.eustace@gmail.com>
Co-authored-by: SGT <dahool@users.noreply.github.com>
Co-authored-by: Ivan Sieder <35377072+ivansieder@users.noreply.github.com>
Co-authored-by: Guy Gascoigne-Piggford <guy@wyrdrune.com>
Co-authored-by: Valikhan Akhmedov <ahmedoolo@mail.ru>
Co-authored-by: Oblarg <emichaelbarnett@gmail.com>
Co-authored-by: Chen <cxuesongc@outlook.com>
Co-authored-by: taoqf <tao_qiufeng@126.com>
Co-authored-by: MrFragIT <matteo_crosta@fastwebnet.it>
Co-authored-by: MarcoRu <Marcoru97@users.noreply.github.com>
Co-authored-by: thislooksfun <thislooksfun@repbot.org>
Co-authored-by: Oz Weiss <ozwi@soluto.com>
Co-authored-by: Bill Sorensen <baldgoth@gmail.com>
Co-authored-by: slikts <dabas@untu.ms>
Co-authored-by: KozelAnatoliy <kozelanatoliy93@gmail.com>
Co-authored-by: Simon Buchan <simon.buchan@skilitics.com>
Co-authored-by: vvnab <vvnab@mail.ru>
Co-authored-by: woutervh- <admin@woutervh.com>
Co-authored-by: Avery Fay <avery@shadypixel.com>
Co-authored-by: Eduardo Turiño <eturino@eturino.com>
Co-authored-by: Chris Neven <c.k.neven@live.nl>
Co-authored-by: Douglas Antunes <DouglasAntunes@users.noreply.github.com>
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-authored-by: Christopher Mühl <github@padarom.io>
Co-authored-by: Kenneth Aasan <k.aasan@sportradar.com>
Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com>
Co-authored-by: Jeffrey Cherewaty <jeffrey@cherewaty.com>
Co-authored-by: Tomas Carnecky <tomc@caurea.org>
Co-authored-by: Crocsx <federicogiacomini@outlook.com>
Co-authored-by: Kent Robin <kentrh@gmail.com>
Co-authored-by: Jannic Beck <jannicbeck@gmail.com>
Co-authored-by: Kohei Matsubara <matsubygh@gmail.com>
Co-authored-by: a-sync <a-sync@users.noreply.github.com>
Co-authored-by: Puneet Arora <puneetarora.er@gmail.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Co-authored-by: Sean Sellek <me@seansellek.com>
Co-authored-by: Matthew <smith_matthew@live.com>
Co-authored-by: Juliette Regimbal <juliette.regimbal@gmail.com>
Co-authored-by: Hafiz <muhamm3dhafiz@gmail.com>
Co-authored-by: Amir Hoseinian <amir.anyware@gmail.com>
Co-authored-by: load28 <tjalsdud89@naver.com>
Co-authored-by: Gabriela Araujo Britto <gab@cin.ufpe.br>
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Co-authored-by: Tom Kent <Tom-Dynamsoft@users.noreply.github.com>
Co-authored-by: Xiao Ling <lingxiao1002@gmail.com>
Co-authored-by: Konstantin Azizov <konstantin.azizov@theagilehub.net>
Co-authored-by: Colby M. White <colbywhite@users.noreply.github.com>
Co-authored-by: Nikita Galkin <nikita@galk.in>
Co-authored-by: TypeScript Bot <types@microsoft.com>
Co-authored-by: Ata Berk Yılmaz <ataberkylmz@gmail.com>
Co-authored-by: Rick-Kirkham <Rick-Kirkham@users.noreply.github.com>
Co-authored-by: xinxinran0221010 <xinxinran0221010@hotmail.com>
Co-authored-by: Nader Al-Shamma <10171089+nadershamma@users.noreply.github.com>
Co-authored-by: Nader Al-Shamma <naderal.shamma@mitrefinch.co.uk>
Co-authored-by: WhizSid <whizsid@aol.com>
Co-authored-by: Gerhard Stöbich <18708370+Flarna@users.noreply.github.com>
Co-authored-by: André Vitor de Lima Matos <andre.vmatos@gmail.com>
Co-authored-by: Jan Vennemann <jan.vennemann@gmx.net>
Co-authored-by: Alex Guerrero <guerrero@users.noreply.github.com>
Co-authored-by: Billy Newman <newmanw10@gmail.com>
Co-authored-by: Sean Kelley <seansfkelley@users.noreply.github.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Armando Aguirre <armando.aguirre@microsoft.com>
Co-authored-by: Ezequiel Surijon <surijon@gmail.com>
Co-authored-by: Ezequiel Surijon <esurijon@medallia.com>
Co-authored-by: Junxiao Shi <git@mail1.yoursunny.com>
Co-authored-by: Glenn Reyes <glenn@glennreyes.com>
Co-authored-by: Jon Phenow <jphenow@github.com>
Co-authored-by: Jerry Hu <4749863+jerry2013@users.noreply.github.com>
Co-authored-by: Pawel <fajfer.pawel@gmail.com>
Co-authored-by: Jeffrey Cherewaty <jeffrey@frontside.io>
Co-authored-by: Daniel Hirth <battlewizz@gmail.com>
Co-authored-by: Daniel Hirth <daniel.hirth@wolterskluwer.com>
Co-authored-by: Valentin Agachi <avaly@users.noreply.github.com>
Co-authored-by: Andrew van Rooyen <wraith.andrew@gmail.com>
Co-authored-by: Robert Cooper <robert.cooper.qu@gmail.com>
Co-authored-by: Emily Marigold Klassen <forivall@gmail.com>
Co-authored-by: andy cunningham <andycunn@gmail.com>
Co-authored-by: Pine <octref@gmail.com>
Co-authored-by: VSCode <vscode@microsoft.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: chivesrs <chivesrs@users.noreply.github.com>
Co-authored-by: ahagelstein <ahagelstein@users.noreply.github.com>
Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
Co-authored-by: MU AOHUA <muaohua@gmail.com>
Co-authored-by: aohua <aohua@percy.sg>
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Philip Frank <ich@philipfrank.de>
Co-authored-by: Cédric Taschereau <cedric.taschereau@gmail.com>
Co-authored-by: Cédric Taschereau <cedric.taschereau@boreal-is.com>
Co-authored-by: Neal Mummau <nmummau@users.noreply.github.com>
Co-authored-by: Romin Halltari <rominhalltari@yahoo.com>
Co-authored-by: Sudhi Ramamurthy <suramam@microsoft.com>
Co-authored-by: Sudhi <Murthy@sudhipro15.fios-router.home>
Co-authored-by: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com>
Co-authored-by: 943297456 <943297456@users.noreply.github.com>
Co-authored-by: Mustafa Salaheldin <mustafa.salaheldin@yahoo.com>
Co-authored-by: Nico Hernandez <nicoo.her@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants