Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused slot in the "Just the Basics" starter until slot bugs are fixed (fix #3473) #3475

Merged
merged 2 commits into from May 30, 2022

Conversation

florian-s-code
Copy link
Contributor

Simple fix of "Just the basics" starter for #3473
This seems to be a bug with named slots. Named slots that are not used will break the build.

Changes

Remove unused slot in the "Just the Basics" starter:

Testing

Tested

  • npm run dev
  • npm run build and npm run preview

Docs

No impact on the docs.

Simple fix for withastro#3473 as the slot was never used in this example.
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

⚠️ No Changeset found

Latest commit: 4638d4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label May 30, 2022
@sarah11918
Copy link
Member

Also confirming I was able to reproduce both the problem, and the fix, and I've alerted @bholmesdev and core to take a look at this. Thanks, @florian-s-code !

@@ -14,7 +14,6 @@ const {href, title, body} = Astro.props;
</h2>
<p>
{body}
<slot name="icon" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making a note here that the action being taken is the removal of the <slot name="icon">
this would unblock the build from hanging

Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florian-s-code Thank you dude for taking the engry to get this fix out for us this morning.
Great catch man 👊

@sarah11918
Copy link
Member

Merging this as a temporary emergency fix, since many of you are on holiday today.

Commonwealth in the code while the US takes the day off! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants