Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused slot in the "Just the Basics" starter until slot bugs are fixed (fix #3473) #3475

Merged
merged 2 commits into from
May 30, 2022
Merged

Remove unused slot in the "Just the Basics" starter until slot bugs are fixed (fix #3473) #3475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3122ba0
Remove unused slot until slot bugs are fixed
florian-s-code May 30, 2022
4638d4f
Merge branch 'main' into patch-1
sarah11918 May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/basics/src/components/Card.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const {href, title, body} = Astro.props;
</h2>
<p>
{body}
<slot name="icon" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making a note here that the action being taken is the removal of the <slot name="icon">
this would unblock the build from hanging

</p>
</a>
</li>
Expand Down Expand Up @@ -72,4 +71,4 @@ const {href, title, body} = Astro.props;
.link-card:is(:hover, :focus-within) h2 span {
transform: translateX(2px);
}
</style>
</style>