Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(E2BIG): Ignore potentially large vscode keys #7419

Merged
merged 1 commit into from Jul 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa

## Master

- Ignores potentially large vscode keys in package.json to avoid E2BIG errors.

[#7419](https://github.com/yarnpkg/yarn/pull/7419) - [**Eric Amodio**](https://twitter.com/eamodio)

- Enforces https for the Yarn and npm registries.

[#7393](https://github.com/yarnpkg/yarn/pull/7393) - [**Maël Nison**](https://twitter.com/arcanis)
Expand Down
8 changes: 7 additions & 1 deletion src/util/execute-lifecycle-script.js
Expand Up @@ -18,7 +18,13 @@ export type LifecycleReturn = Promise<{
stdout: string,
}>;

export const IGNORE_MANIFEST_KEYS: Set<string> = new Set(['readme', 'notice', 'licenseText']);
export const IGNORE_MANIFEST_KEYS: Set<string> = new Set([
'readme',
'notice',
'licenseText',
'activationEvents',
'contributes',
]);

// We treat these configs as internal, thus not expose them to process.env.
// This helps us avoid some gyp issues when building native modules.
Expand Down