Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#980. Update ruby version to 2.6.0 #981

Merged
merged 1 commit into from
May 30, 2019
Merged

#980. Update ruby version to 2.6.0 #981

merged 1 commit into from
May 30, 2019

Conversation

zCRUSADERz
Copy link
Contributor

For #980

  • Updated ruby version to 2.6.0

@0crat
Copy link
Collaborator

0crat commented May 23, 2019

@zCRUSADERz this pull request is too small, just 4 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

@zCRUSADERz
Copy link
Contributor Author

@paulodamaso ping, i need these changes for #982

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 30, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 18c485c into yegor256:master May 30, 2019
@rultor
Copy link
Collaborator

rultor commented May 30, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 23min)

@zCRUSADERz zCRUSADERz deleted the 980 branch May 30, 2019 15:57
@0crat
Copy link
Collaborator

0crat commented May 30, 2019

Job gh:yegor256/takes#981 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented May 30, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants