Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #968. Removing Guava's code. #982

Merged
merged 2 commits into from
Jun 1, 2019
Merged

For #968. Removing Guava's code. #982

merged 2 commits into from
Jun 1, 2019

Conversation

zCRUSADERz
Copy link
Contributor

For #968

  • Updated cactoos-matchers to 0.15
  • Replaced Guava's code on cactoos
  • Replaced static matchers on cactoos-matchers
  • Updated puzzle

@0crat 0crat added the scope label May 24, 2019
@0crat
Copy link
Collaborator

0crat commented May 24, 2019

Job #982 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 24, 2019

This pull request #982 is assigned to @Serranya/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

.travis.yml Outdated
@@ -11,8 +11,8 @@ script:
- est --dir=est --file=/dev/null
- mvn clean install -Pqulice -Pjacoco --errors --batch-mode
before_install:
- rvm install 2.2.2
- rvm use 2.2.2
- rvm install 2.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zCRUSADERz Why did you bump the version? This was not part of the task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya I needed a successful build in Travis CI. Probably I should wait until #981 PR is accepted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zCRUSADERz exactly. Please remove this part of the commit and wait for #981

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya deleted.

@Serranya
Copy link
Contributor

@zCRUSADERz There are test failures. Please take a look

@zCRUSADERz
Copy link
Contributor Author

@Serranya on my machine, all tests passed, and AppVeyor build succeeded. Travis CI failed, because pdd gem requires ruby >= 2.3.0. See #980, #981

@zCRUSADERz
Copy link
Contributor Author

@Serranya all checks have passed.

@Serranya
Copy link
Contributor

@paulodamaso looking good

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 1, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f617307 into yegor256:master Jun 1, 2019
@rultor
Copy link
Collaborator

rultor commented Jun 1, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 23min)

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

Code review was too long (8 days), architects (@paulodamaso) were penalized, see §55

@0crat 0crat removed the scope label Jun 1, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

@sereshqua/z please review this job completed by @Serranya/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

The job #982 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@sereshqua
Copy link

@Serranya please make sure that next time you will try to find at least 3 issues (if possible) during the CR

@zCRUSADERz zCRUSADERz deleted the 968 branch June 2, 2019 02:09
@sereshqua
Copy link

@Serranya ping

@sereshqua
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Jun 5, 2019

Order was finished, quality is "acceptable": +15 point(s) just awarded to @Serranya/z

@0crat
Copy link
Collaborator

0crat commented Jun 5, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants