-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #968. Removing Guava's code. #982
Conversation
Job #982 is now in scope, role is |
This pull request #982 is assigned to @Serranya/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
.travis.yml
Outdated
@@ -11,8 +11,8 @@ script: | |||
- est --dir=est --file=/dev/null | |||
- mvn clean install -Pqulice -Pjacoco --errors --batch-mode | |||
before_install: | |||
- rvm install 2.2.2 | |||
- rvm use 2.2.2 | |||
- rvm install 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zCRUSADERz Why did you bump the version? This was not part of the task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zCRUSADERz exactly. Please remove this part of the commit and wait for #981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Serranya deleted.
@zCRUSADERz There are test failures. Please take a look |
@Serranya all checks have passed. |
@paulodamaso looking good |
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 23min) |
Code review was too long (8 days), architects (@paulodamaso) were penalized, see §55 |
@sereshqua/z please review this job completed by @Serranya/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
The job #982 is now out of scope |
Payment to |
@Serranya please make sure that next time you will try to find at least 3 issues (if possible) during the CR |
@Serranya ping |
@0crat quality acceptable |
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
For #968