Refactor and simplify Callback
#2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event's passive state will be determined by sane defaults set by Yew
siku2
reviewed
Dec 26, 2021
|
Visit the preview URL for this PR (updated for commit c857231): https://yew-rs--pr2301-cleanback-isk7t7rz.web.app (expires Tue, 04 Jan 2022 19:20:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
voidpumpkin
approved these changes
Dec 26, 2021
This reverts commit 33e7770
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
voidpumpkin
requested changes
Dec 28, 2021
Co-authored-by: Julius Lungys <32368314+voidpumpkin@users.noreply.github.com>
voidpumpkin
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Callback::onceCallback::reformpassivefrom CallbackFixes #2269
Checklist
cargo make pr-flow