Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and simplify Callback #2301

Merged
merged 9 commits into from Dec 28, 2021
Merged

Refactor and simplify Callback #2301

merged 9 commits into from Dec 28, 2021

Commits on Dec 26, 2021

  1. yeet Callback::once

    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    a956068 View commit details
    Browse the repository at this point in the history

  2. yeet Callback::reform

    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    33e7770 View commit details
    Browse the repository at this point in the history

  3. remove passive overrides 

    Event's passive state will be determined by sane defaults set by Yew
    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    7c204c9 View commit details
    Browse the repository at this point in the history

  4. clippy

    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    44699af View commit details
    Browse the repository at this point in the history

  5. docs

    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    8205606 View commit details
    Browse the repository at this point in the history

  6. make CI happy

    @hamza1311
    hamza1311 committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    cb9a912 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Revert "yeet Callback::reform" 

    This reverts commit 33e7770
    @hamza1311
    hamza1311 committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    7676d48 View commit details
    Browse the repository at this point in the history

  2. why? 

    I literally tick-marked reformat before commit. Does it not use rustfmt???
    @hamza1311
    hamza1311 committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    b7253a6 View commit details
    Browse the repository at this point in the history

  3. Update packages/yew/src/callback.rs 

    Co-authored-by: Julius Lungys <32368314+voidpumpkin@users.noreply.github.com>
    @hamza1311 @voidpumpkin
    hamza1311 and voidpumpkin committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    c857231 View commit details
    Browse the repository at this point in the history