Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo make benchmarks #2495

Merged
merged 1 commit into from Mar 7, 2022
Merged

Conversation

futursolo
Copy link
Member

Description

After #2330, benchmark related code does not compile and trips clippy.
I think @voidpumpkin mentioned that this piece of code didn't work as expected before #2330 anyways.
I feel it's easier to solve this by removing the old benchmark as now Yew has a different way to benchmark.

Checklist

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Visit the preview URL for this PR (updated for commit 47121fa):

https://yew-rs-api--pr2495-fix-wasm-bench-3caj2a1i.web.app

(expires Sun, 13 Mar 2022 06:53:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really have an opinion regarding this. I see we had some benches for diffing but idk if we ever looked at/used those.

@voidpumpkin voidpumpkin added the A-yew Area: The main yew crate label Mar 7, 2022
@hamza1311
Copy link
Member

I agree that we should pull it out. Benchmarks can be added in afterwards where needed

@hamza1311 hamza1311 merged commit f39afdc into yewstack:master Mar 7, 2022
@futursolo futursolo deleted the fix-wasm-bench branch March 20, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants