Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(classifier): use a map for survey task characteristics #6086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

Refactor survey task characteristics to use a Map, rather than types.frozen. This should make the code easier to read (and hopefully maintain.)

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifier/plugins/tasks/survey

Linked Issue and/or Talk Post

How to Review

I tested this in the storybook, but any survey task project should work, as long as it has characteristic filters.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

@coveralls
Copy link

coveralls commented May 11, 2024

Coverage Status

coverage: 79.282% (-0.04%) from 79.323%
when pulling 875b67d on eatyourgreens:refactor-survey-task-characteristics
into 9a7a630 on zooniverse:master.

Refactor survey task characteristics to use a Map, rather than `types.frozen`. This should make the code easier to read (and hopefully maintain.)
@eatyourgreens eatyourgreens force-pushed the refactor-survey-task-characteristics branch from c91191a to 875b67d Compare June 8, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants