Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Upgrade Electron version to 5.0.6 #781

Closed
wants to merge 3 commits into from
Closed

[WIP] Upgrade Electron version to 5.0.6 #781

wants to merge 3 commits into from

Commits on Jul 4, 2019

  1. deps: Upgrade Electron version to 5.0.6.

    @kanishk98
    kanishk98 committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    98795a0 View commit details
    Browse the repository at this point in the history

  2. webview: Enable webviewTag in webPreferences. 

    * Addresses breaking change where webviewTag must be set to true when
setting webPreferences for a BrowserWindow.
    @kanishk98
    kanishk98 committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    24861fd View commit details
    Browse the repository at this point in the history

  3. preload: Update reason for using dom listeners. 

    Even though Electron v5 supports numpad keys, we can't add another
accelerator to the same menu item.
    @kanishk98
    kanishk98 committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    c741ed4 View commit details
    Browse the repository at this point in the history