Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade Electron version to 5.0.6 #781

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/main/index.js
Expand Up @@ -77,7 +77,8 @@ function createMainWindow() {
webPreferences: {
plugins: true,
nodeIntegration: true,
partition: 'persist:webviewsession'
partition: 'persist:webviewsession',
webviewTag: true
},
show: false
});
Expand Down
3 changes: 2 additions & 1 deletion app/renderer/js/preload.js
Expand Up @@ -88,7 +88,8 @@ window.addEventListener('beforeunload', () => {

// electron's globalShortcut can cause unexpected results
// so adding the reload shortcut in the old-school way
// Zoom from numpad keys is not supported by electron, so adding it through listeners.
// electron does not support adding multiple accelerators for a menu item
// so adding numpad shortcuts here
document.addEventListener('keydown', event => {
if (event.code === 'F5') {
ipcRenderer.send('forward-message', 'hard-reload');
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -127,7 +127,7 @@
"assert": "1.4.1",
"cp-file": "5.0.0",
"devtron": "1.4.0",
"electron": "3.1.10",
"electron": "5.0.6",
"electron-builder": "20.40.2",
"electron-connect": "0.6.2",
"electron-debug": "1.4.0",
Expand Down