Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 3.8 and use new features #602

Merged
merged 22 commits into from Mar 22, 2020
Merged

Upgrade to TypeScript 3.8 and use new features #602

merged 22 commits into from Mar 22, 2020

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Jan 24, 2020

Blocked by:

TODOs:

  • Upgrade Prettier to an official version (v2.0 / v1.20 ?)
  • Upgrade babel to an official version (v7.9)
  • Check if @babel/core@7.9.x breaks Node 8 support

@AlCalzone AlCalzone added enhancement New feature or request infrastructure Issues related to infrastructure and development labels Jan 24, 2020
@AlCalzone AlCalzone self-assigned this Jan 24, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 347 alerts and fixes 1 when merging da6f6ce into 8cc48b1 - view on LGTM.com

new alerts:

  • 347 for Syntax error

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 333 alerts and fixes 1 when merging 7a90e26 into 8cc48b1 - view on LGTM.com

new alerts:

  • 333 for Syntax error

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 329 alerts and fixes 1 when merging 4b2750d into 8cc48b1 - view on LGTM.com

new alerts:

  • 329 for Syntax error

fixed alerts:

  • 1 for Useless assignment to local variable

@lukescott
Copy link

lukescott commented Feb 18, 2020

@AlCalzone have you considered using tsc instead of babel?

At work I've found that using babel wasn't helpful when locked into TypeScript features. The only place I still use babel is compiling for the web as the env preset is super helpful for targeting browser versions.

The ts-jest package lets you run tests using tsc instead of going thru babel.

@AlCalzone
Copy link
Member Author

I've been using ts-jest earlier but always ran into problems where tests would use some cache I couldn't get rid of. Not very helpful if the test runner is unreliable or shows false-positives...

Not sure if that has changed but I haven't had any similar problems since I made the switch to babel+jest.

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2020

This pull request introduces 335 alerts and fixes 5 when merging 7271670 into b67539a - view on LGTM.com

new alerts:

  • 335 for Syntax error

fixed alerts:

  • 5 for Missing await

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 337 alerts and fixes 5 when merging 7839c7a into 6ff8d37 - view on LGTM.com

new alerts:

  • 337 for Syntax error

fixed alerts:

  • 5 for Missing await

@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2020

This pull request introduces 349 alerts and fixes 5 when merging 3cda87c into df85c58 - view on LGTM.com

new alerts:

  • 349 for Syntax error

fixed alerts:

  • 5 for Missing await

@lgtm-com
Copy link

lgtm-com bot commented Mar 7, 2020

This pull request introduces 351 alerts and fixes 5 when merging 73626e0 into a73c7da - view on LGTM.com

new alerts:

  • 351 for Syntax error

fixed alerts:

  • 5 for Missing await

@AlCalzone AlCalzone marked this pull request as ready for review March 22, 2020 16:52
@AlCalzone AlCalzone merged commit 8cdb70c into master Mar 22, 2020
@AlCalzone AlCalzone deleted the ts-3.8 branch March 22, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Issues related to infrastructure and development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants