External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808

moarychan · 2022-10-28T07:24:50Z

Upgrade the dependencies to align with Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1.

Changes:

Disable the fail of azure-core on deprecated API usage(com.azure.core.implementation.logging.DefaultLogger).
Update the sync_external_dependencies.py to support more use cases.
Make the compatibility tests pipeline pass by default when executing unit tests out with deprecation APIs.
Upgrade deprecated APIs
- org.springframework.security.config.annotation.method.configuration.EnableGlobalMethodSecurity -> org.springframework.security.config.annotation.method.configuration.EnableMethodSecurity
- org.springframework.security.oauth2.server.resource.BearerTokenAuthenticationToken -> org.springframework.security.oauth2.server.resource.authentication.BearerTokenAuthenticationToken

azure-sdk · 2022-10-28T07:33:07Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure
azure-messaging-eventhubs
azure-core
azure-core-amqp
azure-core-management

…s out with deprecation APIs

…h deprecation APIs

…ing Security

saragluna · 2022-11-01T01:23:24Z

eng/versioning/external_dependencies.txt

+org.springframework.boot:spring-boot;3.0.0-RC1
+org.springframework.data:spring-data-commons;3.0.0-RC1
+org.springframework.data:spring-data-mongodb;4.0.0-RC1
+org.springframework.data:spring-data-redis;3.0.0-RC1
 org.springframework.experimental:spring-aot;0.11.4


Should we remove this now? Or leave it until we start working on the aot?

It should be removed until we start developing the new AOT support, the current native configuration module will use this dependency.

saragluna · 2022-11-01T01:25:42Z

...a/com/azure/spring/cloud/autoconfigure/aad/configuration/AadResourceServerConfiguration.java

@@ -103,7 +103,7 @@ public List<OAuth2TokenValidator<Jwt>> createDefaultValidator(AadAuthenticationP
     * Default security configuration of the resource server, user can write another configuration bean to override it.
     */
    @EnableWebSecurity
-    @EnableGlobalMethodSecurity(prePostEnabled = true)
+    @EnableMethodSecurity


Why making this change?

The annotation @EnableGlobalMethodSecurity is marked as a deprecated API since the RC1 version, see https://github.com/spring-projects/spring-security/blob/6.0.0-RC1/config/src/main/java/org/springframework/security/config/annotation/method/configuration/EnableGlobalMethodSecurity.java

saragluna · 2022-11-01T01:47:03Z

@moarychan, seems like some jobs in the core-ci and jdbc-ci failed, is this expected?

…emetry-sdk-logs and opentelemetry-sdk-extension-autoconfigure because they are not included in the opentelemetry-bom

moarychan · 2022-11-01T03:48:48Z

@moarychan, seems like some jobs in the core-ci and jdbc-ci failed, is this expected?

jdbc-ci pipelines passed.
code-ci pipelines failed with some UTs of the azure-core-metrics-opentelemetry, which seems not compatible with the new version of opentelemetry, https://dev.azure.com/azure-sdk/public/_build/results?buildId=1957323&view=logs&j=c51d6cb2-95cd-5b4d-48e3-5062b75e6984&t=b62ccbdd-d117-5716-c02f-c3937fbd094d

@saragluna could you help check whether we can ignore those failures?

saragluna · 2022-11-01T06:26:34Z

@moarychan seems like there are two modules are affected:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project azure-core-amqp: 
[ERROR] 
[ERROR] Please refer to /mnt/vss/_work/1/s/sdk/core/azure-core-amqp/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project azure-core-metrics-opentelemetry: 
[ERROR] 
[ERROR] Please refer to /mnt/vss/_work/1/s/sdk/core/azure-core-metrics-opentelemetry/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

Could you help check whether we can make the azure-core-amqp UT pass? Since we are not using the metrics module now, but we should take a look at what breaking change caused the error.

saragluna · 2022-11-01T06:27:36Z

@moarychan seems like there are two modules are affected:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project azure-core-amqp: 
[ERROR] 
[ERROR] Please refer to /mnt/vss/_work/1/s/sdk/core/azure-core-amqp/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on project azure-core-metrics-opentelemetry: 
[ERROR] 
[ERROR] Please refer to /mnt/vss/_work/1/s/sdk/core/azure-core-metrics-opentelemetry/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

Could you help check whether we can make the azure-core-amqp UT pass? Since we are not using the metrics module now, but we should take a look at what breaking change caused the error.

The amqp tests also failed in this PR, please help take a look #31730.

saragluna

Since the integration tests have passed, and the pipeline broken issues are tracked in #31885 and #31886. Approving this PR now.

Upgrade to Spring Boot RC1 version

5e07d2b

moarychan added this to the 2022-11 milestone Oct 28, 2022

moarychan self-assigned this Oct 28, 2022

moarychan added 2 commits October 31, 2022 10:16

Upgrade to Spring Cloud RC1 version

9ea3207

Make the compatibility tests pass by default when executing unit test…

f401422

…s out with deprecation APIs

moarychan changed the title ~~External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-M5~~ External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 Oct 31, 2022

moarychan added 5 commits October 31, 2022 11:22

Make the live tests pass by default when executing unit tests out wit…

55c91c0

…h deprecation APIs

Update version support and changelog

abe0a1e

Make the M5 vresion end of life, due to the new deprecated API in Spr…

cfefd92

…ing Security

Override the global variables to disable the deprecated fail switch

97d0ccf

Update the variables ref

0fd2dc3

moarychan mentioned this pull request Oct 31, 2022

Update Spring Cloud Azure support file #31801

Closed

Update the variables ref

d681ddf

moarychan requested review from AikoBB, maximrytych-ms, ostoliarova-msft, JianpingChen, ankitarorabit, minnieliu, a team, gingi, paterasMSFT, dpwatrous, anilba06, gkostal, LarryOsterman and mrm9084 as code owners October 31, 2022 08:13

AikoBB approved these changes Oct 31, 2022

View reviewed changes

saragluna reviewed Nov 1, 2022

View reviewed changes

moarychan mentioned this pull request Nov 1, 2022

Upgrade to Spring Boot RC1 and Spring Cloud RC1 Azure-Samples/azure-spring-boot-samples#540

Merged

moarychan added 3 commits November 1, 2022 10:28

Fix pipelines: update maysql artifact id; update dependencies opentel…

6dcb8e5

…emetry-sdk-logs and opentelemetry-sdk-extension-autoconfigure because they are not included in the opentelemetry-bom

Fix conflicts

05d0cf3

Sync mysql artifact name change

e87fe88

moarychan linked an issue Nov 2, 2022 that may be closed by this pull request

[FEATURE REQ] Release 6.0.0-beta.3 for Spring Boot 3.0 #31329

Closed

moarychan mentioned this pull request Nov 2, 2022

[BUG] The unit tests of azure-core-amqp failed when reactor-core upgrading to 3.4.24 or 3.5.0-RC1 #31885

Closed

3 tasks

saragluna approved these changes Nov 2, 2022

View reviewed changes

moarychan mentioned this pull request Nov 2, 2022

[BUG] The unit tests of azure-core-metrics-opentelemetry failed when opentelemetry upgradding to 1.19.0 #31886

Closed

3 tasks

moarychan merged commit 8d6d989 into Azure:feature/spring-boot-3 Nov 2, 2022

moarychan deleted the moary/update-spring-cloud-azure-sb3rc1-sc2022m5 branch November 7, 2022 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808

External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808

moarychan commented Oct 28, 2022 •

edited

azure-sdk commented Oct 28, 2022 •

edited

saragluna Nov 1, 2022

moarychan Nov 1, 2022

saragluna Nov 1, 2022

moarychan Nov 1, 2022

saragluna commented Nov 1, 2022

moarychan commented Nov 1, 2022

saragluna commented Nov 1, 2022

saragluna commented Nov 1, 2022

saragluna left a comment

External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808

External dependencies upgrade - Spring Boot 3.0.0-RC1 and Spring Cloud 2022.0.0-RC1 #31808

Conversation

moarychan commented Oct 28, 2022 • edited

azure-sdk commented Oct 28, 2022 • edited

saragluna Nov 1, 2022

Choose a reason for hiding this comment

moarychan Nov 1, 2022

Choose a reason for hiding this comment

saragluna Nov 1, 2022

Choose a reason for hiding this comment

moarychan Nov 1, 2022

Choose a reason for hiding this comment

saragluna commented Nov 1, 2022

moarychan commented Nov 1, 2022

saragluna commented Nov 1, 2022

saragluna commented Nov 1, 2022

saragluna left a comment

Choose a reason for hiding this comment

moarychan commented Oct 28, 2022 •

edited

azure-sdk commented Oct 28, 2022 •

edited