Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for @typescript-eslint/eslint-plugin #4327

Merged
merged 2 commits into from Jul 16, 2019

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 16, 2019

This change allows rush lint to work with @typescript-eslint/eslint-plugin@1.12.0. Without this change, rush lint fails with the following error:

Error: Cannot find module '@typescript-eslint/typescript-estree'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (D:\Git\typescript-eslint-test\node_modules\.registry.npmjs.org\@typescript-eslint\eslint-plugin\1.12.0_db854cf46887ef4aa7b9323cccc417a5\node_modules\@typescript-eslint\eslint-plugin\dist\rules\prefer-readonly.js:17:29)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)

@mikeharder mikeharder merged commit 7c7e810 into Azure:master Jul 16, 2019
@mikeharder mikeharder deleted the eslint-plugin-dependency-hook branch July 16, 2019 01:34
mikeharder added a commit to mikeharder/azure-sdk-for-js that referenced this pull request Jul 23, 2019
mikeharder added a commit that referenced this pull request Jul 23, 2019
#4390)

- @typescript-eslint/eslint-plugin@1.12.0 introduced an implicit dependency on @typescript-eslint/typescript-estree
- Fixed in @typescript-eslint/eslint-plugin@1.13.0
- typescript-eslint/typescript-eslint#705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants