Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate maxTimeMS of find and aggregate to getMore #2983

Open
Tracked by #75
chilagrow opened this issue Jul 5, 2023 · 0 comments · Fixed by #3940 · May be fixed by #3968 or #3975
Open
Tracked by #75

Propagate maxTimeMS of find and aggregate to getMore #2983

chilagrow opened this issue Jul 5, 2023 · 0 comments · Fixed by #3940 · May be fixed by #3968 or #3975
Assignees
Labels
area/cursors Issues about cursors area/oplog Issues about OpLog and capped collections code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@chilagrow
Copy link
Contributor

What should be done?

https://www.mongodb.com/docs/manual/reference/method/cursor.maxTimeMS/#mongodb-method-cursor.maxTimeMS

https://www.mongodb.com/docs/manual/reference/command/aggregate/#command-fields

When maxTimeMS is set on find and aggregate, any subsequent calls on cursor.Next() which triggers getMore uses the same maxTimeMS.

Where?

https://github.com/FerretDB/FerretDB/blob/main/internal/handlers/pg/msg_aggregate.go
https://github.com/FerretDB/FerretDB/blob/main/internal/handlers/pg/msg_find.go

Definition of Done

  • all handlers updated;
  • integration/compatibility tests added/updated;
  • spot refactorings done;
  • user documentation updated or an issue to create documentation created;
@chilagrow chilagrow added code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 5, 2023
@AlekSi AlekSi added the area/cursors Issues about cursors label Jul 10, 2023
@AlekSi AlekSi added the area/oplog Issues about OpLog and capped collections label Oct 5, 2023
@AlekSi AlekSi added this to the Next milestone Dec 18, 2023
@AlekSi AlekSi assigned noisersup and unassigned ferretdb-bot Dec 28, 2023
@AlekSi AlekSi modified the milestones: v1.18.0, Next Jan 8, 2024
@noisersup noisersup linked a pull request Jan 11, 2024 that will close this issue
9 tasks
@AlekSi AlekSi reopened this Jan 12, 2024
@AlekSi AlekSi modified the milestones: v1.19.0, Next Jan 29, 2024
@AlekSi AlekSi modified the milestones: v1.20.0, Next Feb 19, 2024
@AlekSi AlekSi removed this from the v1.21.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cursors Issues about cursors area/oplog Issues about OpLog and capped collections code/enhancement Some user-visible feature could work better not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
None yet
4 participants