Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add a schema for policy files #733

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(core): add a schema for policy files #733

wants to merge 2 commits into from

Conversation

boneskull
Copy link
Contributor

Continuation of #620.

This seems like a reasonable idea for schema versioning.

To test in VS Code, you can add this property to any policy file:

"$schema": "https://raw.githubusercontent.com/boneskull/LavaMoat/boneskull/policy-schema/packages/core/schema/lavamoat-policy.v0-0-1.schema.json"

This was referenced Oct 6, 2023
Merged
Merged
@boneskull
Copy link
Contributor Author

boneskull commented Oct 6, 2023 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @boneskull and the rest of your teammates on Graphite Graphite

@boneskull boneskull force-pushed the boneskull/new-policy-schema branch 2 times, most recently from f11e27f to 313063a Compare October 12, 2023 23:36
@boneskull boneskull mentioned this pull request Oct 20, 2023
Closed
@boneskull boneskull self-assigned this Oct 26, 2023
This was referenced Nov 7, 2023
Merged
Closed
@boneskull boneskull force-pushed the boneskull/new-policy-schema branch 6 times, most recently from 2fe1a70 to 91e86c7 Compare March 8, 2024 22:06
@boneskull boneskull force-pushed the boneskull/new-policy-schema branch 4 times, most recently from 2c268f3 to 185deb5 Compare March 18, 2024 21:37
@boneskull boneskull changed the base branch from main to boneskull/zap-aa-macos-perf-test March 19, 2024 19:40
This was referenced Mar 19, 2024
Open
Open
Open
Merged
Draft
Merged
@boneskull boneskull force-pushed the boneskull/zap-aa-macos-perf-test branch from 166c953 to 8fcab2f Compare March 19, 2024 20:29
Base automatically changed from boneskull/zap-aa-macos-perf-test to main March 20, 2024 10:51
@boneskull boneskull force-pushed the boneskull/new-policy-schema branch 4 times, most recently from 4b9ea76 to 73df997 Compare March 27, 2024 19:50
@boneskull boneskull force-pushed the boneskull/new-policy-schema branch from 73df997 to bec7503 Compare April 9, 2024 20:49
@boneskull
feat(core): add a schema for policy files
b6f6d5f
@boneskull
chore(core): add schema validation tests
91fd5dc 
I pulled in [ajv](https://npm.im/ajv) for this. I had tried to use [z-schema](https://npm.im/z-schema) but I couldn't get it working quickly (apparently you need to supply the metaschema??) so abandoned it.  If there's a more lightweight, _maintained_ solution, I'm happy to try it.
@boneskull boneskull force-pushed the boneskull/new-policy-schema branch from 6ff5549 to 91fd5dc Compare May 2, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur left review comments

@legobeat legobeat Awaiting requested review from legobeat legobeat will be requested when the pull request is marked ready for review legobeat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@boneskull boneskull

Labels
chore overhead, tests, dev env, etc. dependencies Pull requests that update a dependency file documentation Docs, examples, tutorials, and associated tooling enhancement New feature or request pkg:lavamoat-core Changes in package lavamoat-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boneskull @naugtur