Upgrade to Electron 21

[gre]

📝 Description

• Electron was upgraded from 15 to 21. (major) as well as "electron-builder"
  • that means we have a new bump of the nodejs version for native module too. So all native library impacted (coins, usb,..)
  • that means we have a new Chromium version. So the UI is impacted. Screenshots have changed due to this.
• Sentry was upgraded (minor)
• playwright was upgraded (minor)

❓ Context

• Impacted projects: LLD
• Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-4331
  • fixes Linux symlinked data dir broken after updating to 2.45.1 #1005

✅ Checklist

• Test coverage covered by playwright tests but non regression on native will be needed for all OSs
  • @gre to assess again Sentry still connects correctly
• Atomic delivery
• No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ledger-live-github-bot	✅ Ready (Inspect)	Visit Preview	Dec 1, 2022 at 4:18PM (UTC)
live-common-tools	✅ Ready (Inspect)	Visit Preview	Dec 1, 2022 at 4:18PM (UTC)
native-ui-storybook	✅ Ready (Inspect)	Visit Preview	Dec 1, 2022 at 4:18PM (UTC)
react-ui-storybook	✅ Ready (Inspect)	Visit Preview	Dec 1, 2022 at 4:18PM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: 2677226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
ledger-live-desktop	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Base: 45.64% // Head: 45.15% // Decreases project coverage by -0.48% ⚠️

Coverage data is based on head (2677226) compared to base (8ede95f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1463      +/-   ##
===========================================
- Coverage    45.64%   45.15%   -0.49%     
===========================================
  Files          699      685      -14     
  Lines        30254    29348     -906     
  Branches      8009     7863     -146     
===========================================
- Hits         13810    13253     -557     
- Misses       15260    16042     +782     
+ Partials      1184       53    -1131     

Flag	Coverage Δ
test	45.15% <ø> (-0.49%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libs/ledger-live-common/src/env.ts	72.22% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts	12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts	70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts	57.44% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts	16.53% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts	20.00% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts	33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts	29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts	8.00% <0.00%> (ø)
libs/ledger-live-common/src/apps/logic.ts	60.74% <0.00%> (ø)
... and 256 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

@gre

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

[gre]

/generate-screenshots

[github-actions]

@gre

Generating screenshots: workflow ended:

Jobs status:
✅ - generate-screenshots-mac-internal
✅ - generate-screenshots (ubuntu-latest)
❌ - generate-screenshots (windows-latest)

[gre]

/generate-screenshots

[github-actions]

@gre

Generating screenshots: workflow ended:

Jobs status:
✅ - generate-screenshots (ubuntu-latest)
✅ - generate-screenshots (windows-latest)
✅ - generate-screenshots-mac-internal

[valpinkman]

Looks good but a changeset is still missing, it would have been interesting to have infos of the fixes that had to be done to the webviews etc...

[chabroA]

Looks good but a changeset is still missing, it would have been interesting to have infos of the fixes that had to be done to the webviews etc...

Done a540680 for LLD (bumped to major according to @gre description)

Used this PR description as well as the webview related one for context.

Feel free to edit the changeset file with further details or more appropriate version as you see fit 👌

also @gre feel free to add another changeset for updates done in the 2 packages in ledgerjs

[gre]

@valpinkman we're going to do this changeset / impact assessment from each team. at the moment we're half complete through it.

[gre]

new PR #2049