-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mocha #712
Update Mocha #712
Conversation
330e38e
to
e44f752
Compare
I poked into this and made a little progress on this with regard to loading models, but after that it seems like the configuration is not loading properly. Still trying to investigate what is going on. https://github.com/Jagjeet/trustroots/tree/test-framework-deps |
@Jagjeet Nice, I like the approach you took with Here's a bit easier to compare view: |
@Jagjeet I was looking into this again — did you have a branch running with some changes? Can you open a work-in-progress PR from it? No worries if you don't have time to work on it, others can do it as well but would be ace to have a better starting point than my PR. :-) |
@simison Since we don't use mocha anymore, can this PR be closed? Instead we may remove gulp-mocha completely, i suppose. |
mocha is still used for the server tests. I did look into use jest on the server too, it's not so commonly used for server tests, but it mostly worked to that extent that I tried it. mongoose lib actually strongly suggests that you use mocha instead of jest. |
@nicksellen Thank you for clarifying! |
This pull request is marked as unloved because it has not had any activity for 180 days. It doesn't mean it's not important, so please remove the unloved label if you like it, or add a comment saying what it means to you :) However, if you just leave it like this, I'll close it in 14 days to help keep your pull requests tidy! Thanks! |
Work-in-progress.
Updates
gulp-mocha
to latest.Hitting issue with how Mongoose is structured currently.
Feel free to take over if you're looking for something to work on! ;-)