Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mocha #712

Closed
wants to merge 2 commits into from
Closed

Update Mocha #712

wants to merge 2 commits into from

Conversation

simison
Copy link
Contributor

@simison simison commented Oct 14, 2018

Work-in-progress.

Updates gulp-mocha to latest.

Hitting issue with how Mongoose is structured currently.

Feel free to take over if you're looking for something to work on! ;-)

@simison simison added the build label Oct 14, 2018
@simison simison added the tests label Oct 15, 2018
@simison simison changed the title Update/test framework deps Update Mocha Oct 19, 2018
@Jagjeet
Copy link
Contributor

Jagjeet commented Oct 27, 2018

I poked into this and made a little progress on this with regard to loading models, but after that it seems like the configuration is not loading properly. Still trying to investigate what is going on.

https://github.com/Jagjeet/trustroots/tree/test-framework-deps

@simison
Copy link
Contributor Author

simison commented Oct 27, 2018

@Jagjeet Nice, I like the approach you took with file. Feel free to open a work-in-progress PR!

Here's a bit easier to compare view:

master...Jagjeet:test-framework-deps

@simison
Copy link
Contributor Author

simison commented Dec 16, 2018

@Jagjeet I was looking into this again — did you have a branch running with some changes? Can you open a work-in-progress PR from it? No worries if you don't have time to work on it, others can do it as well but would be ace to have a better starting point than my PR. :-)

@Jagjeet
Copy link
Contributor

Jagjeet commented Dec 17, 2018

@simison - I went ahead and set #778 to in progress and added you as an assignee.

@nicksellen nicksellen mentioned this pull request Dec 13, 2019
5 tasks
@mrkvon
Copy link
Contributor

mrkvon commented Feb 8, 2020

@simison Since we don't use mocha anymore, can this PR be closed? Instead we may remove gulp-mocha completely, i suppose.

@nicksellen
Copy link
Contributor

mocha is still used for the server tests. I did look into use jest on the server too, it's not so commonly used for server tests, but it mostly worked to that extent that I tried it. mongoose lib actually strongly suggests that you use mocha instead of jest.

@mrkvon
Copy link
Contributor

mrkvon commented Feb 8, 2020

@nicksellen Thank you for clarifying!

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

This pull request is marked as unloved because it has not had any activity for 180 days.

It doesn't mean it's not important, so please remove the unloved label if you like it, or add a comment saying what it means to you :)

However, if you just leave it like this, I'll close it in 14 days to help keep your pull requests tidy!

Thanks!

@github-actions github-actions bot added the Stale label Feb 8, 2021
@github-actions github-actions bot closed this Feb 23, 2021
@chmac chmac deleted the update/test-framework-deps branch January 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants