Test framework deps

[Jagjeet]

Proposed Changes

• Update testing framework to the latest Mocha version

Testing Instructions

• Run the test suite and verify there are no errors.

Fixes #712

[Jagjeet]

As mentioned in #712, this is still failing due to what appears to be some configuration errors. I am still investigating.

[Jagjeet]

I was able to finally get the tests running, but Mocha hangs after they are complete. This issue is documented here, but I'm having issues debugging it.

mochajs/mocha#3044

There is an exit flag that can be used with Mocha to behave like v3, but even with that on, the hanging behavior still occurs.

Also currently, the database connection is not being terminated. In testing locally, even when I terminate the connection, mocha still hangs. The documentation suggests using the --recursive flag and an AfterAll hook, but I couldn't get it to work with gulp-mocha.

mochajs/mocha#2507

One option might be to use the Mocha API directly, but I haven't went down that road yet.

[simison]

Hmm. I wonder if eliminating all tests and adding them back set by set would reveal anything?

…

On Sun, 11 Nov 2018, 11:39 Jagjeet Khalsa ***@***.*** wrote: I was able to finally get the tests running, but Mocha hangs after they are complete. This issue is documented here, but I'm having issues debugging it. mochajs/mocha#3044 <mochajs/mocha#3044> There is an exit flag that can be used with Mocha to behave like v3, but even with that on, the hanging behavior still occurs. Also currently, the database connection is not being terminated. In testing locally, even when I terminate the connection, mocha still hangs. The documentation suggests using the --recursive flag and an AfterAll hook, but I couldn't get it to work with gulp-mocha. mochajs/mocha#2507 <mochajs/mocha#2507> One option might be to use the Mocha API directly, but I haven't went down that road yet. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#778 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFUgNurRMxFpvjl17v-Su1cwJqZ1i4Kks5ut_BKgaJpZM4X9oDS> .

[Jagjeet]

@simison - It looks like this PR is still open if you want to start it again. I went ahead and rebased and got it updated. We could pull it onto a branch on Trustroots as well and continue working on it from there.

I believe the hang issue is related to on('end') not getting called resulting in not disconnecting from the database, but didn't very far in figuring out a solution.

[Jagjeet]

One more thing, the mocha hangs seem to be a known issue after version 3. The links below maybe useful in debugging.

• mocha 4 doesn't exit unlike mocha 3 mochajs/mocha#3044
• https://gist.github.com/boneskull/7fe75b63d613fa940db7ec990a5f5843

[github-actions]

This pull request is marked as unloved because it has not had any activity for 180 days.

It doesn't mean it's not important, so please remove the unloved label if you like it, or add a comment saying what it means to you :)

However, if you just leave it like this, I'll close it in 14 days to help keep your pull requests tidy!

Thanks!