-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to Angular CLI 9.0.0-rc.3 #33955
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,10 +35,10 @@ | |
}, | ||
"// 1": "dependencies are used locally and by bazel", | ||
"dependencies": { | ||
"@angular-devkit/architect": "^0.900.0-rc.0", | ||
"@angular-devkit/build-optimizer": "^0.900.0-rc.0", | ||
"@angular-devkit/core": "^9.0.0-rc.0", | ||
"@angular-devkit/schematics": "^9.0.0-rc.0", | ||
"@angular-devkit/architect": "^0.900.0-rc.3", | ||
"@angular-devkit/build-optimizer": "^0.900.0-rc.3", | ||
"@angular-devkit/core": "^9.0.0-rc.3", | ||
"@angular-devkit/schematics": "^9.0.0-rc.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: it seems that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
"@angular/bazel": "file:./tools/npm/@angular_bazel", | ||
"@babel/core": "^7.6.4", | ||
"@bazel/jasmine": "0.40.0", | ||
|
@@ -128,7 +128,7 @@ | |
"// 2": "devDependencies are not used under Bazel. Many can be removed after test.sh is deleted.", | ||
"// 3": "when updating @bazel/bazel version you also need to update the RBE settings in .bazelrc (see https://github.com/angular/angular/pull/27935)", | ||
"devDependencies": { | ||
"@angular/cli": "^9.0.0-rc.0", | ||
"@angular/cli": "^9.0.0-rc.3", | ||
"@bazel/bazel": "1.1.0", | ||
"@bazel/buildifier": "^0.29.0", | ||
"@bazel/ibazel": "^0.10.3", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context:
This was temporarily changed from
461159
to506857
(pending a cli release) in 08a4f10.So, there seems to be 3.5KB regression (EDIT: Not true. 👇461159
-->464734
) from rc.1 to rc.3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to say actually. It's true that the commit you linked changed the value. But that wasn't the absolute value, it was a value within +-1% of the real value.
Which is to say, I could have put that value and it would have still passed the CI. To know if there's a regression or not we'd need to check the sizes of FW+CLI rc.2 and FW+CLI rc.3 for AIO.
It's unfortunate that we can't vary just one. Next time we do this sort of coordinated change we should instead leave one of the packages (either FW or CLI) in a intermediate compat mode (@clydin suggested this approach for the change in question, but we ended up not going with it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Moreover, this size is for building with the local packages (so neither rc.1 nor rc.3) 😁
So, my comment was invalid 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did both builds:
So yes, there was a change of 701 bytes. I don't know if it was CLI or the FW though.