Add progress banner to warn about videos being processed on background #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ES-Alexander it's in the bag (or in portuguese: t谩 na m茫o!)! |
rafaellehmkuhl
force-pushed
the
add-bg-progress-banner
branch
from
cd3ed0e
to
f5eb5d3
Compare
patrickelectric
approved these changes
Mar 8, 2024
rafaellehmkuhl
force-pushed
the
add-bg-progress-banner
branch
from
f5eb5d3
to
321ab04
Compare
|
Rebased over master without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with a 30聽min video. I tried to open the video download page really quickly, and it was there for 1 or 2 seconds. Of course, I also tried by just reversing the if 馃槄.
Screen.Recording.2024-03-06.at.16.14.53.mov
To be merged after #808