Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): buff fingertip razor bionic, take 2 #4623

Merged

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented May 10, 2024

Purpose of change

This grab the ideas yay/phoenix brought up in #4556 plus the required hardcode changes. Idea is adding more utility to a bionic described as install 4 cm each of high-tech razor blades into your fingers, which logically should be more on par with some claw mutations while being better for cutting.

Currently WIP because I also intend to update the bonus unarmed damage but that's C++ stuff, and currently out and about on wifi. Also part of intended functioning seems to need a hardcode touching up too, see testing below.

Describe the solution

C++ changes:

  1. In character_display.cpp, updated the per_hand value in character_display::display_empty_handed_base_damage from 4 to 9, to match the total damage being added per yay's intended implementation.
  2. In melee.cpp, updated Character::roll_cut_damage to give a per_hand bonus of 9, so that the total damage of fingertip razors with both hands available becomes 18, as per the initial PR.
  3. And also in melee.cpp, removed the bonus stabbing damage for fingertip razors from Character::roll_stab_damage, making it the bonus all one damage type instead of a weird mix of both.

JSON changes:

  1. Grabbed the changes that buff the finger razor fake item's tool qualities up to 15 butcher quality, 1 cutting quality, and 2 fine cutting quality. Also added a comment explaining where the bonus damage actually is.
  2. Added the description changes to the bionic and its item form, hinting at the tool usage it gains.

Describe alternatives you've considered

  1. Keeping the unarmed damage bonuses unchanged.
  2. Hacking in a pure JSON method of specifying bonus unarmed damage by having the razors grant an enchantment the grants a mutation that grants unarmed damage like claws do, and removing the hardcode stuff entirely.

Testing

  1. Checked affected JSON files for syntax and lint errors.
  2. Ported JSON changes to playthrough build and spawned in as a razor boy.
  3. Dumped my starting tools and confirmed I was still able to butcher and dissect corpses.
  4. Compiled and load-tested.

Problem: it recognizes I have access to cutting quality for the sake of butchering and even for crafting recipes that require cutting quality, but it won't let me salvage clothing items with them.

Additional context

Checklist

Co-Authored-By: Chorus System <3629845+yay855@users.noreply.github.com>
@github-actions github-actions bot added the data PRs related to datas. Won't crash game (probably) label May 10, 2024
Co-Authored-By: Chorus System <3629845+yay855@users.noreply.github.com>
@github-actions github-actions bot added the src PR changes related to source code. label May 10, 2024
@chaosvolt
Copy link
Member Author

So I'm looking at the code for salvaging and it seems to be dependent on the item having a use action. Fake items in this context it seems can't be accessed for their use actions it seems, so this might be harder than expected. Might be a deeper problem best tackled in a follow-up PR...

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaa hardcoded values aaaaaaa

@scarf005 scarf005 changed the title feat(balance): updates to fingertip razor bionic, take 2 feat(balance): buff fingertip razor bionic, take 2 May 12, 2024
@chaosvolt chaosvolt merged commit b68a042 into cataclysmbnteam:main May 13, 2024
18 checks passed
@chaosvolt chaosvolt deleted the fully-automatic-bionic-handholding branch May 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data PRs related to datas. Won't crash game (probably) src PR changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants