Update Kythe version used. #1408
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
Looks like this pulls in a dependency to rust now. More work needed. |
|
@ivan444 do you see how we can reduce the dependencies that we don't actually need in our context ? |
|
This is something for discussion with Kythe team. I'm going to open an issue with them. I know how to reduce the dependencies, but that would imply a surgery of their release. Pretty fragile. |
|
Opened kythe/kythe#5371 BTW. the workaround is not as complicated as I feared. Just fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henner Zeller h.zeller@acm.org