Variable shadowing rule (Rebase of #790) #2133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20240306-rebase-790
branch
from
6ffb916
to
0977914
Compare
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
+ Coverage 92.92% 92.94% +0.01%
==========================================
Files 359 360 +1
Lines 26673 26746 +73
==========================================
+ Hits 24787 24860 +73
Misses 1886 1886 ☔ View full report in Codecov by Sentry. |
fangism
approved these changes
Mar 7, 2024
| namespace verilog { | ||
| namespace analysis { | ||
|
|
||
| class InstanceShadowRule : public verible::SyntaxTreeLintRule { |
There was a problem hiding this comment.
Can you add a full description with a few examples to the class docstring?
| "bit out;\n", | ||
| "endfunction\n"}, | ||
| }; | ||
| RunLintTestCases<VerilogAnalyzer, InstanceShadowRule>( |
There was a problem hiding this comment.
What should happen with test cases that resemble K&R style declarations, like:
module foo(a, b);
input wire a; // not a shadow, but attaches a type to the `a` port
output reg b; // not a shadow
endmoduleCan you include a few cases like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #790 to compile with head.
Fixing #247