[Testing] Testing what is needed to switch from absl to std string_view. #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20240310-string-view-test
branch
from
f6a4df2
to
ae0e6aa
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
- Coverage 92.92% 92.77% -0.15%
==========================================
Files 359 359
Lines 26673 26716 +43
==========================================
Hits 24787 24787
- Misses 1886 1929 +43 ☔ View full report in Codecov by Sentry. |
This will only show up on Windows that has a different implementation of std::string_view::iterator, hence push to see in CI
hzeller
force-pushed
the
feature-20240310-string-view-test
branch
from
ae0e6aa
to
5492273
Compare
Often we construct a string_view with iterator and length. There is no such constructor for std::string_view that takes an start iterator and a length. It happens to work in Linux libc++ and absl, because the string_view iterator is just a const char* (and there is a constructor std::string_view(const char*, size_t). Replace all the places that make this assumption and replace with an existing constructor call. Also change other places with typename iterator == const char *.
hzeller
force-pushed
the
feature-20240310-string-view-test
branch
from
94bd394
to
16c6d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only show up on Windows that has a different implementation of std::string_view::iterator, hence push to see in CI