Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relval embedding workflows #44928

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

harrypuuter
Copy link
Contributor

@harrypuuter harrypuuter commented May 8, 2024

PR description:

This PR fixes the RelVal Workflow for TauEmbedding mentioned here #44896
In addition, RelVal Workflows for all Run 2 Eras are added.

PR validation:

Workflows were validated locally.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44928/40204

  • This PR adds an extra 64KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

A new Pull Request was created by @harrypuuter for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @srimanob, @cmsbuild, @sunilUIET, @miquork, @subirsarkar can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @missirol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented May 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2024

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb046e/39320/summary.html
COMMIT: ea45e51
CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44928/39320/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

ValueError: Undefined workflows: 136.9

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@harrypuuter
Copy link
Contributor Author

136.9 was replaced with four tests 136.90(1-4). The test 136.9 does not exist anymore. Where do I find the definition of the tests to be run?

@jfernan2
Copy link
Contributor

136.9 may used in several places, I am not sure if we can simply remove it, why don't you just add the extra wfs in addition to 136.9?
Perhaps @smuzaffar can answer your question

@smuzaffar
Copy link
Contributor

For INPUT test, currently bot tries to run all workflows defined in IB. This is bug on bot side and I will fix it next week

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb046e/39320/summary.html
COMMIT: ea45e51
CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44928/39320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor

@cms-sw/pdmv-l2 please sign as this fixes a long running failure in the IBs.

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 681de79 into cms-sw:master May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants