Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop duplicating hasXXoutput + XXoutput #6476

Merged
merged 22 commits into from
May 14, 2024

Conversation

OfekShilon
Copy link
Member

@OfekShilon OfekShilon commented May 12, 2024

When you need to check if XXoutput exists, check it directly.
+some TSification in CompilationResult

This follows @RubenRBS 's comment on #6471.

I know this is sensitive and still want to bash it a while longer - but if anyone thinks this is the wrong way to go, I'd appreciate early feedback.

…f `XXoutput` exists, check it directly.

+ some TSification in CompilationResult
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remember that these fields are part of the public api. Someone might be using them for their intended pourpose, and I think we would break them if we removed those flags

Not sure how to best proceed 🤔

@OfekShilon
Copy link
Member Author

OfekShilon commented May 13, 2024

We need to remember that these fields are part of the public api. Someone might be using them for their intended pourpose, and I think we would break them if we removed those flags

Not sure how to best proceed 🤔

@RubenRBS not sure what you mean by public api. Are you talking about /api/compiler/[compiler id]/compile? It doesn't document the response fields, and even the given example response includes just optOutput and no hasOptOutput. I don't think any contract would break by omitting these fields.

But I have no strong opinion either way. @mattgodbolt WDYT?

@partouf
Copy link
Contributor

partouf commented May 14, 2024

I think these fields are generally not used by external parties, so I don't mind breaking the API for this.

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: I'm in favour of this simplification; thank you!

@OfekShilon
Copy link
Member Author

Thanks @RubenRBS @partouf @mattgodbolt . I still want to install haskell and do some smoke-testing. After that I'll merge and hope the fallout is benign..

renovate bot and others added 18 commits May 14, 2024 18:57
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [nopt](https://togithub.com/npm/nopt) | [`^7.2.0` ->
`^7.2.1`](https://renovatebot.com/diffs/npm/nopt/7.2.0/7.2.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/nopt/7.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/nopt/7.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/nopt/7.2.0/7.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/nopt/7.2.0/7.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>npm/nopt (nopt)</summary>

###
[`v7.2.1`](https://togithub.com/npm/nopt/blob/HEAD/CHANGELOG.md#721-2024-05-04)

[Compare Source](https://togithub.com/npm/nopt/compare/v7.2.0...v7.2.1)

##### Bug Fixes

-
[`2fb2144`](https://togithub.com/npm/nopt/commit/2fb21444311086adb561de0eed68ccff155fd444)
[#&#8203;160](https://togithub.com/npm/nopt/pull/160) linting:
no-unused-vars ([@&#8203;lukekarrys](https://togithub.com/lukekarrys))

##### Chores

-
[`2bdcfcb`](https://togithub.com/npm/nopt/commit/2bdcfcbc11059556899d5bf448ac527ad294efdf)
[#&#8203;160](https://togithub.com/npm/nopt/pull/160) bump
[@&#8203;npmcli/template-oss](https://togithub.com/npmcli/template-oss)
to 4.22.0 ([@&#8203;lukekarrys](https://togithub.com/lukekarrys))
-
[`0aa1d01`](https://togithub.com/npm/nopt/commit/0aa1d01d99cacc5f1cc73071e1b476039b6ef2f5)
[#&#8203;160](https://togithub.com/npm/nopt/pull/160) postinstall for
dependabot template-oss PR
([@&#8203;lukekarrys](https://togithub.com/lukekarrys))
-
[`28cb4e1`](https://togithub.com/npm/nopt/commit/28cb4e19f4c80fcd440c64e81fde8ba872a9a976)
[#&#8203;159](https://togithub.com/npm/nopt/pull/159) bump
[@&#8203;npmcli/template-oss](https://togithub.com/npmcli/template-oss)
from 4.21.3 to 4.21.4
([@&#8203;dependabot](https://togithub.com/dependabot)\[bot])

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…plorer#6434)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-unused-imports](https://togithub.com/sweepline/eslint-plugin-unused-imports)
| [`^3.1.0` ->
`^3.2.0`](https://renovatebot.com/diffs/npm/eslint-plugin-unused-imports/3.1.0/3.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-unused-imports/3.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-unused-imports/3.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-unused-imports/3.1.0/3.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-unused-imports/3.1.0/3.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>sweepline/eslint-plugin-unused-imports
(eslint-plugin-unused-imports)</summary>

###
[`v3.2.0`](https://togithub.com/sweepline/eslint-plugin-unused-imports/compare/8872ac3f6724a442ed1fe948318812afece1d4a1...77e06961513a868aef7bb88477014c903fbe95bd)

[Compare
Source](https://togithub.com/sweepline/eslint-plugin-unused-imports/compare/8872ac3f6724a442ed1fe948318812afece1d4a1...77e06961513a868aef7bb88477014c903fbe95bd)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@vitest/coverage-v8](https://togithub.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme)
([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8))
| [`^1.5.2` ->
`^1.6.0`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/1.5.2/1.6.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@vitest%2fcoverage-v8/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vitest%2fcoverage-v8/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vitest%2fcoverage-v8/1.5.2/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vitest%2fcoverage-v8/1.5.2/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [vitest](https://togithub.com/vitest-dev/vitest)
([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest))
| [`^1.5.2` ->
`^1.6.0`](https://renovatebot.com/diffs/npm/vitest/1.5.2/1.6.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vitest/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vitest/1.5.2/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/1.5.2/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vitest-dev/vitest (@&#8203;vitest/coverage-v8)</summary>

###
[`v1.6.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.6.0)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0)

#####    🚀 Features

- Support standalone mode  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5565
[<samp>(bdce0)</samp>](https://togithub.com/vitest-dev/vitest/commit/bdce0a29)
- Custom "snapshotEnvironment" option  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5449
[<samp>(30f72)</samp>](https://togithub.com/vitest-dev/vitest/commit/30f728bc)
- **benchmark**: Support comparing benchmark result  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) and
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5398
[<samp>(f8d3d)</samp>](https://togithub.com/vitest-dev/vitest/commit/f8d3d22e)
- **browser**: Allow injecting scripts  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5656
[<samp>(21e58)</samp>](https://togithub.com/vitest-dev/vitest/commit/21e58bd8)
- **reporter**: Support `includeConsoleOutput` and `addFileAttribute` in
junit  -  by [@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[vitest-dev/vitest#5659
[<samp>(2f913)</samp>](https://togithub.com/vitest-dev/vitest/commit/2f913222)
- **ui**: Sort items by file name  -  by
[@&#8203;btea](https://togithub.com/btea) in
[vitest-dev/vitest#5652
[<samp>(1f726)</samp>](https://togithub.com/vitest-dev/vitest/commit/1f7268fa)

#####    🐞 Bug Fixes

- Keep order of arguments for .each in custom task collectors  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5640
[<samp>(7d57c)</samp>](https://togithub.com/vitest-dev/vitest/commit/7d57c116)
- Call `resolveId('vitest')` after `buildStart`  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[vitest-dev/vitest#5646
[<samp>(f5faf)</samp>](https://togithub.com/vitest-dev/vitest/commit/f5faf423)
- Hash the name of the file when caching  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5654
[<samp>(c9e68)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9e68ced)
- Don't panic on empty files in node_modules  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va)
[<samp>(40c29)</samp>](https://togithub.com/vitest-dev/vitest/commit/40c299fe)
- Use `toJSON` for error serialization  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[vitest-dev/vitest#5526
[<samp>(19a21)</samp>](https://togithub.com/vitest-dev/vitest/commit/19a21e49)
-   **coverage**:
- Exclude `*.test-d.*` by default  -  by
[@&#8203;MindfulPol](https://togithub.com/MindfulPol) in
[vitest-dev/vitest#5634
[<samp>(bfe8a)</samp>](https://togithub.com/vitest-dev/vitest/commit/bfe8ad9d)
- Apply `vite-node`'s wrapper only to executed files  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[vitest-dev/vitest#5642
[<samp>(c9883)</samp>](https://togithub.com/vitest-dev/vitest/commit/c9883f3e)
-   **vm**:
- Support network imports  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5610
[<samp>(103a6)</samp>](https://togithub.com/vitest-dev/vitest/commit/103a6002)

#####    🏎 Performance

- Improve performance of forks pool  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5592
[<samp>(d8304)</samp>](https://togithub.com/vitest-dev/vitest/commit/d8304bb4)
- Unnecessary rpc call when coverage is disabled  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) in
[vitest-dev/vitest#5658
[<samp>(c5712)</samp>](https://togithub.com/vitest-dev/vitest/commit/c571276a)

#####     [View changes on
GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.3...v1.6.0)

###
[`v1.5.3`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.5.3)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.5.2...v1.5.3)

#####    🐞 Bug Fixes

- Use package.json name for a workspace project if not provided  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[vitest-dev/vitest#5608
[<samp>(48fba)</samp>](https://togithub.com/vitest-dev/vitest/commit/48fba190)
- Backport jest iterable equality within object  -  by
[@&#8203;sukovanej](https://togithub.com/sukovanej) in
[vitest-dev/vitest#5621
[<samp>(30e5d)</samp>](https://togithub.com/vitest-dev/vitest/commit/30e5dc1b)
- **browser**: Support benchmark  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[vitest-dev/vitest#5622
[<samp>(becab)</samp>](https://togithub.com/vitest-dev/vitest/commit/becabb5e)
- **reporter**: Use default error formatter for JUnit  -  by
[@&#8203;hi-ogawa](https://togithub.com/hi-ogawa) in
[vitest-dev/vitest#5629
[<samp>(20060)</samp>](https://togithub.com/vitest-dev/vitest/commit/200609cc)

#####     [View changes on
GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.5.2...v1.5.3)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sass](https://togithub.com/sass/dart-sass) | [`^1.75.0` ->
`^1.77.1`](https://renovatebot.com/diffs/npm/sass/1.75.0/1.77.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/sass/1.77.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/sass/1.77.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/sass/1.75.0/1.77.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/sass/1.75.0/1.77.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>sass/dart-sass (sass)</summary>

###
[`v1.77.1`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1771)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.77.0...1.77.1)

-   Fix a crash that could come up with importers in certain contexts.

###
[`v1.77.0`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1770)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.76.0...1.77.0)

-   *Don't* throw errors for at-rules in keyframe blocks.

###
[`v1.76.0`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1760)

[Compare
Source](https://togithub.com/sass/dart-sass/compare/1.75.0...1.76.0)

-   Throw errors for misplaced statements in keyframe blocks.

- Mixins and functions whose names begin with `--` are now deprecated
for
forwards-compatibility with the in-progress CSS functions and mixins
spec.
    This deprecation is named `css-function-mixin`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-n](https://togithub.com/eslint-community/eslint-plugin-n)
| [`^17.3.1` ->
`^17.6.0`](https://renovatebot.com/diffs/npm/eslint-plugin-n/17.3.1/17.6.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-n/17.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-n/17.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-n/17.3.1/17.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-n/17.3.1/17.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>eslint-community/eslint-plugin-n (eslint-plugin-n)</summary>

###
[`v17.6.0`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#1760-2024-05-10)

[Compare
Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.5.1...v17.6.0)

##### 🌟 Features

- Add support for ignoring experemental features
([#&#8203;269](https://togithub.com/eslint-community/eslint-plugin-n/issues/269))
([c046376](https://togithub.com/eslint-community/eslint-plugin-n/commit/c046376fb52bef8104502ffab3c457412d1a1e27))

##### 📚 Documentation

- add maintainance info
([#&#8203;271](https://togithub.com/eslint-community/eslint-plugin-n/issues/271))
([b454488](https://togithub.com/eslint-community/eslint-plugin-n/commit/b454488bd63c046d101305c40d24bf44ae83971e)),
closes
[#&#8203;194](https://togithub.com/eslint-community/eslint-plugin-n/issues/194)

###
[`v17.5.1`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#1751-2024-05-07)

[Compare
Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.5.0...v17.5.1)

##### 🩹 Fixes

- Add supported version to Buffer constructor
([#&#8203;266](https://togithub.com/eslint-community/eslint-plugin-n/issues/266))
([030f51b](https://togithub.com/eslint-community/eslint-plugin-n/commit/030f51bacd21918ef6d5b2bba9ec77cd701c3eba))

###
[`v17.5.0`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#1750-2024-05-07)

[Compare
Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.4.0...v17.5.0)

##### 🌟 Features

- **import-target:** Add resolution error reason
([#&#8203;264](https://togithub.com/eslint-community/eslint-plugin-n/issues/264))
([982a723](https://togithub.com/eslint-community/eslint-plugin-n/commit/982a723dfb81dc141b093e27b41cd67f82ba8587))
- **node-builtins:** Add node globals
([#&#8203;261](https://togithub.com/eslint-community/eslint-plugin-n/issues/261))
([9466731](https://togithub.com/eslint-community/eslint-plugin-n/commit/946673149b51b84581f91890495c810a496e0022))

##### 🩹 Fixes

- remove invalid es-builtins
([#&#8203;258](https://togithub.com/eslint-community/eslint-plugin-n/issues/258))
([ecdf019](https://togithub.com/eslint-community/eslint-plugin-n/commit/ecdf019c54c5bd720c20d2ea21886559c15f3205))

##### 🧹 Chores

- update dependency markdownlint-cli to ^0.40.0
([#&#8203;263](https://togithub.com/eslint-community/eslint-plugin-n/issues/263))
([1e41e7c](https://togithub.com/eslint-community/eslint-plugin-n/commit/1e41e7cf5328df05d07aeab8bc9c5d0f27d33695))

###
[`v17.4.0`](https://togithub.com/eslint-community/eslint-plugin-n/blob/HEAD/CHANGELOG.md#1740-2024-04-30)

[Compare
Source](https://togithub.com/eslint-community/eslint-plugin-n/compare/v17.3.1...v17.4.0)

##### 🌟 Features

- no-deprecated-api support removed api
([#&#8203;240](https://togithub.com/eslint-community/eslint-plugin-n/issues/240))
([36fd35d](https://togithub.com/eslint-community/eslint-plugin-n/commit/36fd35d9bbbaec43dd911e06bd83625cd1650fb3))

##### 🩹 Fixes

- unsupported-features/node-builtins-modules version comparation
([#&#8203;257](https://togithub.com/eslint-community/eslint-plugin-n/issues/257))
([5c67787](https://togithub.com/eslint-community/eslint-plugin-n/commit/5c67787cb191ff7409fa17ec5b12cfdc3a7a26d3))

##### 🧹 Chores

- Update release manifest (17.3.1)
([#&#8203;255](https://togithub.com/eslint-community/eslint-plugin-n/issues/255))
([cf576cb](https://togithub.com/eslint-community/eslint-plugin-n/commit/cf576cb45bd1f13b675b1612e79f571acfb780af))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@sentry/browser](https://togithub.com/getsentry/sentry-javascript/tree/master/packages/browser)
([source](https://togithub.com/getsentry/sentry-javascript)) |
[`^7.112.2` ->
`^7.114.0`](https://renovatebot.com/diffs/npm/@sentry%2fbrowser/7.112.2/7.114.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@sentry%2fbrowser/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@sentry%2fbrowser/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@sentry%2fbrowser/7.112.2/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@sentry%2fbrowser/7.112.2/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@sentry/node](https://togithub.com/getsentry/sentry-javascript/tree/master/packages/node)
([source](https://togithub.com/getsentry/sentry-javascript)) |
[`^7.112.2` ->
`^7.114.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/7.112.2/7.114.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@sentry%2fnode/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@sentry%2fnode/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@sentry%2fnode/7.112.2/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@sentry%2fnode/7.112.2/7.114.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/browser)</summary>

###
[`v7.114.0`](https://togithub.com/getsentry/sentry-javascript/releases/tag/7.114.0)

[Compare
Source](https://togithub.com/getsentry/sentry-javascript/compare/7.113.0...7.114.0)

##### Important Changes

- **fix(browser/v7): Continuously record CLS
([#&#8203;11935](https://togithub.com/getsentry/sentry-javascript/issues/11935))**

This release fixes a bug that caused the cumulative layout shift (CLS)
web vital not to be reported in a majority of the
cases where it should have been reported. With this change, the CLS web
vital should now always be reported for
pageloads with layout shift. If a pageload did not have layout shift, no
CLS web vital should be reported.

**Please note that upgrading the SDK to this version may cause data in
your dashboards to drastically change.**

##### Other Changes

- build(aws-lambda/v7): Turn off lambda layer publishing
([#&#8203;11875](https://togithub.com/getsentry/sentry-javascript/issues/11875))
- feat(v7): Add `tunnel` support to multiplexed transport
([#&#8203;11851](https://togithub.com/getsentry/sentry-javascript/issues/11851))
- fix(opentelemetry-node): support `HTTP_REQUEST_METHOD` attribute
([#&#8203;11929](https://togithub.com/getsentry/sentry-javascript/issues/11929))
- fix(react/v7): Fix react router v4/v5 span names
([#&#8203;11940](https://togithub.com/getsentry/sentry-javascript/issues/11940))

###
[`v7.113.0`](https://togithub.com/getsentry/sentry-javascript/releases/tag/7.113.0)

[Compare
Source](https://togithub.com/getsentry/sentry-javascript/compare/7.112.2...7.113.0)

##### Important Changes

- **feat(node): Support Node 22
([#&#8203;11754](https://togithub.com/getsentry/sentry-javascript/issues/11754))**

This release adds support for Node 22! 🎉

It also adds prebuilt-binaries for Node 22 to `@sentry/profiling-node`.

##### Other Changes

- feat(feedback): \[v7] New feedback button design
([#&#8203;11841](https://togithub.com/getsentry/sentry-javascript/issues/11841))
- feat(replay/v7): Upgrade rrweb packages to 2.15.0
([#&#8203;11752](https://togithub.com/getsentry/sentry-javascript/issues/11752))
- fix(ember/v7): Ensure unnecessary spans are avoided
([#&#8203;11848](https://togithub.com/getsentry/sentry-javascript/issues/11848))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The upstream has changed from `-fclangir-enable` to `-fclangir`. Update
here as well.
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@types/jquery](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jquery)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jquery))
| [`^3.5.29` ->
`^3.5.30`](https://renovatebot.com/diffs/npm/@types%2fjquery/3.5.29/3.5.30)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fjquery/3.5.30?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fjquery/3.5.30?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fjquery/3.5.29/3.5.30?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fjquery/3.5.29/3.5.30?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/webpack-env](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/webpack-env)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack-env))
| [`^1.18.4` ->
`^1.18.5`](https://renovatebot.com/diffs/npm/@types%2fwebpack-env/1.18.4/1.18.5)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fwebpack-env/1.18.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fwebpack-env/1.18.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fwebpack-env/1.18.4/1.18.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fwebpack-env/1.18.4/1.18.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [eslint-plugin-jsdoc](https://togithub.com/gajus/eslint-plugin-jsdoc)
| [`^48.2.3` ->
`^48.2.4`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/48.2.3/48.2.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-jsdoc/48.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-jsdoc/48.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-jsdoc/48.2.3/48.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-jsdoc/48.2.3/48.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>gajus/eslint-plugin-jsdoc (eslint-plugin-jsdoc)</summary>

###
[`v48.2.4`](https://togithub.com/gajus/eslint-plugin-jsdoc/compare/v48.2.3...4da4aebf35f49b607e32dcfb3142dba812e6d705)

[Compare
Source](https://togithub.com/gajus/eslint-plugin-jsdoc/compare/v48.2.3...v48.2.4)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin)
([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin))
| [`^7.7.1` ->
`^7.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/7.7.1/7.9.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2feslint-plugin/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2feslint-plugin/7.7.1/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/7.7.1/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@typescript-eslint/parser](https://typescript-eslint.io/packages/parser)
([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser))
| [`^7.7.1` ->
`^7.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/7.7.1/7.9.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2fparser/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2fparser/7.7.1/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/7.7.1/7.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v7.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#790-2024-05-13)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.8.0...v7.9.0)

##### 🩹 Fixes

- **eslint-plugin:** \[explicit-function-return-types] fix false
positive on default parameters

##### ❤️  Thank You

-   Kirk Waiblinger
-   Sheetal Nandi
-   Vinccool96

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

###
[`v7.8.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#780-2024-04-29)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.7.1...v7.8.0)

##### 🩹 Fixes

-   **eslint-plugin:** \[no-unsafe-argument] handle  tagged templates

- **eslint-plugin:** \[prefer-optional-chain] suggests optional chaining
during strict null equality check

- **eslint-plugin:** \[consistent-type-assertions] handle tagged
templates

-   **eslint-plugin:** \[no-unsafe-return] handle union types

-   **eslint-plugin:** \[no-unused-vars] clear error report range

##### ❤️  Thank You

-   auvred
-   Josh Goldberg ✨
-   jsfm01
-   Kim Sang Du
-   YeonJuan

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v7.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#790-2024-05-13)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.8.0...v7.9.0)

This was a version bump only for parser to align it with other projects,
there were no code changes.

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

###
[`v7.8.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#780-2024-04-29)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.7.1...v7.8.0)

This was a version bump only for parser to align it with other projects,
there were no code changes.

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR fixes compiler-explorer#6212 and infra PR is here:
compiler-explorer/infra#1299

It adds the nix crate that will be useful when users need to access more
user friendly *nix APIs.
Thanks!
Seems like a decent thing to do. cypress should already be using node 20
though
widberg and others added 2 commits May 14, 2024 18:57
…r#6396)

<!-- THIS COMMENT IS INVISIBLE IN THE FINAL PR, BUT FEEL FREE TO REMOVE
IT
Thanks for taking the time to improve CE. We really appreciate it.
Before opening the PR, please make sure that the tests & linter pass
their checks,
  by running `make check`.
In the best case scenario, you are also adding tests to back up your
changes,
  but don't sweat it if you don't. We can discuss them at a later date.
Feel free to append your name to the CONTRIBUTORS.md file
Thanks again, we really appreciate this!
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants