Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to 1.21 #1331

Merged
merged 3 commits into from Dec 19, 2023
Merged

Conversation

pravinpushkar
Copy link
Contributor

No description provided.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar requested review from a team as code owners August 10, 2023 09:53
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (668bab4) 22.76% compared to head (ec0d437) 22.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   22.76%   22.76%           
=======================================
  Files          40       40           
  Lines        4713     4713           
=======================================
  Hits         1073     1073           
  Misses       3562     3562           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukundansundar mukundansundar added this to the v1.13 milestone Aug 17, 2023
mukundansundar
mukundansundar previously approved these changes Aug 17, 2023
@shubham1172
Copy link
Member

@pravinpushkar could you please resolve the conflicts?

@pravinpushkar
Copy link
Contributor Author

@pravinpushkar could you please resolve the conflicts?

yes, I will work on this.

Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the linter version for Go 1.21 support.

In Contrib we are now using v1.55.2. I suggest switching to that version.

https://github.com/dapr/cli/blob/master/.github/workflows/dapr_cli.yaml#L32

You may need to change the golangci-lint configuration and fix some new linter errors. See my PR: dapr/components-contrib#3251

@pravinpushkar
Copy link
Contributor Author

You also need to update the linter version for Go 1.21 support.

In Contrib we are now using v1.55.2. I suggest switching to that version.

https://github.com/dapr/cli/blob/master/.github/workflows/dapr_cli.yaml#L32

You may need to change the golangci-lint configuration and fix some new linter errors. See my PR: dapr/components-contrib#3251

Thanks for the suggestion. Just wondering, should not lint fail in this PR, all checks seems to be paasing.
I will take a look at the PR.

@mukundansundar mukundansundar merged commit c7e8612 into dapr:master Dec 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants