-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement service lock optimisations and race condition fix #7428
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fdf4f1c
Calculates vnode hashes outside of lock
elena-kolevska 3855a57
Checks version again after reacquiring lock
elena-kolevska 3e073eb
Removes unneeded check.
elena-kolevska 729710e
Reduce the time we’re holding the lock on the Consistent hash
elena-kolevska 2c9265d
Fixes possible race condition
elena-kolevska 19c3e77
Prevents possible race condition
elena-kolevska 40c73a8
Another possible race condition
elena-kolevska 98317de
Removes leftover context metadata
elena-kolevska 41ab644
Small refactor
elena-kolevska f3c3c9a
Removes comment cause it’s not needed anymore, after bringing the loc…
elena-kolevska a84b2f5
Merge branch 'master' into macos-actors-tests
elena-kolevska f658f98
Revert
elena-kolevska 3eab372
Merge branch 'macos-actors-tests' of github.com:elena-kolevska/dapr i…
elena-kolevska 03c2181
Merge branch 'master' into macos-actors-tests
artursouza File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a leftover cleanup from #7415