New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FilePath #7235
Remove FilePath #7235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7235 +/- ##
============================================
+ Coverage 84.71% 84.77% +0.05%
Complexity 3993 3993
============================================
Files 578 578
Lines 12163 12138 -25
Branches 2494 2484 -10
============================================
- Hits 10304 10290 -14
+ Misses 626 624 -2
+ Partials 1233 1224 -9 ☔ View full report in Codecov by Sentry. |
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Outdated
Show resolved
Hide resolved
@@ -52,7 +52,7 @@ class SarifOutputReportSpec { | |||
.render(result) | |||
|
|||
val expectedReport = readResourceContent("vanilla.sarif.json") | |||
.replace("<PREFIX>", Path("/").absolute().toUri().toString()) | |||
.replace("<PREFIX>", Path(System.getProperty("user.dir")).toUri().toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this change is needed for the issue that I was talking before.
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/test/kotlin/io/gitlab/arturbosch/detekt/api/CodeSmellSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
.../test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/FileBasedIssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
detekt-formatting/src/test/kotlin/io/gitlab/arturbosch/detekt/formatting/FormattingRuleSpec.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Location.kt
Outdated
Show resolved
Hide resolved
LGTM. It's strange the usages of user.dir on tests but that's clearly not important and you have a lot of PRs waiting for this. |
They weren't really needed, I've stripped them out. Thanks for your time on this! |
No description provided.