Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NoStackTraceThrowable with NoStackTraceException #4854 #4855

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace NoStackTraceThrowable with NoStackTraceException #4854 #4855

wants to merge 5 commits into from

Conversation

magicprinc
Copy link
Contributor

See #4854

This was referenced Sep 12, 2023
Open
Open
@magicprinc
Copy link
Contributor Author

magicprinc commented Sep 12, 2023 •
edited

NoStackTraceThrowable is marked as @Deprecated with javadoc @deprecated Use {@link NoStackTraceException} instead., but not deleted.
It allows fixing other vert.x modules (if any exists) eventually without breaking or fixing all at once.

If you want to delete NoStackTraceThrowable immediately, you can accept this PR, make a following and fix all other modules yourself 👍

@magicprinc
core review
f753387
@magicprinc
better (temporarily) solution: VertxException → NoStackTraceThrowable…
6b8242c 
… → NoStackTraceException

If some code catches NoStackTraceThrowable, it won't break, but shows deprecated waring.
After all code migrates to NoStackTraceException we can remove NoStackTraceThrowable:
VertxException → NoStackTraceException
I think nobody will miss changing parent of NoStackTraceThrowable from Throwable to RuntimeException
@magicprinc
code review: deprecate ctors, not class itself
c09f004
@magicprinc
fix deprecation warning for NoStackTraceException
6d156bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj vietj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magicprinc @vietj