Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NoStackTraceThrowable with NoStackTraceException #4854 #4855

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace NoStackTraceThrowable with NoStackTraceException #4854 #4855

wants to merge 5 commits into from

Commits on Sep 12, 2023

  1. Replace NoStackTraceThrowable with NoStackTraceException eclipse-vert… 

    …x#4854
    @magicprinc
    magicprinc committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3a03dd5 View commit details
    Browse the repository at this point in the history

  2. core review

    @magicprinc
    magicprinc committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f753387 View commit details
    Browse the repository at this point in the history

  3. better (temporarily) solution: VertxException → NoStackTraceThrowable… 

    … → NoStackTraceException

If some code catches NoStackTraceThrowable, it won't break, but shows deprecated waring.
After all code migrates to NoStackTraceException we can remove NoStackTraceThrowable:
VertxException → NoStackTraceException
I think nobody will miss changing parent of NoStackTraceThrowable from Throwable to RuntimeException
    @magicprinc
    magicprinc committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6b8242c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. code review: deprecate ctors, not class itself

    @magicprinc
    magicprinc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c09f004 View commit details
    Browse the repository at this point in the history

  2. fix deprecation warning for NoStackTraceException

    @magicprinc
    magicprinc committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6d156bb View commit details
    Browse the repository at this point in the history