Replace NoStackTraceThrowable with NoStackTraceException #4854

src/main/java/io/vertx/core/Promise.java

@@ -13,7 +13,7 @@
 import io.vertx.codegen.annotations.CacheReturn;
 import io.vertx.codegen.annotations.GenIgnore;
 import io.vertx.codegen.annotations.VertxGen;
-import io.vertx.core.impl.NoStackTraceThrowable;
+import io.vertx.core.impl.NoStackTraceException;
 import io.vertx.core.impl.future.PromiseImpl;
 
 /**
@@ -137,7 +137,7 @@ default boolean tryComplete() {
    * @return false when the future is already completed
    */
   default boolean tryFail(String message) {
-    return tryFail(new NoStackTraceThrowable(message));
+    return tryFail(new NoStackTraceException(message));
   }
 
   /**

src/main/java/io/vertx/core/dns/DnsException.java

@@ -11,7 +11,7 @@
 
 package io.vertx.core.dns;
 
-import io.vertx.core.impl.NoStackTraceThrowable;
+import io.vertx.core.impl.NoStackTraceException;
 import java.util.Objects;
 
 /**
@@ -20,10 +20,10 @@
  *
  * @author <a href="mailto:nmaurer@redhat.com">Norman Maurer</a>
  */
-public final class DnsException extends NoStackTraceThrowable {
+public final class DnsException extends NoStackTraceException {
 
   private static final String ERROR_MESSAGE_PREFIX = "DNS query error occurred: ";
-  private DnsResponseCode code;
+  private final DnsResponseCode code;
 
   public DnsException(DnsResponseCode code) {
     super(ERROR_MESSAGE_PREFIX + code);

src/main/java/io/vertx/core/impl/NoStackTraceException.java

@@ -15,14 +15,40 @@
 
 /**
  * @author <a href="mailto:julien@julienviet.com">Julien Viet</a>
+ * @see VertxException
  */
-public class NoStackTraceException extends VertxException {
+@SuppressWarnings("deprecation")
+public class NoStackTraceException extends NoStackTraceThrowable {
 
-  public NoStackTraceException(String message) {
-    super(message, null, true);
+  public NoStackTraceException (String message, Throwable cause){
+    super(message, cause);
   }
 
-  public NoStackTraceException(Throwable cause) {
-    super(cause, true);
+  public NoStackTraceException (String message){
+    super(message);
   }
+
+  public NoStackTraceException (Throwable cause){
+    super(cause);
+  }
+
+  public NoStackTraceException (){
+  }
+
+// after removing NoStackTraceThrowable
+//  public NoStackTraceException (String message, Throwable cause) {
+//    super(message, cause, true);
+//  }
+//
+//  public NoStackTraceException(String message) {
+//    super(message, null, true);// disable cause too
+//  }
+//
+//  public NoStackTraceException(Throwable cause) {
+//    super(cause, true);
+//  }
+//
+//  public NoStackTraceException() {
+//    super((Throwable) null, true);// disable cause too
+//  }
 }

src/main/java/io/vertx/core/impl/NoStackTraceThrowable.java

@@ -11,12 +11,31 @@
 
 package io.vertx.core.impl;
 
+import io.vertx.core.VertxException;
+
 /**
+ * @deprecated Please use {@link NoStackTraceException} instead. NoStackTraceThrowable extends Throwable, which is generally considered a bad practice.
  * @author <a href="http://tfox.org">Tim Fox</a>
  */
-public class NoStackTraceThrowable extends Throwable {
+public class NoStackTraceThrowable extends VertxException {
+
+  @Deprecated
+  public NoStackTraceThrowable (String message, Throwable cause) {
+    super(message, cause, true);
+  }
 
+  @Deprecated
   public NoStackTraceThrowable(String message) {
-    super(message, null, false, false);
+    super(message, null, true);// disable cause too
+  }
+
+  @Deprecated
+  public NoStackTraceThrowable(Throwable cause) {
+    super(cause, true);
+  }
+
+  @Deprecated
+  public NoStackTraceThrowable() {
+    super((Throwable) null, true);// disable cause too
   }
 }

src/main/java/io/vertx/core/impl/future/FailedFuture.java

@@ -15,7 +15,7 @@
 import io.vertx.core.Future;
 import io.vertx.core.Handler;
 import io.vertx.core.impl.ContextInternal;
-import io.vertx.core.impl.NoStackTraceThrowable;
+import io.vertx.core.impl.NoStackTraceException;
 
 import java.util.function.Function;
 
@@ -42,7 +42,7 @@ public FailedFuture(Throwable t) {
    */
   public FailedFuture(ContextInternal context, Throwable t) {
     super(context);
-    this.cause = t != null ? t : new NoStackTraceThrowable(null);
+    this.cause = t != null ? t : new NoStackTraceException();
   }
 
   /**
@@ -58,7 +58,7 @@ public FailedFuture(String failureMessage) {
    * @param failureMessage the failure message
    */
   public FailedFuture(ContextInternal context, String failureMessage) {
-    this(context, new NoStackTraceThrowable(failureMessage));
+    this(context, new NoStackTraceException(failureMessage));
   }
 
   @Override

src/main/java/io/vertx/core/impl/future/FutureImpl.java

@@ -15,7 +15,7 @@
 import io.vertx.core.Future;
 import io.vertx.core.Handler;
 import io.vertx.core.impl.ContextInternal;
-import io.vertx.core.impl.NoStackTraceThrowable;
+import io.vertx.core.impl.NoStackTraceException;
 
 import java.util.ArrayList;
 import java.util.Objects;
@@ -36,7 +36,6 @@ class FutureImpl<T> extends FutureBase<T> {
    * Create a future that hasn't completed yet
    */
   FutureImpl() {
-    super();
   }
 
   /**
@@ -250,7 +249,7 @@ public boolean tryComplete(T result) {
 
   public boolean tryFail(Throwable cause) {
     if (cause == null) {
-      cause = new NoStackTraceThrowable(null);
+      cause = new NoStackTraceException();
     }
     Listener<T> l;
     synchronized (this) {

src/test/java/io/vertx/core/FutureTest.java

@@ -12,7 +12,7 @@
 package io.vertx.core;
 
 import io.vertx.core.impl.ContextInternal;
-import io.vertx.core.impl.NoStackTraceThrowable;
+import io.vertx.core.impl.NoStackTraceException;
 import io.vertx.core.impl.future.PromiseInternal;
 import io.vertx.test.core.Repeat;
 import org.junit.Test;
@@ -202,7 +202,7 @@ public void testFailFutureToHandler() {
   public void testCreateFailedWithNullFailure() {
     Future<String> future = Future.failedFuture((Throwable)null);
     Checker<String> checker = new Checker<>(future);
-    NoStackTraceThrowable failure = (NoStackTraceThrowable) checker.assertFailed();
+    NoStackTraceException failure = (NoStackTraceException) checker.assertFailed();
     assertNull(failure.getMessage());
   }
 
@@ -211,7 +211,7 @@ public void testFailureFutureWithNullFailure() {
     Promise<String> promise = Promise.promise();
     promise.fail((Throwable)null);
     Checker<String> checker = new Checker<>(promise.future());
-    NoStackTraceThrowable failure = (NoStackTraceThrowable) checker.assertFailed();
+    NoStackTraceException failure = (NoStackTraceException) checker.assertFailed();
     assertNull(failure.getMessage());
   }
 
@@ -1647,7 +1647,7 @@ private void testListenersReportFailureOnContextAfterCompletion(Function<Context
   @Test
   public void testAndThenComplete() {
     waitFor(4);
-    Throwable throwable = new NoStackTraceThrowable("test");
+    Throwable throwable = new NoStackTraceException("test");
 
     testAndThen(Future.succeededFuture(), null, null);
 
@@ -1668,7 +1668,7 @@ public void testAndThenComplete() {
   @Repeat(times = 50)
   public void testAndThenCompleteContextual() {
     waitFor(4);
-    Throwable throwable = new NoStackTraceThrowable("test");
+    Throwable throwable = new NoStackTraceException("test");
 
     ContextInternal context = (ContextInternal) vertx.getOrCreateContext();