fix: Use async save dialog for anchor download attribute #16612
Merged
+78
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, the synchronous save dialog does not work properly and breaks in weird ways when the dialog is expanded/collapsed (see #14606). This works around the problem for the dialog shown for `<a download=...>` by switching to the asynchronous API. To test this: main.js: ``` const { app, BrowserWindow, session } = require('electron') const path = require('path') function createWindow() { win = new BrowserWindow({ width: 600, height: 600, webPreferences: { nodeIntegration: false, }, }) session.defaultSession.on('will-download', (event, item) => { // Test with and without this commented out. //item.setSavePath(path.join(app.getPath('desktop'), 'test-download.txt')) }) win.loadURL(`file://${__dirname}/test.html`) } app.on('ready', createWindow) ``` test.html: ``` <html> <head> <meta http-equiv="Content-Security-Policy" content="default-src 'self'; style-src 'self' 'unsafe-inline'; script-src 'self' 'unsafe-inline'; img-src 'self' data:"> </head> <body> <a href="data:application/xml;charset=utf-8,foo" download="download.txt">Save</a> </body> ```
poiru
commented
Jan 30, 2019
|
|
||
| auto dialog_callback = | ||
| base::Bind(&AtomDownloadManagerDelegate::OnDownloadSaveDialogDone, | ||
| base::Unretained(this), download_id, callback); |
There was a problem hiding this comment.
I'm using base::Unretained(this) here, but I think it should be fine since AtomDownloadManagerDelegate should exist until shutdown. @zcbenz, is this safe?
There was a problem hiding this comment.
Yeah it should be fine in this case.
zcbenz
approved these changes
Jan 31, 2019
zcbenz
approved these changes
Jan 31, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "4-0-x" cleanly; |
|
I have automatically backported this PR to "5-0-x", please check out #16640 |
poiru
added a commit
that referenced
this pull request
Jan 31, 2019
I believe the existing code was fine, but better be safe than sorry. This typo was introduced in #16612.
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Jan 31, 2019
I believe the existing code was fine, but better be safe than sorry. This typo was introduced in electron#16612.
poiru
added a commit
that referenced
this pull request
Jan 31, 2019
I believe the existing code was fine, but better be safe than sorry. This typo was introduced in #16612.
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Jan 31, 2019
I believe the existing code was fine, but better be safe than sorry. This typo was introduced in electron#16612.
trop-bot
pushed a commit
to trop-bot/electron
that referenced
this pull request
Jan 31, 2019
I believe the existing code was fine, but better be safe than sorry. This typo was introduced in electron#16612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, the synchronous save dialog does not work properly and breaks
in weird ways when the dialog is expanded/collapsed (see #14606). This
works around the problem for the dialog shown for
<a download=...>byswitching to the asynchronous API.
To test this:
main.js:
test.html:
Notes: Fix broken save dialog on macOS for
<a>downloads