Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate <webview>.getWebContents() #20726

Merged
merged 1 commit into from Nov 7, 2019
Merged

feat: deprecate <webview>.getWebContents() #20726

merged 1 commit into from Nov 7, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 24, 2019 •
edited

Description of Change

  • deprecates the <webview>.getWebContents() API
  • suggests using remote.webContents.fromId(<webview>.getWebContentsId()) as replacement

Checklist

Release Notes

Notes: Deprecated <webview>.getWebContents() as it depends on the remote module.

@miniak miniak added the wip ⚒ label Oct 24, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 24, 2019
@miniak miniak force-pushed the miniak/webview-webcontents branch 2 times, most recently from 811cc0e to 93622dc Compare October 24, 2019 17:30
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2019
@nornagon
Copy link
Member

what's still wip about this?

@miniak miniak removed the wip ⚒ label Oct 29, 2019
@miniak miniak marked this pull request as ready for review October 29, 2019 01:52
@miniak
Copy link
Contributor Author

miniak commented Oct 29, 2019

@nornagon the tests will have to be updated to not use the deprecated API

@zcbenz
Copy link
Member

zcbenz commented Oct 31, 2019

/cc @electron/wg-api

@miniak miniak self-assigned this Oct 31, 2019
nornagon
nornagon reviewed Oct 31, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous API would only allow getting guest webcontents for the current host, right? Do we want to add some example code for checking that?

@miniak
Copy link
Contributor Author

miniak commented Nov 4, 2019

@nornagon yes, that's why I wanted to just make remote.getGuestWebContents() public instead of suggesting to use remote.webContents.fromId() instead.

@miniak miniak changed the title feat: make remote.getGuestWebContents() public feat: deprecate <webview>.getWebContents() Nov 5, 2019
@miniak miniak force-pushed the miniak/webview-webcontents branch 2 times, most recently from e3aad9c to 135910d Compare November 5, 2019 02:11
@miniak

This comment has been minimized.

Sign in to view
@miniak

This comment has been minimized.

Sign in to view
@miniak miniak added the wip ⚒ label Nov 5, 2019
@miniak miniak force-pushed the miniak/webview-webcontents branch 3 times, most recently from bcf3ec5 to 8817cce Compare November 5, 2019 22:49
@miniak miniak removed the wip ⚒ label Nov 5, 2019
@miniak miniak mentioned this pull request Nov 5, 2019
Merged
6 tasks
@miniak
Copy link
Contributor Author

miniak commented Nov 7, 2019

@codebytere are you ok with merging the PR?

@codebytere codebytere merged commit f1e7393 into master Nov 7, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 7, 2019

Release Notes Persisted

Deprecated <webview>.getWebContents() as it depends on the remote module.

@trop trop bot mentioned this pull request Nov 7, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Nov 7, 2019

I have automatically backported this PR to "8-x-y", please check out #21039

@miniak miniak deleted the miniak/webview-webcontents branch November 18, 2019 16:08
@sofianguy sofianguy added this to Fixed in 8.0.0-beta.3 in 8.2.x Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
No open projects
8.2.x
Fixed in 8.0.0-beta.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @nornagon @zcbenz @jkleinsc @codebytere