feat: custom positioning for traffic light buttons

[TonyWuu]

Description of Change

There seems to be a high demand for custom inset traffic light buttons in Electron.

• I added a new option in BrowserWindow, trafficLightPosition which sets the (x,y) position of the traffic light buttons.
• It needs to be used in conjunction with titleBarStyle: 'hidden' to work.
• Default to a value of (0, 0), which results in the standard default position, identical to the regular placement in titleBarStyle: 'hidden'.

e.g.

titleBarStyle: 'hidden'
trafficLightPosition: {x: 12, y: 42}

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: add trafficLightPosition option in BrowserWindow API to allow custom positioning of traffic lights

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[zcbenz]

/cc @electron/wg-api for more inputs.

[MarshallOfSound]

In terms of API I'd prefer

trafficLightPosition: {
  x: number;
  y: number;
}

Then it is just a Point object

[MarshallOfSound]

This does not allow offsets set to 0 which someone may want

[TonyWuu]

My thinking was that an offset of 0 should result in the default position of the traffic lights (in titleBarStyle: 'hidden' mode). Are you suggesting there's a use case where someone might want an offset smaller than that default position? In that case, negative numbers would work here.

IMO (x: 0, y: 0) should have a frame of reference relative to the default position, and not the absolute (0, 0) position of the frame

[MarshallOfSound]

Seems legit 👍

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[release-clerk]

Release Notes Persisted

add trafficLightPosition option in BrowserWindow API to allow custom positioning of traffic lights

[trop]

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #21990

[jameskerr]

I'm excited for this! Thanks!