fix: use the new MediaPlayPause key listener for internal chrome logic #21959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
reviewed
Jan 29, 2020
patches/chromium/fix_use_the_new_mediaplaypause_key_listener_for_internal_chrome.patch
Show resolved
Hide resolved
deepak1556
reviewed
Jan 29, 2020
MarshallOfSound
force-pushed
the
mediakey-fix
branch
from
ceb8a83
to
8c8606a
Compare
codebytere
approved these changes
Jan 30, 2020
deepak1556
approved these changes
Jan 30, 2020
|
Release Notes Persisted
|
|
/trop run backport-to 8-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "8-x-y", please check out #21998 |
|
/trop run backport-to 7-1-x |
|
The backport process for this PR has been manually initiated - |
|
I was unable to backport this PR to "7-1-x" cleanly; |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops a previous fix (#21442) from regressing https://bugs.chromium.org/p/chromium/issues/detail?id=930180
This patch should be upstreamable in a similar form in a way that will make our patch a single line
Notes: fixed issue with when playing videos or audio Electron would ask for accessibility access