feat: make win.setAspectRatio() work on Windows #26941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
semver/minor
5 tasks
zcbenz
force-pushed
the
windows-win-aspect-ratio
branch
from
5e95e83
to
7c7151d
Compare
samuelmaddock
approved these changes
Dec 11, 2020
jkleinsc
reviewed
Dec 14, 2020
zcbenz
force-pushed
the
windows-win-aspect-ratio
branch
from
7c7151d
to
b5e4f83
Compare
jkleinsc
approved these changes
Dec 21, 2020
codebytere
approved these changes
Jan 4, 2021
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
zcbenz
force-pushed
the
windows-win-aspect-ratio
branch
from
b5e4f83
to
0a54b54
Compare
|
Release Notes Persisted
|
|
@electron/wg-releases @zcbenz I'm interested in seeing this work in 11.x.y. Any chance we could get it backported? |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
This was referenced Jan 6, 2021
|
I have automatically backported this PR to "12-x-y", please check out #27202 |
|
I have automatically backported this PR to "11-x-y", please check out #27203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #8036.
This PR makes
win.setAspectRatiowork on Windows. It didn't work previously because the Windows implementation requires a non-zero maximum size, while we provided (0, 0) when maximum size is not set.There is also a patch added to allow setting aspect ratio to 0 on Windows.
I'm unable to write a test for this because the aspect ratio is not respected when window is resized programmingly with APIs like
win.setSize, it is also why we did not have a test for it at the first place.Checklist
npm testpassesRelease Notes
Notes: Make
win.setAspectRatio()work on Windows.