fix: BrowserView background color in webContents #33435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
target/16-x-y
semver/patch
codebytere
changed the title
codebytere
force-pushed
the
fix-browserview-bg
branch
from
122186e
to
fe08a47
Compare
samuelmaddock
approved these changes
Mar 24, 2022
zcbenz
approved these changes
Mar 28, 2022
codebytere
force-pushed
the
fix-browserview-bg
branch
from
176f6f7
to
7f266ff
Compare
jkleinsc
approved these changes
Mar 28, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "16-x-y" cleanly; |
|
I was unable to backport this PR to "17-x-y" cleanly; |
|
I have automatically backported this PR to "18-x-y", please check out #33478 |
|
@codebytere has manually backported this PR to "17-x-y", please check out #33545 |
|
@codebytere has manually backported this PR to "16-x-y", please check out #33546 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* chore: fix BrowserView background color in webContents * disable screen capture test on linux * spec: fix platform failure condition
3 tasks
|
@codebytere this fix regressed #31722 |
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: fix BrowserView background color in webContents * disable screen capture test on linux * spec: fix platform failure condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #33374.
Fixes an issue where backgroundColor would not be applied correctly to a BrowserView on Windows. This was happening because the color was being set on the
RenderWidgetHostViewin webContents, but the color was missing fromwebPreferencesand so was transparent every time. We need to ensure the color is set properly on the window as well as the contents every timesetBackgroundColoris called, as is done onBrowserWindow.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue with background colors being improperly applied to
BrowserViews on Windows.