fix: win.isMaximized() for transparent windows on Windows
#38234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
4 tasks
dsanders11
approved these changes
May 9, 2023
VerteDinde
approved these changes
May 9, 2023
dsanders11
reviewed
May 10, 2023
codebytere
force-pushed
the
fix-max-min
branch
3 times, most recently
from
811e94f
to
4221b24
Compare
|
@codebytere, looks like the new test fails on macOS, it must also have a bug with transparent windows and |
4 tasks
codebytere
force-pushed
the
fix-max-min
branch
3 times, most recently
from
613fb21
to
ef9da36
Compare
|
Release Notes Persisted
|
This was referenced May 17, 2023
|
I have automatically backported this PR to "24-x-y", please check out #38343 |
trop
bot
removed
the
target/24-x-y
|
I have automatically backported this PR to "23-x-y", please check out #38344 |
|
I have automatically backported this PR to "25-x-y", please check out #38345 |
trop
bot
added
in-flight/23-x-y
in-flight/25-x-y
merged/24-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an issue where calling
win.minimize()directly after callingwin.maximize(), and then callingwin.isMaximized()incorrectly returnstrue.This is happening because widget methods don't work as expected in several cases for transparent windows, and so we fall back to an approximation approach where we compare bounds. However, bounds when minimized match the screen area when minimized, so the resulting comparison can false positive to true. We should ensure it's not minimized before proceeding.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where calling
win.minimize()directly after callingwin.maximize(), and then callingwin.isMaximized()incorrectly returnstrue.