Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: add enforceForJSX option to no-unused-expressions rule #14012

Merged
merged 11 commits into from Feb 10, 2021
Merged
8 changes: 8 additions & 0 deletions lib/rules/no-unused-expressions.js
Expand Up @@ -39,6 +39,10 @@ module.exports = {
{
type: "object",
properties: {
allowJsx: {
type: "boolean",
default: false
},
allowShortCircuit: {
type: "boolean",
default: false
Expand All @@ -63,6 +67,7 @@ module.exports = {

create(context) {
const config = context.options[0] || {},
allowJsx = config.allowJsx || false,
allowShortCircuit = config.allowShortCircuit || false,
allowTernary = config.allowTernary || false,
allowTaggedTemplates = config.allowTaggedTemplates || false;
Expand Down Expand Up @@ -140,6 +145,9 @@ module.exports = {
},
FunctionExpression: alwaysTrue,
Identifier: alwaysTrue,
JSXElement() {
return !allowJsx;
},
Literal: alwaysTrue,
LogicalExpression(node) {
if (allowShortCircuit) {
Expand Down
18 changes: 18 additions & 0 deletions tests/lib/rules/no-unused-expressions.js
Expand Up @@ -82,6 +82,17 @@ ruleTester.run("no-unused-expressions", rule, {
{
code: "obj?.foo(\"bar\")",
parserOptions: { ecmaVersion: 11 }
},

// JSX
{
code: "<div />",
options: [{ allowJsx: true }],
parserOptions: { ecmaFeatures: { jsx: true } }
},
{
code: "var partial = <div />",
parserOptions: { ecmaFeatures: { jsx: true } }
duncanbeevers marked this conversation as resolved.
Show resolved Hide resolved
}
],
invalid: [
Expand Down Expand Up @@ -152,6 +163,13 @@ ruleTester.run("no-unused-expressions", rule, {
code: "obj?.foo().bar",
parserOptions: { ecmaVersion: 2020 },
errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
},

// JSX
{
code: "<div />",
parserOptions: { ecmaFeatures: { jsx: true } },
errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
}
]
});