feat(babel-preset-expo, expo-router): Add Expo Router babel features to babel-preset-expo #24779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
marklawlor,
brentvatne,
ide and
byCedric
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
byCedric
approved these changes
Oct 11, 2023
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
…to babel-preset-expo (#24779) # Why - Reduce the boilerplate required for expo-router by moving the babel plugin features to babel-preset-expo. - Make the expo-constants Metro web support work without Expo Router. - Keeping expo-router/babel around for now since it shouldn't cause any harm, this will support if someone needs to use Expo Router v3 with Expo SDK 49 in the future (which probably won't work anyways). - Fix #23819 <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Move code from expo-router/babel.js to babel-preset-expo. - Rewrite plugin to use TypeScript. - Add tests. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - Added tests for the new plugins. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
EvanBacon
added a commit
that referenced
this pull request
Dec 11, 2023
# Why - Companion PR to #24779 but we'll keep it in draft until we get closer to releasing SDK 50. --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why - Companion PR to expo#24779 but we'll keep it in draft until we get closer to releasing SDK 50. --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).