feat(babel): minify typeof window #27530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Simek,
amandeepmittal,
brentvatne and
ide
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
3 tasks
amandeepmittal
approved these changes
Mar 8, 2024
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
EvanBacon
added a commit
that referenced
this pull request
Mar 13, 2024
# Why
- The upstream module has a lot of concessions for legacy features that
don't appear to be used anymore, like importing from a module named
`require("Platform")` (Haste).
- We also want to combine the dev inlining with our other inlines via
#27530
- I've also added correct handling for web, where we'll now remove the
`native` fallback option.
- Finally, I added support for `Platform["OS"]`.
<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->
# Test Plan
- Added a bunch of tests for the expected functionality.
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->
- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
---------
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's common to use
typeof window === 'undefined'to conditionally enable/disable code for server/client environments.babel-preset-expoautomatically transformstypeof window === 'undefinedtotruewhen bundling for server environments, andfalsewhen bundling for websites. The check is left as-is when bundling for native client environments to support apps that polyfillwindow.This transform is run in both development and production, but only removes conditional requires in production.
You can configure
babel-preset-expoto skip the transform by passing{ preserveTypeofWindow: false }.How
Add
babel-plugin-transform-defineand conditionally enable when bundling for websites and server code. Skip entirely for native client bundles as these are ambiguous. We also expose the ability to force the flag on/off for native client in case users want a more strict runtime protection againsttypeof window.Additionally, I merged
process.env.EXPO_OSand BASE_URL in this transform to reduce passes. In a follow up PR, I'll mergeprocess.env.NODE_ENVand__DEV__too.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).