[expo-firebase-analytics] Updates Regex To Allow Numeric Chars

packages/expo-firebase-analytics/CHANGELOG.md

@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Fixes `parseEvent` to allow numeric characters as part of the `eventName` since the name can be alphanumeric. ([#8516](https://github.com/expo/expo/pull/8516) by [@thorbenprimke](https://github.com/thorbenprimke))
+
 ## 2.4.0 — 2020-05-27
 
 ### 🎉 New features

packages/expo-firebase-analytics/package.json

@@ -32,6 +32,9 @@
   "author": "650 Industries, Inc.",
   "license": "MIT",
   "homepage": "https://github.com/expo/expo/tree/master/packages/expo-firebase-analytics",
+  "jest": {
+    "preset": "expo-module-scripts/ios"
+  },
   "unimodulePeerDependencies": {
     "@unimodules/core": "*",
     "expo-constants": "*"

packages/expo-firebase-analytics/src/FirebaseAnalyticsJS.ts

@@ -189,7 +189,8 @@ class FirebaseAnalyticsJS {
       !eventName.length ||
       eventName.length > 40 ||
       eventName[0] === '_' ||
-      !eventName.match(/^[A-Za-z_]+$/) ||
+      eventName[0].match(/^\d$/) ||
+      !eventName.match(/^[A-Za-z_0-9]+$/) ||
       eventName.startsWith('firebase_') ||
       eventName.startsWith('google_') ||
       eventName.startsWith('ga_')

packages/expo-firebase-analytics/src/__tests__/FirebaseAnalyticsJS-test.ts

@@ -0,0 +1,27 @@
+import FirebaseAnalyticsJS from '../FirebaseAnalyticsJS';
+
+it(`Verfies parseEvent eventName validation`, async () => {
+  expect.assertions(2);
+  const expectedErrorMessage =
+    'Invalid event-name specified. Should contain 1 to 40 alphanumeric characters or underscores. The name must start with an alphabetic character.';
+  const options = {
+    clientId: '0',
+    sessionId: '0',
+  };
+
+  FirebaseAnalyticsJS.parseEvent(options, 'MyAnalyticsEvent');
+
+  try {
+    FirebaseAnalyticsJS.parseEvent(options, '_MyAnalyticsEvent');
+  } catch (error) {
+    expect(error.message).toBe(expectedErrorMessage);
+  }
+
+  try {
+    FirebaseAnalyticsJS.parseEvent(options, '0MyAnalyticsEvent');
+  } catch (error) {
+    expect(error.message).toBe(expectedErrorMessage);
+  }
+
+  FirebaseAnalyticsJS.parseEvent(options, 'MyAnalyticsEvent0');
+});