lint: chang eslint-plugin version to ~5.12.1

[xtx1130]

lint: change version for eslint-plugin until typescript-eslint/typescript-eslint#4620 be merged and publish new version
test: change 3000 to random port, prevent local test failed due to port address already in use

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[xtx1130]

I think the github ci doesn't use "@typescript-eslint/eslint-plugin": "~5.12.1" for checking😒. I don't think there is any need to change the eslint-plugin version anymore. What's your opinions? @fastify/core

[climba03003]

I think it is more related to the typescript version instead of @typescript-eslint/eslint-plugin
As semver x.y is the major version of TypeScript, I think we should just lock it to ~4.5.x

I see the problematic PR.

[mcollina]

I think the github ci doesn't use "@typescript-eslint/eslint-plugin": "~5.12.1" for checking😒. I don't think there is any need to change the eslint-plugin version anymore. What's your opinions? @fastify/core

I don't understand what problematic PR you are referring to.

[climba03003]

I think the github ci doesn't use "@typescript-eslint/eslint-plugin": "~5.12.1" for checking😒. I don't think there is any need to change the eslint-plugin version anymore. What's your opinions? @fastify/core

I don't understand what problematic PR you are referring to.

The lint error introduced in PR 4541 which comes with version 5.13.0 for @typescript-eslint/eslint-plugin.

[xtx1130]

All PRs for fastify's lint check is failing, and I have found it is a bug comes from @typescript-eslint/eslint-plugin at version 5.13.0, I want to use 5.12.1 for default. But github ci linter also failed. So I think gitlab ci doesn't use 5.12.1 for lint and change the version for @typescript-eslint/eslint-plugin is useless.

[mcollina]

@xtx1130 can you split the change-of-port to the package.json edit?

[xtx1130]

@xtx1130 can you split the change-of-port to the package.json edit?

ok, I will start another pr mainly for port

[mcollina]

I have a better fix on the way ;)

[xtx1130]

be closed because of #3741 has merged

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.