Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to markdown-link-check@3.10.0 #129

Closed
wants to merge 2 commits into from
Closed

Upgrade to markdown-link-check@3.10.0 #129

wants to merge 2 commits into from

Conversation

bogdandrutu
Copy link

No description provided.

@creachadair creachadair mentioned this pull request Apr 6, 2022
Closed
@creachadair
Copy link
Contributor

Test results: #131 (comment)

@creachadair
Copy link
Contributor

Hi @gaurav-nelson! Per your request, I gathered some test results suggesting that this change should be an improvement. Is there anything further I can do to help this PR get merged?

@TylerHelmuth TylerHelmuth mentioned this pull request Apr 11, 2022
Closed
@bogdandrutu
Copy link
Author

@gaurav-nelson what can we do to have this merged

creachadair pushed a commit to tendermint/tendermint that referenced this pull request Apr 13, 2022
Work around markdown-link-check issues.
d7cdb99 
This PR works around two issues causing the markdown link check to fail in CI.

1. actions/checkout#760. A git permissions issue,
   apparently triggered by a combination of a git change and the behaviour of
   actions/checkout.

2. gaurav-nelson/github-action-markdown-link-check#129.
   Merging an updated version of the underlying package that fixes a bug in the
   handling of local #anchors.

The workaround is a temporary patched fork of the link-checker action.  This
should be removed once the upstream issues are addressed.
This was referenced Apr 13, 2022
Closed
Merged
creachadair pushed a commit to tendermint/tendermint that referenced this pull request Apr 13, 2022
Work around markdown-link-check issues.
00372ef 
This PR works around two issues causing the markdown link check to fail in CI.

1. actions/checkout#760. A git permissions issue,
   apparently triggered by a combination of a git change and the behaviour of
   actions/checkout.

2. gaurav-nelson/github-action-markdown-link-check#129.
   Merging an updated version of the underlying package that fixes a bug in the
   handling of local #anchors.

The workaround is a temporary patched fork of the link-checker action.  This
should be removed once the upstream issues are addressed.
creachadair pushed a commit to tendermint/tendermint that referenced this pull request Apr 13, 2022
Work around markdown-link-check issues. (#8339)
6bbf5b6 
Work around two issues causing the markdown link check to fail in CI.

1. actions/checkout#760. A git permissions issue,
   apparently triggered by a combination of a git change and the behaviour of
   actions/checkout.

2. gaurav-nelson/github-action-markdown-link-check#129.
   Merging an updated version of the underlying package that fixes a bug in the
   handling of local #anchors.

The workaround is a temporary patched fork of the link-checker action.  This
should be removed once the upstream issues are addressed.
@creachadair creachadair mentioned this pull request Apr 19, 2022
Closed
@nvliyuan
Copy link

@creachadair after update the change, there are still some reference links marked as dead, but actually, they can be access, please see the log for more detail
image
image
and this link is not dead
image

@creachadair
Copy link
Contributor

@creachadair after update the change, there are still some reference links marked as dead, but actually, they can be access, please see the log for more detail

Perhaps, but note that the results are considerably better with the newer version. The problem with the links is in the underlying link check library, not in the GitHub action.

(Neither is mine, by the way, I'm just another user)

@gaurav-nelson
Copy link
Owner

I still see some anchors not handled properly PS:tcort/markdown-link-check#91 (comment) and tcort/markdown-link-check#195

Additionally, I would like to have an option for users to enable or disable it tcort/markdown-link-check#196

@creachadair
Copy link
Contributor

I still see some anchors not handled properly PS:tcort/markdown-link-check#91 (comment) and tcort/markdown-link-check#195

Additionally, I would like to have an option for users to enable or disable it tcort/markdown-link-check#196

Yes, there still do seem to be some problems. However, v3.10.0 is a considerable improvement over the previous version, so it might be worthwhile to update anyway.

@divyansh42
Copy link

From today our CI started failing as link checker is not able to resolve reference links and it says as dead links.
image
Any update on when this will be fixed?

This was referenced Apr 20, 2022
Closed
Closed
Merged
@derberg derberg mentioned this pull request Apr 20, 2022
Closed
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2022
Merged
9 tasks
@xujiajiadexiaokeai xujiajiadexiaokeai mentioned this pull request May 27, 2022
Merged
@edumserrano
Copy link

Perhaps we can use this PR to update to 3.10.2.
Version 3.10.1 release notes include:

gaurav-nelson
gaurav-nelson reviewed Jun 13, 2022
View reviewed changes
entrypoint.sh Outdated Show resolved Hide resolved
@creachadair creachadair mentioned this pull request Jun 23, 2022
Merged
@danyalaytekin danyalaytekin mentioned this pull request Jul 12, 2022
Merged
@gaurav-nelson
Copy link
Owner

Thank you #144 superseeds this.

@bogdandrutu bogdandrutu deleted the patch-2 branch July 29, 2022 00:15
@dfarrell07 dfarrell07 mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav-nelson gaurav-nelson gaurav-nelson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bogdandrutu @creachadair @nvliyuan @gaurav-nelson @divyansh42 @edumserrano