Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codecov report generation by adding the workspace to git's safe directory #56

Merged
merged 2 commits into from Jun 1, 2022
Merged

Fix codecov report generation by adding the workspace to git's safe directory #56

merged 2 commits into from Jun 1, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 3, 2022

azeey added 2 commits May 2, 2022 23:55
@azeey
Fix codecov report generation by specifying the root directory
a63d5e5 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Fix using git safe.directory
803988e 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@chapulina chapulina added this to Inbox in Infrastructure via automation May 3, 2022
@chapulina chapulina moved this from Inbox to In review in Infrastructure May 3, 2022
@azeey azeey changed the title Fix codecov report generation by specifying the root directory Fix codecov report generation by adding the workspace to git's safe directory May 3, 2022
@azeey
Copy link
Contributor Author

azeey commented May 3, 2022

Specifying the root directory didn't quite work. It ended up including the full path for each source file in the generated report. Instead, the better solution was to let git know that the workspace is okay to use even if it's owned by a different user. I believe this is the root cause of the problem anyway (see actions/checkout#760), so I'm happy with the solution.

Test build:
https://github.com/ignitionrobotics/sdformat/runs/6280082602?check_suite_focus=true

Generated report:
https://codecov.io/gh/ignitionrobotics/sdformat/tree/0a5f9185c061d303729e5c24c83ff04691330d5d

@j-rivero j-rivero removed this from In review in Infrastructure May 9, 2022
@azeey azeey merged commit 1f86f7b into focal Jun 1, 2022
@azeey azeey deleted the fix_codecov branch June 1, 2022 18:30
This was referenced Jun 4, 2022
Closed
Open
scpeters pushed a commit that referenced this pull request Jun 4, 2022
@azeey @scpeters
Fix codecov report generation by adding the workspace to git's safe d…
f41b8fd 
…irectory (#56)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters mentioned this pull request Jun 4, 2022
Merged
chapulina pushed a commit that referenced this pull request Jun 6, 2022
@scpeters @azeey
Fix codecov report generation by adding the workspace to git's safe d…
8113672 
…irectory (#56) (#60)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azeey @scpeters