feat(#3238):Support map in query parameters #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
May 29, 2023
li31727
force-pushed
the
GeneratesMap-main6
branch
from
3db0391
to
2ade32c
Compare
|
CI/golangci It's strange that I can run success on my repository but not here，Please try golangci again |
johanbrandhorst
requested changes
May 31, 2023
There was a problem hiding this comment.
Thanks for the updates, I missed one case of an extra newline, but I also wanted to ask if you could try using one of these object parameters in one of our Go integration tests: https://github.com/grpc-ecosystem/grpc-gateway/blob/main/examples/internal/integration/integration_test.go. Maybe have a look and see if it makes sense anywhere, if not, that's okay.
li31727
force-pushed
the
GeneratesMap-main6
branch
from
2ade32c
to
965282a
Compare
|
I in https://github.com/grpc-ecosystem/grpc-gateway/blob/main/examples/internal/integration/integration_test.go has added a map types of GET request parameter, I don't know whether there is a problem in my test code, I found that grpc-gateway does not seem to support GET requests with a map type and value of type message |
|
Seems like the tests are passing, so I think that test is great, thank you! |
johanbrandhorst
approved these changes
May 31, 2023
|
Thank you for your contribution! |
another-rex
pushed a commit
to google/osv.dev
that referenced
this pull request
Jun 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway) | require | minor | `v2.15.2` -> `v2.16.0` | | [jekyll-feed](https://togithub.com/jekyll/jekyll-feed) | | minor | `0.15.1` -> `0.17.0` | --- ### Release Notes <details> <summary>grpc-ecosystem/grpc-gateway</summary> ### [`v2.16.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.16.0) [Compare Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.15.2...v2.16.0) #### What's Changed - Upgrade some deps by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [grpc-ecosystem/grpc-gateway#3214 - add note about incompatibility of remote plugins and external configu… by [@​DGuhr](https://togithub.com/DGuhr) in [grpc-ecosystem/grpc-gateway#3220 - Fix tests by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [grpc-ecosystem/grpc-gateway#3234 - use_allof_for_refs: extend to example field by [@​igor-tsiglyar](https://togithub.com/igor-tsiglyar) in [grpc-ecosystem/grpc-gateway#3240 - New `ignore_comments` option for excluding proto comments from OpenAPI output by [@​keyz](https://togithub.com/keyz) in [grpc-ecosystem/grpc-gateway#3252 - Only allow POST -> GET path length fallback by [@​nacx](https://togithub.com/nacx) in [grpc-ecosystem/grpc-gateway#3272 - Remove GHA workflow that pushes to BSR by [@​unmultimedio](https://togithub.com/unmultimedio) in [grpc-ecosystem/grpc-gateway#3279 - fix: enum should be int when enums_as_int = true by [@​hnlq715](https://togithub.com/hnlq715) in [grpc-ecosystem/grpc-gateway#3167 - doc: Add OpenTelemetry go tracing example by [@​iamrajiv](https://togithub.com/iamrajiv) in [grpc-ecosystem/grpc-gateway#3309 - Switch from aliased field_mask package to canonical package by [@​liggitt](https://togithub.com/liggitt) in [grpc-ecosystem/grpc-gateway#3317 - Replace deprecated command with environment file by [@​jongwooo](https://togithub.com/jongwooo) in [grpc-ecosystem/grpc-gateway#3319 - changed block from code to paragraph by [@​shashaneRanasinghe](https://togithub.com/shashaneRanasinghe) in [grpc-ecosystem/grpc-gateway#3330 - feat([#​3238](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3238)):Support map in query parameters by [@​li31727](https://togithub.com/li31727) in [grpc-ecosystem/grpc-gateway#3323 - A few fixes for streaming responses by [@​johanbrandhorst](https://togithub.com/johanbrandhorst) in [grpc-ecosystem/grpc-gateway#3335 #### New Contributors - [@​DGuhr](https://togithub.com/DGuhr) made their first contribution in [grpc-ecosystem/grpc-gateway#3220 - [@​xieyuschen](https://togithub.com/xieyuschen) made their first contribution in [grpc-ecosystem/grpc-gateway#3231 - [@​igor-tsiglyar](https://togithub.com/igor-tsiglyar) made their first contribution in [grpc-ecosystem/grpc-gateway#3240 - [@​KiK0S](https://togithub.com/KiK0S) made their first contribution in [grpc-ecosystem/grpc-gateway#3247 - [@​keyz](https://togithub.com/keyz) made their first contribution in [grpc-ecosystem/grpc-gateway#3252 - [@​nacx](https://togithub.com/nacx) made their first contribution in [grpc-ecosystem/grpc-gateway#3272 - [@​unmultimedio](https://togithub.com/unmultimedio) made their first contribution in [grpc-ecosystem/grpc-gateway#3279 - [@​hnlq715](https://togithub.com/hnlq715) made their first contribution in [grpc-ecosystem/grpc-gateway#3167 - [@​liggitt](https://togithub.com/liggitt) made their first contribution in [grpc-ecosystem/grpc-gateway#3317 - [@​jongwooo](https://togithub.com/jongwooo) made their first contribution in [grpc-ecosystem/grpc-gateway#3319 - [@​shashaneRanasinghe](https://togithub.com/shashaneRanasinghe) made their first contribution in [grpc-ecosystem/grpc-gateway#3330 **Full Changelog**: grpc-ecosystem/grpc-gateway@v2.15.2...v2.15.3 </details> <details> <summary>jekyll/jekyll-feed</summary> ### [`v0.17.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#​0170--2022-10-14) [Compare Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.16.0...v0.17.0) ##### Documentation - Update CI status badge ([#​363](https://togithub.com/jekyll/jekyll-feed/issues/363)) ##### Development Fixes - Add Ruby 3.1 to the CI matrix ([#​365](https://togithub.com/jekyll/jekyll-feed/issues/365)) ##### Minor Enhancements - Allow disabling of jekyll-feed while in development ([#​370](https://togithub.com/jekyll/jekyll-feed/issues/370)) ### [`v0.16.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#​0160--2022-01-03) [Compare Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.15.1...v0.16.0) ##### Minor Enhancements - Add support for `page.description` in front matter to become entry `<summary>` ([#​297](https://togithub.com/jekyll/jekyll-feed/issues/297)) ##### Bug Fixes - Fold private methods into the `:render` method as local variables ([#​327](https://togithub.com/jekyll/jekyll-feed/issues/327)) - Check `post.categories` instead of `post.category` ([#​357](https://togithub.com/jekyll/jekyll-feed/issues/357)) - Switched xml_escape for `<![CDATA[]]>` for post content ([#​332](https://togithub.com/jekyll/jekyll-feed/issues/332)) ##### Development Fixes - Add Ruby 3.0 to CI ([#​337](https://togithub.com/jekyll/jekyll-feed/issues/337)) - Lock RuboCop to v1.18.x ([#​348](https://togithub.com/jekyll/jekyll-feed/issues/348)) - Add workflow to release gem via GH Action ([#​355](https://togithub.com/jekyll/jekyll-feed/issues/355)) ##### Documentation - Use `.atom` extension in documented examples since we write an Atom feed ([#​359](https://togithub.com/jekyll/jekyll-feed/issues/359)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #3238
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
Generate the swagger api for Get requests that pass map type parameters
Other comments