Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 4c79b45386348459926176911cb6b35f6f53dcdc #3856

Merged
merged 1 commit into from Jan 3, 2024

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Jan 3, 2024

Revert #3072 which introduced a regression in the
handling of nested query parameters.

Fixes #3848

Summary by CodeRabbit

  • Refactor

    • Simplified API by removing the "ResourceId" parameter from various service methods.
    • Updated data structures to reflect the removal of the "ResourceId" field.
  • Tests

    • Modified integration tests to align with the updated API structure.
  • Documentation

    • Adjusted API documentation to remove references to the deprecated "ResourceId" field.

Revert #3072 which introduced a regression in the
handling of nested query parameters.

Fixes #3848
Copy link

coderabbitai bot commented Jan 3, 2024

Walkthrough

The changes encompass the removal of the ResourceId field from various structures and functions in the Echo Service API and its unannotated counterpart. This adjustment affects the control flow, logic, and data models, and it simplifies the API by eliminating a parameter. Additionally, the associated integration tests have been updated to reflect the removal of ResourceId.

Changes

File Path Change Summary
.../echo/api_echo_service.go
.../unannotatedecho/api_unannotated_echo_service.go
Removed the ResourceId parameter from functions and associated logic.
.../echo/model_examplepb_simple_message.go
.../unannotatedecho/model_examplepb_unannotated_simple_message.go
Removed the ResourceId field from the struct.
.../integration/integration_test.go Removed testEchoPathParamOverwrite and testEchoBodyParamOverwrite functions; modified testEchoBody to exclude ResourceId.
.../proto/examplepb/echo_service.proto
.../proto/examplepb/unannotated_echo_service.proto
Removed the resource_id field and related additional_bindings.

Assessment against linked issues

Objective Addressed Explanation
Identify the change in behavior related to populating HTTP query parameters since v2.15.0. (#3848) The summary does not explicitly mention query parameters, so it's unclear if this behavior was reviewed.
Address the issue with nested fields and colliding names in query parameters. (#3848) It is not clear from the summary if the removal of ResourceId is related to this issue.
Restore expected behavior for field id.foo in query responses. (#3848) The summary does not provide information on the restoration of specific field behaviors.
Investigate JSON names impact on query param filtering with nested/colliding names. (#3848) There is no mention of JSON name awareness or its impact on query param filtering in the summary.
Verify issue resolution with integration test. (#3848) The modifications in integration_test.go suggest that tests have been updated, presumably to verify the resolution.

Poem

In the burrows of code, where the data streams flowed,
A field was plucked out, and simplicity sowed.
🐇💻 With every hop, the API cleaned,
A rabbit's work, deft and keen.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 5

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2c837f2 and 12909bb.
Files ignored due to filter (14)
  • examples/internal/clients/echo/api/swagger.yaml
  • examples/internal/clients/unannotatedecho/api/swagger.yaml
  • examples/internal/helloworld/helloworld.pb.gw.go
  • examples/internal/proto/examplepb/a_bit_of_everything.pb.gw.go
  • examples/internal/proto/examplepb/echo_service.pb.go
  • examples/internal/proto/examplepb/echo_service.pb.gw.go
  • examples/internal/proto/examplepb/echo_service.swagger.json
  • examples/internal/proto/examplepb/flow_combination.pb.gw.go
  • examples/internal/proto/examplepb/non_standard_names.pb.gw.go
  • examples/internal/proto/examplepb/unannotated_echo_service.pb.go
  • examples/internal/proto/examplepb/unannotated_echo_service.pb.gw.go
  • examples/internal/proto/examplepb/unannotated_echo_service.swagger.json
  • examples/internal/proto/examplepb/visibility_rule_echo_service.pb.gw.go
  • examples/internal/proto/standalone/unannotated_echo_service.pb.gw.go
Files selected for processing (8)
  • examples/internal/clients/echo/api_echo_service.go (25 hunks)
  • examples/internal/clients/echo/model_examplepb_simple_message.go (1 hunks)
  • examples/internal/clients/unannotatedecho/api_unannotated_echo_service.go (9 hunks)
  • examples/internal/clients/unannotatedecho/model_examplepb_unannotated_simple_message.go (1 hunks)
  • examples/internal/integration/integration_test.go (3 hunks)
  • examples/internal/proto/examplepb/echo_service.proto (3 hunks)
  • examples/internal/proto/examplepb/unannotated_echo_service.proto (1 hunks)
  • protoc-gen-grpc-gateway/internal/gengateway/template.go (1 hunks)
Files skipped from review due to trivial changes (4)
  • examples/internal/clients/echo/model_examplepb_simple_message.go
  • examples/internal/clients/unannotatedecho/api_unannotated_echo_service.go
  • examples/internal/clients/unannotatedecho/model_examplepb_unannotated_simple_message.go
  • examples/internal/proto/examplepb/unannotated_echo_service.proto
Additional comments: 17
examples/internal/proto/examplepb/echo_service.proto (3)
  • 34-37: The removal of the resource_id field from the SimpleMessage message is consistent with the PR's objective to revert a previous change that introduced a regression. Ensure that this field is not referenced anywhere else in the codebase.
Verification successful

The search for references to the resource_id field in .proto files did not yield any results. This suggests that the resource_id field is not referenced in any .proto files in the codebase, which aligns with the PR's objective to remove this field.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for references to the removed `resource_id` field in the proto files.
rg --type proto 'resource_id'

Length of output: 59



Script:

#!/bin/bash
# Search for references to the removed `resource_id` field in .proto files.
rg 'resource_id' --glob '*.proto'

Length of output: 33

* 61-65: The changes to the `additional_bindings` in the `EchoService` service reflect the removal of the `resource_id` field. Verify that the new bindings are correctly implemented and do not conflict with existing API routes.
Verification successful

The search results show various additional_bindings across different .proto files. The bindings in echo_service.proto do not seem to conflict with each other or with those in other files such as flow_combination.proto and a_bit_of_everything.proto. There are no overlapping paths that would suggest a conflict with the new bindings.

Based on the information provided, there are no apparent conflicts with the new additional_bindings in the echo_service.proto file. The changes seem to be correctly implemented with respect to the removal of the resource_id field and the update of the API routes.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for potential conflicts with the new additional_bindings in the proto files.
rg --type proto 'additional_bindings'

Length of output: 67



Script:

#!/bin/bash
# Search for potential conflicts with the new additional_bindings in all .proto files.
rg 'additional_bindings' --glob '*.proto'

Length of output: 3601

* 72-76: The `EchoBody` method's `additional_bindings` have been updated. Confirm that the new binding for the `PUT` method on `/v1/example/echo_body/{id}` with the body mapped to the `no` field is intended and that the `no` field is properly defined and used within the service.
protoc-gen-grpc-gateway/internal/gengateway/template.go (1)
  • 69-76: The logic for constructing the seqs slice in the QueryParamFilter function seems correct. It appends the field paths of the body and path parameters, splitting them by "." to handle nested fields. This is consistent with the expected behavior for handling query parameters in the grpc-gateway.
examples/internal/clients/echo/api_echo_service.go (10)
  • 58-58: The EchoServiceEcho function signature has been modified to remove the ResourceId parameter. Confirm that all calls to this function have been updated to reflect this change.
Verification successful

The search results from ripgrep show multiple occurrences of EchoServiceEcho and related functions. The specific call to EchoServiceEcho in client_test.go does not include a ResourceId parameter, which aligns with the updated function signature. The other references to EchoServiceEcho and similar functions in various files also do not show a ResourceId parameter being passed.

Based on the provided output, it appears that all calls to the EchoServiceEcho function have been updated to reflect the change in the function signature, with no remaining references to a ResourceId parameter.

Therefore, the review comment regarding the removal of the ResourceId parameter and the need to confirm that all calls to the EchoServiceEcho function have been updated is consistent with the codebase.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Search for any remaining references to the old function signature with the `ResourceId` parameter.
ast-grep --lang go --pattern $'EchoServiceEcho($_, $_, $_)'

Length of output: 60



Script:

#!/bin/bash
# Search for calls to EchoServiceEcho with two arguments to ensure the second argument is not a struct containing ResourceId.
ast-grep --lang go --pattern $'EchoServiceEcho($_, $_)'

Length of output: 56



Script:

#!/bin/bash
# Search for any occurrence of EchoServiceEcho to confirm it is being used correctly without the ResourceId parameter.
rg 'EchoServiceEcho' --go

Length of output: 454



Script:

#!/bin/bash
# Correcting the previous script to search for any occurrence of EchoServiceEcho without specifying a language flag.
rg 'EchoServiceEcho'

Length of output: 7758

* 96-98: The addition of the `NoNote` query parameter in the `EchoServiceEcho` function should be verified for correct implementation and usage across the codebase.
Verification successful


The NoNote query parameter is correctly implemented in the EchoServiceEcho function, as indicated by the search results showing the parameter being added to localVarQueryParams with the appropriate value conversion.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Check for correct implementation of the `NoNote` parameter in the EchoServiceEcho function.
ast-grep --lang go --pattern $'EchoServiceEcho($_, $_, $_) {
  $$$
  localVarQueryParams.Add("no.note", $_)
  $$$
}'

Length of output: 624



Script:

#!/bin/bash
# Check for correct implementation of the `NoNote` parameter in the EchoServiceEcho function.
ast-grep --lang go --pattern $'func ($_ EchoServiceEcho)($_, $_, $_) {
  $$$
  if $_ {
    $_.Add("no.note", $_)
  }
  $$$
}'

Length of output: 126



Script:

#!/bin/bash
# Check for the usage of `NoNote` parameter in the EchoServiceEcho function.
ast-grep --lang go --pattern $'func ($_ EchoServiceEcho)($$$) {
  $$$
  localVarQueryParams.Add("no.note", $_)
  $$$
}'

Length of output: 120



Script:

#!/bin/bash
# Search for the usage of `NoNote` parameter in the EchoServiceEcho function using ripgrep.
rg "localVarQueryParams.Add\(\"no.note\","

Length of output: 1271

* 238-240: The `NoNote` query parameter addition in the `EchoServiceEcho2` function should be verified for correct implementation and usage across the codebase.
  • 327-329: The En, NoProgress, and NoNote parameters have been added to the EchoServiceEcho3Opts struct. Verify that these additions are properly documented and used consistently.

  • 377-379: The NoNote query parameter addition in the EchoServiceEcho3 function should be verified for correct implementation and usage across the codebase.

Verification successful

The ast-grep search successfully located the EchoServiceEcho3 function within the api_echo_service.go file. The function includes logic to add the NoNote query parameter if it is set within the localVarOptionals:

if localVarOptionals != nil && localVarOptionals.NoNote.IsSet() {
    localVarQueryParams.Add("no.note", parameterToString(localVarOptionals.NoNote.Value(), ""))
}

This confirms that the NoNote query parameter is being handled correctly within the EchoServiceEcho3 function. The review comment asking to verify the correct implementation and usage of the NoNote query parameter in the EchoServiceEcho3 function is consistent with the codebase.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Check for correct implementation of the `NoNote` parameter in the EchoServiceEcho3 function.
ast-grep --lang go --pattern $'EchoServiceEcho3($_, $_, $_, $_, $_) {
  $$$
  localVarQueryParams.Add("no.note", $_)
  $$$
}'

Length of output: 642



Script:

#!/bin/bash
# Refine the ast-grep pattern to correctly match the EchoServiceEcho3 function in Go.
ast-grep --lang go --pattern $'func ($_ *EchoServiceApiService) EchoServiceEcho3($_, $_, $_, $_, $_) {
  $$$
  localVarQueryParams.Add("no.note", $_)
  $$$
}'

Length of output: 159



Script:

#!/bin/bash
# Search for the EchoServiceEcho3 function definition to confirm its existence and structure.
ast-grep --lang go --pattern $'func ($_ *EchoServiceApiService) EchoServiceEcho3($$$)'

Length of output: 10837

* 511-513: The `NoProgress` query parameter addition in the `EchoServiceEcho4` function should be verified for correct implementation and usage across the codebase.
Verification successful

I will attempt to correct the ast-grep pattern to properly match the EchoServiceEcho4 function and the usage of the NoProgress parameter within it.


I will use the rg command to search for the usage of NoProgress within the EchoServiceEcho4 function to verify its correct implementation.


I will perform a broader search for the NoProgress parameter across the entire codebase to gather more information about its usage.


The search results indicate that the NoProgress parameter is indeed used in the codebase, specifically within the api_unannotated_echo_service.go and api_echo_service.go files. It is referenced as an optional query parameter that is set and added to localVarQueryParams. The usage pattern is consistent across multiple functions within these files.

Based on the information provided by the search results, the NoProgress parameter is implemented correctly in the context of the api_echo_service.go file, as it is checked for being set and then added to the query parameters. This aligns with the review comment that asked for verification of the correct implementation and usage of the NoProgress query parameter in the EchoServiceEcho4 function.

Given the consistency of the implementation across various functions and the presence of the parameter in the swagger.yaml files, it can be inferred that the NoProgress parameter is likely to be correctly implemented.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Check for correct implementation of the `NoProgress` parameter in the EchoServiceEcho4 function.
ast-grep --lang go --pattern $'EchoServiceEcho4($_, $_, $_, $_, $_) {
  $$$
  localVarQueryParams.Add("no.progress", $_)
  $$$
}'

Length of output: 650



Script:

#!/bin/bash
# Check for correct implementation of the `NoProgress` parameter in the EchoServiceEcho4 function.
ast-grep --lang go --pattern $'func ($_ *EchoServiceApiService) EchoServiceEcho4($$$) {
  $$$
  localVarQueryParams.Add("no.progress", $_)
  $$$
}'

Length of output: 148



Script:

#!/bin/bash
# Search for the usage of `NoProgress` within the `EchoServiceEcho4` function.
rg 'func .*EchoServiceEcho4' -A 10 | rg 'NoProgress'

Length of output: 52



Script:

#!/bin/bash
# Search for the usage of `NoProgress` across the entire codebase.
rg 'NoProgress'

Length of output: 5734

* 651-653: The `NoProgress` query parameter addition in the `EchoServiceEcho5` function should be verified for correct implementation and usage across the codebase.
  • 976-978: The En, NoProgress, and NoNote parameters have been added to the EchoServiceEchoDeleteOpts struct. Verify that these additions are properly documented and used consistently.

  • 1035-1037: The NoNote query parameter addition in the EchoServiceEchoDelete function should be verified for correct implementation and usage across the codebase.

Verification successful

The search results show that the NoNote parameter is used consistently across various functions in the api_unannotated_echo_service.go and api_echo_service.go files. It is defined as an optional string parameter in the option structs for different service methods (EchoServiceEchoOpts, EchoServiceEcho2Opts, EchoServiceEchoDeleteOpts, etc.) and is added to the query parameters if it is set.

Additionally, the swagger.yaml files for both the annotated and unannotated echo services include the NoNote parameter as a query parameter, which is not required and is of type string.

Based on the search results, the NoNote query parameter addition in the EchoServiceEchoDelete function and its usage across the codebase appears to be correctly implemented.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Check for correct implementation of the `NoNote` parameter in the EchoServiceEchoDelete function.
ast-grep --lang go --pattern $'EchoServiceEchoDelete($_) {
  $$$
  localVarQueryParams.Add("no.note", $_)
  $$$
}'

Length of output: 620



Script:

#!/bin/bash
# Refine the ast-grep pattern to match the EchoServiceEchoDelete function and its usage of the NoNote parameter.
ast-grep --lang go --pattern $'func ($_ *EchoServiceApiService) EchoServiceEchoDelete($_) {
  $$$
  if $_ != nil && $_.NoNote.IsSet() {
    $_.Add("no.note", $_($_.NoNote.Value(), ""))
  }
  $$$
}'

Length of output: 198



Script:

#!/bin/bash
# Use ripgrep to search for the usage of `NoNote` within the `EchoServiceEchoDelete` function across the codebase.
rg "NoNote" --context 5

Length of output: 34778

* 1282-1284: The `NoNote` query parameter addition in the `EchoServiceEchoUnauthorized` function should be verified for correct implementation and usage across the codebase.
examples/internal/integration/integration_test.go (3)
  • 46-56: The removal of testEchoPathParamOverwrite and testEchoBodyParamOverwrite functions is consistent with the PR objectives. However, ensure that the removal of these tests does not reduce coverage for other features that are not related to the ResourceId field.
Verification successful

The search for references to testEchoPathParamOverwrite and testEchoBodyParamOverwrite in the Go files did not yield any results. This suggests that these functions are not called or referenced elsewhere in the Go codebase, which implies that their removal is unlikely to affect other features outside of the scope of the ResourceId field.

Based on the information provided:

  • : The removal of testEchoPathParamOverwrite and testEchoBodyParamOverwrite functions seems to be isolated and does not appear to impact other features in the codebase.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the removed tests do not affect other features.
rg --type go "testEchoPathParamOverwrite|testEchoBodyParamOverwrite"

Length of output: 70

* 353-353: The `ResourceId` field has been removed from the `sent` message in the `testEchoBody` function. Confirm that this field is no longer required and that the test still behaves as expected.
  • 418-420: The TestABE function is an entry point for multiple sub-tests. Ensure that the removal of the ResourceId field does not affect these sub-tests.
Verification successful

The output from the shell script indicates that there are several test functions related to TestABE in the integration_test.go file. The functions listed are TestABE, TestABEPatch, and TestABEPatchBody. However, the output does not provide information on whether the removal of the ResourceId field affects these sub-tests.

To verify if the ResourceId field removal affects these sub-tests, we need to check the contents of these functions to see if they reference the ResourceId field.


The absence of output from the search for the ResourceId field within the integration_test.go file suggests that the ResourceId field is not referenced in the sub-tests related to TestABE. This implies that the removal of the ResourceId field should not affect these sub-tests.

Based on the information gathered, it can be concluded that the sub-tests within TestABE are not affected by the removal of the ResourceId field.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that sub-tests within TestABE are not affected by the removal of the ResourceId field.
rg --type go "TestABE"

Length of output: 529



Script:

#!/bin/bash
# Check if the sub-tests related to TestABE reference the ResourceId field.
rg --type go "ResourceId" examples/internal/integration/integration_test.go

Length of output: 75

Comment on lines 40 to 43
* @param "En" (optional.String) -
* @param "NoProgress" (optional.String) -
* @param "NoNote" (optional.String) -
* @param "ResourceId" (optional.String) -

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EchoServiceEchoOpts struct does exist in the codebase, as confirmed by the rg command output. However, the previous ast-grep searches did not find the specific pattern including the En, NoProgress, and NoNote parameters within this struct, which suggests that these parameters might not be present or the pattern used did not match.

Given this information, the review comment stating that the parameters En, NoProgress, and NoNote have been added to the EchoServiceEchoOpts struct cannot be verified as correct based on the current evidence. It is possible that the parameters are not documented or used consistently, or they may not exist at all in the way described by the review comment.

  • The documentation search did not yield relevant results for the parameters En, NoProgress, and NoNote.
  • The ast-grep search did not find these parameters in the EchoServiceEchoOpts struct.
  • The rg search confirmed the existence of the EchoServiceEchoOpts struct but did not provide details on the presence of the new parameters.

Given the lack of evidence for the addition of these parameters, the review comment is not supported by the current findings.

Analysis chain

The parameters En, NoProgress, and NoNote have been added to the EchoServiceEchoOpts struct. Ensure that these new parameters are documented and that their usage is consistent with the rest of the codebase.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Verify that the new parameters are documented in the project's documentation.
rg --type md "En|NoProgress|NoNote" ./docs
# Check for consistent usage of the new parameters in the codebase.
ast-grep --lang go --pattern $'EchoServiceEchoOpts {
  $$$
  En: $_,
  NoProgress: $_,
  NoNote: $_
  $$$
}'

Length of output: 2589



Script:

#!/bin/bash
# Search for the EchoServiceEchoOpts struct definition to verify its existence and current structure.
ast-grep --lang go --pattern $'EchoServiceEchoOpts {
  $$$
}'

Length of output: 62



Script:

#!/bin/bash
# Use ripgrep to search for the EchoServiceEchoOpts struct in the codebase.
rg "EchoServiceEchoOpts" --type go

Length of output: 1037

Comment on lines 185 to 187
* @param "En" (optional.String) -
* @param "NoProgress" (optional.String) -
* @param "NoNote" (optional.String) -
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review comment cannot be verified as correct because the ast-grep command did not find any occurrences of EchoServiceEcho2Opts with the fields En, NoProgress, and NoNote. Additionally, the rg command found unrelated mentions of these terms in the documentation. Therefore, it seems that the parameters mentioned in the review comment are not present in the EchoServiceEcho2Opts struct, nor are they documented as part of it.

Analysis chain

The En, NoProgress, and NoNote parameters have been added to the EchoServiceEcho2Opts struct. Verify that these additions are properly documented and used consistently.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Ensure that the new parameters are documented in the project's documentation.
rg --type md "En|NoProgress|NoNote" ./docs
# Check for consistent usage of the new parameters in the codebase.
ast-grep --lang go --pattern $'EchoServiceEcho2Opts {
  $$$
  En: $_,
  NoProgress: $_,
  NoNote: $_
  $$$
}'

Length of output: 2590

Comment on lines 465 to 467
* @param "StatusProgress" (optional.String) -
* @param "En" (optional.String) -
* @param "NoProgress" (optional.String) -
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script output confirms the presence of the StatusProgress, En, and NoProgress parameters within the EchoServiceEcho4Opts struct in the api_echo_service.go file. This aligns with the review comment stating that these parameters have been added to the struct.

However, the ast-grep command did not find any usage of these parameters in the codebase, which could indicate that they are not being used consistently or at all. This discrepancy suggests that while the parameters have been added to the struct, their implementation in the codebase may not be complete or properly documented.

Based on the new context:

  • The parameters StatusProgress, En, and NoProgress are indeed present in the EchoServiceEcho4Opts struct.
  • The documentation search did not yield relevant results for these parameters, indicating a potential lack of proper documentation.
  • The ast-grep search did not find usage of these parameters, suggesting they might not be used consistently in the codebase.

Given these findings, the review comment is partially correct in stating that the parameters have been added, but there may be issues with documentation and consistent usage in the codebase.

Analysis chain

The StatusProgress, En, and NoProgress parameters have been added to the EchoServiceEcho4Opts struct. Verify that these additions are properly documented and used consistently.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Ensure that the new parameters are documented in the project's documentation.
rg --type md "StatusProgress|En|NoProgress" ./docs
# Check for consistent usage of the new parameters in the codebase.
ast-grep --lang go --pattern $'EchoServiceEcho4Opts {
  $$$
  StatusProgress: $_,
  En: $_,
  NoProgress: $_
  $$$
}'

Length of output: 2606



Script:

#!/bin/bash
# Check the actual definition of the EchoServiceEcho4Opts struct in the api_echo_service.go file.
rg "EchoServiceEcho4Opts" -A 10 examples/internal/clients/echo/api_echo_service.go

Length of output: 1096

Comment on lines 599 to 601
* @param "StatusProgress" (optional.String) -
* @param "En" (optional.String) -
* @param "NoProgress" (optional.String) -
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review comment mentions that the parameters StatusProgress, En, and NoProgress have been added to the EchoServiceEcho5Opts struct and should be verified for proper documentation and consistent usage.

The search in the documentation (./docs) did not yield any results for these parameters, suggesting they may not be documented there. The ast-grep command did not find any occurrences of EchoServiceEcho5Opts with the fields StatusProgress, En, and NoProgress in the Go codebase, indicating that these parameters are not used in the EchoServiceEcho5Opts struct.

The additional search in the entire codebase with rg found several instances of Encoding: map[string]int{...} in various Go files, but none of these instances are related to the parameters in question.

Based on the provided information, it appears that the review comment about the addition of the parameters StatusProgress, En, and NoProgress to the EchoServiceEcho5Opts struct may not be accurate, as there is no evidence of their usage or documentation in the codebase.

Analysis chain

The StatusProgress, En, and NoProgress parameters have been added to the EchoServiceEcho5Opts struct. Verify that these additions are properly documented and used consistently.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Ensure that the new parameters are documented in the project's documentation.
rg --type md "StatusProgress|En|NoProgress" ./docs
# Check for consistent usage of the new parameters in the codebase.
ast-grep --lang go --pattern $'EchoServiceEcho5Opts {
  $$$
  StatusProgress: $_,
  En: $_,
  NoProgress: $_
  $$$
}'

Length of output: 2606



Script:

#!/bin/bash
# Search for usage of the new parameters in the entire codebase, not just in the EchoServiceEcho5Opts struct.
rg "StatusProgress|En|NoProgress" --type go

Length of output: 337754

Comment on lines 1223 to 1225
* @param "En" (optional.String) -
* @param "NoProgress" (optional.String) -
* @param "NoNote" (optional.String) -
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search in the documentation did not yield any results specifically documenting the En, NoProgress, or NoNote parameters. The search results show unrelated mentions of "Envoy", "Environment", and other words containing "En", but nothing relevant to the parameters in question.

The ast-grep command did not return any output, which suggests that the EchoServiceEchoUnauthorizedOpts struct with the fields En, NoProgress, and NoNote is not present in the codebase or not used in the way specified in the pattern.

Based on the information provided:

  • The new parameters En, NoProgress, and NoNote are not documented in the project's documentation.
  • There is no evidence of consistent usage of the new parameters in the codebase.
Analysis chain

The En, NoProgress, and NoNote parameters have been added to the EchoServiceEchoUnauthorizedOpts struct. Verify that these additions are properly documented and used consistently.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Ensure that the new parameters are documented in the project's documentation.
rg --type md "En|NoProgress|NoNote" ./docs
# Check for consistent usage of the new parameters in the codebase.
ast-grep --lang go --pattern $'EchoServiceEchoUnauthorizedOpts {
  $$$
  En: $_,
  NoProgress: $_,
  NoNote: $_
  $$$
}'

Length of output: 2601

@johanbrandhorst johanbrandhorst merged commit 5144000 into main Jan 3, 2024
17 checks passed
@johanbrandhorst johanbrandhorst deleted the revert-json-name-query-param-filter branch January 3, 2024 19:52
charithe added a commit to cerbos/cerbos that referenced this pull request Jan 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
| [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) |
`v1.49.13` -> `v1.49.16` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go/v1.49.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go/v1.49.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go/v1.49.13/v1.49.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go/v1.49.13/v1.49.16?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | patch |
| [github.com/cerbos/cloud-api](https://togithub.com/cerbos/cloud-api) |
`v0.1.13` -> `v0.1.14` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcerbos%2fcloud-api/v0.1.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcerbos%2fcloud-api/v0.1.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcerbos%2fcloud-api/v0.1.13/v0.1.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcerbos%2fcloud-api/v0.1.13/v0.1.14?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | patch |
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| `v2.18.1` -> `v2.19.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
| [github.com/pterm/pterm](https://togithub.com/pterm/pterm) |
`v0.12.73` -> `v0.12.74` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fpterm%2fpterm/v0.12.74?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fpterm%2fpterm/v0.12.74?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fpterm%2fpterm/v0.12.73/v0.12.74?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fpterm%2fpterm/v0.12.73/v0.12.74?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | patch |
| golang.org/x/exp | `02704c9` -> `be819d1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fexp/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fexp/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fexp/v0.0.0-20231226003508-02704c960a9b/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fexp/v0.0.0-20231226003508-02704c960a9b/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | digest |
| golang.org/x/sync | `v0.5.0` -> `v0.6.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2fsync/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2fsync/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2fsync/v0.5.0/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2fsync/v0.5.0/v0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
|
[google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto)
| `995d672` -> `50ed04b` |
[![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20231212172506-995d672761c0/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20231212172506-995d672761c0/?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | digest |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary>

###
[`v1.49.16`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14916-2024-01-05)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.15...v1.49.16)

\===

##### Service Client Updates

-   `service/connect`: Updates service API
-   `service/kms`: Updates service documentation
    -   Documentation updates for AWS Key Management Service (KMS).
-   `service/redshift-serverless`: Updates service documentation

##### SDK Bugs

- The logging behavior in `aws/ec2metadata/token_provider.go` was
updated: warnings about falling back to IMDSv1 are now logged only when
LogLevel is set to `LogDebugWithDeprecated`.
- This change prevents unnecessary warnings when LogLevel is set to
suppress messages.

###
[`v1.49.15`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14915-2024-01-04)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.14...v1.49.15)

\===

##### Service Client Updates

-   `service/config`: Updates service API and documentation
-   `service/docdb`: Updates service API and documentation
- Adding PerformanceInsightsEnabled and PerformanceInsightsKMSKeyId
fields to DescribeDBInstances Response.
-   `service/ecs`: Updates service API and documentation
- This release adds support for managed instance draining which
facilitates graceful termination of Amazon ECS instances.
-   `service/es`: Updates service API and documentation
- This release adds support for new or existing Amazon OpenSearch
domains to enable TLS 1.3 or TLS 1.2 with perfect forward secrecy cipher
suites for domain endpoints.
-   `service/lightsail`: Updates service API and documentation
- This release adds support to set up an HTTPS endpoint on an instance.
-   `service/opensearch`: Updates service API and documentation
-   `service/sagemaker`: Updates service API and documentation
- Adding support for provisioned throughput mode for SageMaker Feature
Groups
-   `service/servicecatalog`: Updates service API and documentation
- Added Idempotency token support to Service Catalog
AssociateServiceActionWithProvisioningArtifact,
DisassociateServiceActionFromProvisioningArtifact, DeleteServiceAction
API

###
[`v1.49.14`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14914-2024-01-03)

[Compare
Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.13...v1.49.14)

\===

##### Service Client Updates

-   `service/connect`: Updates service API and documentation
-   `service/mediaconvert`: Updates service API and documentation
- This release includes video engine updates including HEVC
improvements, support for ingesting VP9 encoded video in MP4 containers,
and support for user-specified 3D LUTs.

</details>

<details>
<summary>cerbos/cloud-api (github.com/cerbos/cloud-api)</summary>

###
[`v0.1.14`](https://togithub.com/cerbos/cloud-api/compare/v0.1.13...v0.1.14)

[Compare
Source](https://togithub.com/cerbos/cloud-api/compare/v0.1.13...v0.1.14)

</details>

<details>
<summary>grpc-ecosystem/grpc-gateway
(github.com/grpc-ecosystem/grpc-gateway/v2)</summary>

###
[`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0)

##### What's Changed

- fix: use req.Body instead of IOReaderFactory when possible by
[@&#8203;leungster](https://togithub.com/leungster) in
[grpc-ecosystem/grpc-gateway#3727
- runtime: Add outgoing trailer matching by
[@&#8203;adriansmares](https://togithub.com/adriansmares) in
[grpc-ecosystem/grpc-gateway#3725
- Add openapiv2\_opt support for passing values to go templates via cli
by [@&#8203;500poundbear](https://togithub.com/500poundbear) in
[grpc-ecosystem/grpc-gateway#3764
- \[Bug
[#&#8203;3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)]
\[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when
generating ope… by [@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3830
- feat: partial message created as named definitions by
[@&#8203;nkcr](https://togithub.com/nkcr) in
[grpc-ecosystem/grpc-gateway#3743
- Fix name tags in methods by
[@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3843
- Revert
[`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc)
by [@&#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in
[grpc-ecosystem/grpc-gateway#3856

##### New Contributors

- [@&#8203;leungster](https://togithub.com/leungster) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3727
- [@&#8203;adriansmares](https://togithub.com/adriansmares) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3725
- [@&#8203;500poundbear](https://togithub.com/500poundbear) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3764
- [@&#8203;omrikiei](https://togithub.com/omrikiei) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3830
- [@&#8203;nkcr](https://togithub.com/nkcr) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3743

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0

</details>

<details>
<summary>pterm/pterm (github.com/pterm/pterm)</summary>

### [`v0.12.74`](https://togithub.com/pterm/pterm/releases/tag/v0.12.74)

[Compare
Source](https://togithub.com/pterm/pterm/compare/v0.12.73...v0.12.74)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

##### Exciting New Features 🎉

- feat: automatically inject more `CallerOffset` in
`pterm.NewSlogHandler` by
[@&#8203;MarvinJWendt](https://togithub.com/MarvinJWendt) in
[pterm/pterm#609

##### Other Changes

- examples: fixed `interactive_multiselect` examples by
[@&#8203;MarvinJWendt](https://togithub.com/MarvinJWendt) in
[pterm/pterm#606
- ci(examples): demo is now always at the top by
[@&#8203;MarvinJWendt](https://togithub.com/MarvinJWendt) in
[pterm/pterm#607

**Full Changelog**:
pterm/pterm@v0.12.73...v0.12.74

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Charith Ellawala <charith@cerbos.dev>
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 9, 2024
… v2.19.0 (#30353)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| `v2.18.1` -> `v2.19.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc-ecosystem/grpc-gateway
(github.com/grpc-ecosystem/grpc-gateway/v2)</summary>

###
[`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0)

#### What's Changed

- fix: use req.Body instead of IOReaderFactory when possible by
[@&#8203;leungster](https://togithub.com/leungster) in
[grpc-ecosystem/grpc-gateway#3727
- runtime: Add outgoing trailer matching by
[@&#8203;adriansmares](https://togithub.com/adriansmares) in
[grpc-ecosystem/grpc-gateway#3725
- Add openapiv2\_opt support for passing values to go templates via cli
by [@&#8203;500poundbear](https://togithub.com/500poundbear) in
[grpc-ecosystem/grpc-gateway#3764
- \[Bug
[#&#8203;3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)]
\[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when
generating ope… by [@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3830
- feat: partial message created as named definitions by
[@&#8203;nkcr](https://togithub.com/nkcr) in
[grpc-ecosystem/grpc-gateway#3743
- Fix name tags in methods by
[@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3843
- Revert
[`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc)
by [@&#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in
[grpc-ecosystem/grpc-gateway#3856

#### New Contributors

- [@&#8203;leungster](https://togithub.com/leungster) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3727
- [@&#8203;adriansmares](https://togithub.com/adriansmares) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3725
- [@&#8203;500poundbear](https://togithub.com/500poundbear) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3764
- [@&#8203;omrikiei](https://togithub.com/omrikiei) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3830
- [@&#8203;nkcr](https://togithub.com/nkcr) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3743

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
michaelkedar pushed a commit to google/osv.dev that referenced this pull request Jan 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| `v2.18.1` -> `v2.19.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
| [go](https://go.dev/) ([source](https://togithub.com/golang/go)) |
`1.21.5` -> `1.21.6` |
[![age](https://developer.mend.io/api/mc/badges/age/golang-version/go/1.21.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/golang-version/go/1.21.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/golang-version/go/1.21.5/1.21.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/golang-version/go/1.21.5/1.21.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| golang | patch |
|
[google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go)
| `v1.31.0` -> `v1.32.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fprotobuf/v1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fprotobuf/v1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fprotobuf/v1.31.0/v1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fprotobuf/v1.31.0/v1.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| require | minor |
| | All locks refreshed |
[![age](https://developer.mend.io/api/mc/badges/age///?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption///?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility////?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence////?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| | lockFileMaintenance |
| [jekyll-feed](https://togithub.com/jekyll/jekyll-feed) | `0.15.1` ->
`0.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/rubygems/jekyll-feed/0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/jekyll-feed/0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/jekyll-feed/0.15.1/0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/jekyll-feed/0.15.1/0.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| | minor |

---

### Release Notes

<details>
<summary>grpc-ecosystem/grpc-gateway
(github.com/grpc-ecosystem/grpc-gateway/v2)</summary>

###
[`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0)

#### What's Changed

- fix: use req.Body instead of IOReaderFactory when possible by
[@&#8203;leungster](https://togithub.com/leungster) in
[grpc-ecosystem/grpc-gateway#3727
- runtime: Add outgoing trailer matching by
[@&#8203;adriansmares](https://togithub.com/adriansmares) in
[grpc-ecosystem/grpc-gateway#3725
- Add openapiv2\_opt support for passing values to go templates via cli
by [@&#8203;500poundbear](https://togithub.com/500poundbear) in
[grpc-ecosystem/grpc-gateway#3764
- \[Bug
[#&#8203;3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)]
\[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when
generating ope… by [@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3830
- feat: partial message created as named definitions by
[@&#8203;nkcr](https://togithub.com/nkcr) in
[grpc-ecosystem/grpc-gateway#3743
- Fix name tags in methods by
[@&#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3843
- Revert
[`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc)
by [@&#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in
[grpc-ecosystem/grpc-gateway#3856

#### New Contributors

- [@&#8203;leungster](https://togithub.com/leungster) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3727
- [@&#8203;adriansmares](https://togithub.com/adriansmares) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3725
- [@&#8203;500poundbear](https://togithub.com/500poundbear) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3764
- [@&#8203;omrikiei](https://togithub.com/omrikiei) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3830
- [@&#8203;nkcr](https://togithub.com/nkcr) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3743

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0

</details>

<details>
<summary>golang/go (go)</summary>

###
[`v1.21.6`](https://togithub.com/golang/go/compare/go1.21.5...go1.21.6)

</details>

<details>
<summary>protocolbuffers/protobuf-go
(google.golang.org/protobuf)</summary>

###
[`v1.32.0`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.32.0)

[Compare
Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.31.0...v1.32.0)

**Full Changelog**:
protocolbuffers/protobuf-go@v1.31.0...v1.32.0

This release contains commit
protocolbuffers/protobuf-go@bfcd647,
which fixes a denial of service vulnerability by preventing a stack
overflow through a default maximum recursion limit. See
[golang/protobuf#1583
and
[golang/protobuf#1584
for details.

</details>

<details>
<summary>jekyll/jekyll-feed (jekyll-feed)</summary>

###
[`v0.17.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0170--2022-10-14)

[Compare
Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.16.0...v0.17.0)

##### Documentation

- Update CI status badge
([#&#8203;363](https://togithub.com/jekyll/jekyll-feed/issues/363))

##### Development Fixes

- Add Ruby 3.1 to the CI matrix
([#&#8203;365](https://togithub.com/jekyll/jekyll-feed/issues/365))

##### Minor Enhancements

- Allow disabling of jekyll-feed while in development
([#&#8203;370](https://togithub.com/jekyll/jekyll-feed/issues/370))

###
[`v0.16.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0160--2022-01-03)

[Compare
Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.15.1...v0.16.0)

##### Minor Enhancements

- Add support for `page.description` in front matter to become entry
`<summary>`
([#&#8203;297](https://togithub.com/jekyll/jekyll-feed/issues/297))

##### Bug Fixes

- Fold private methods into the `:render` method as local variables
([#&#8203;327](https://togithub.com/jekyll/jekyll-feed/issues/327))
- Check `post.categories` instead of `post.category`
([#&#8203;357](https://togithub.com/jekyll/jekyll-feed/issues/357))
- Switched xml_escape for `<![CDATA[]]>` for post content
([#&#8203;332](https://togithub.com/jekyll/jekyll-feed/issues/332))

##### Development Fixes

- Add Ruby 3.0 to CI
([#&#8203;337](https://togithub.com/jekyll/jekyll-feed/issues/337))
- Lock RuboCop to v1.18.x
([#&#8203;348](https://togithub.com/jekyll/jekyll-feed/issues/348))
- Add workflow to release gem via GH Action
([#&#8203;355](https://togithub.com/jekyll/jekyll-feed/issues/355))

##### Documentation

- Use `.atom` extension in documented examples since we write an Atom
feed ([#&#8203;359](https://togithub.com/jekyll/jekyll-feed/issues/359))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv.dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
… v2.19.0 (open-telemetry#30353)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| `v2.18.1` -> `v2.19.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgrpc-gateway%2fv2/v2.18.1/v2.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc-ecosystem/grpc-gateway
(github.com/grpc-ecosystem/grpc-gateway/v2)</summary>

###
[`v2.19.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.19.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.18.1...v2.19.0)

#### What's Changed

- fix: use req.Body instead of IOReaderFactory when possible by
[@&open-telemetry#8203;leungster](https://togithub.com/leungster) in
[grpc-ecosystem/grpc-gateway#3727
- runtime: Add outgoing trailer matching by
[@&open-telemetry#8203;adriansmares](https://togithub.com/adriansmares) in
[grpc-ecosystem/grpc-gateway#3725
- Add openapiv2\_opt support for passing values to go templates via cli
by [@&open-telemetry#8203;500poundbear](https://togithub.com/500poundbear) in
[grpc-ecosystem/grpc-gateway#3764
- \[Bug
[#&open-telemetry#8203;3829](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3829)]
\[protoc-gen-openapiv2] consider openapiv2\_tag.name attribute when
generating ope… by [@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3830
- feat: partial message created as named definitions by
[@&open-telemetry#8203;nkcr](https://togithub.com/nkcr) in
[grpc-ecosystem/grpc-gateway#3743
- Fix name tags in methods by
[@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) in
[grpc-ecosystem/grpc-gateway#3843
- Revert
[`4c79b45`](https://togithub.com/grpc-ecosystem/grpc-gateway/commit/4c79b45386348459926176911cb6b35f6f53dcdc)
by [@&open-telemetry#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in
[grpc-ecosystem/grpc-gateway#3856

#### New Contributors

- [@&open-telemetry#8203;leungster](https://togithub.com/leungster) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3727
- [@&open-telemetry#8203;adriansmares](https://togithub.com/adriansmares) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3725
- [@&open-telemetry#8203;500poundbear](https://togithub.com/500poundbear) made their
first contribution in
[grpc-ecosystem/grpc-gateway#3764
- [@&open-telemetry#8203;omrikiei](https://togithub.com/omrikiei) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3830
- [@&open-telemetry#8203;nkcr](https://togithub.com/nkcr) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3743

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.18.1...v2.19.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populating query param semantics changed since v2.15.0
1 participant